X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/18fecbe7ae84981626f8532c3f3ac730a50ce02a..3aaefcb3c76ff470b475d950398d01255e87712a:/lib/service/cmd.go diff --git a/lib/service/cmd.go b/lib/service/cmd.go index 7f2f78ee9a..9ca2431258 100644 --- a/lib/service/cmd.go +++ b/lib/service/cmd.go @@ -2,7 +2,7 @@ // // SPDX-License-Identifier: Apache-2.0 -// package service provides a cmd.Handler that brings up a system service. +// Package service provides a cmd.Handler that brings up a system service. package service import ( @@ -29,6 +29,7 @@ import ( type Handler interface { http.Handler CheckHealth() error + Done() <-chan struct{} } type NewHandlerFunc func(_ context.Context, _ *arvados.Cluster, token string, registry *prometheus.Registry) Handler @@ -148,9 +149,15 @@ func (c *command) RunCommand(prog string, args []string, stdin io.Reader, stdout logger.WithError(err).Errorf("error notifying init daemon") } go func() { + // Shut down server if caller cancels context <-ctx.Done() srv.Close() }() + go func() { + // Shut down server if handler dies + <-handler.Done() + srv.Close() + }() err = srv.Wait() if err != nil { return 1 @@ -158,8 +165,6 @@ func (c *command) RunCommand(prog string, args []string, stdin io.Reader, stdout return 0 } -const rfc3339NanoFixed = "2006-01-02T15:04:05.000000000Z07:00" - func getListenAddr(svcs arvados.Services, prog arvados.ServiceName, log logrus.FieldLogger) (arvados.URL, error) { svc, ok := svcs.Map()[prog] if !ok { @@ -170,6 +175,9 @@ func getListenAddr(svcs arvados.Services, prog arvados.ServiceName, log logrus.F } else if url, err := url.Parse(want); err != nil { return arvados.URL{}, fmt.Errorf("$ARVADOS_SERVICE_INTERNAL_URL (%q): %s", want, err) } else { + if url.Path == "" { + url.Path = "/" + } return arvados.URL(*url), nil }