X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/138a4b0a5de177faede5255841a5c6fca06b31f4..f69d2824c997c53caa11d30ba816768bad52e12b:/apps/workbench/test/integration/projects_test.rb diff --git a/apps/workbench/test/integration/projects_test.rb b/apps/workbench/test/integration/projects_test.rb index ce5b47e5d9..c461d3ff4b 100644 --- a/apps/workbench/test/integration/projects_test.rb +++ b/apps/workbench/test/integration/projects_test.rb @@ -1,6 +1,9 @@ require 'integration_helper' +require 'helpers/share_object_helper' class ProjectsTest < ActionDispatch::IntegrationTest + include ShareObjectHelper + setup do need_javascript end @@ -8,6 +11,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest test 'Check collection count for A Project in the tab pane titles' do project_uuid = api_fixture('groups')['aproject']['uuid'] visit page_with_token 'active', '/projects/' + project_uuid + click_link 'Data collections' wait_for_ajax collection_count = page.all("[data-pk*='collection']").count assert_selector '#Data_collections-tab span', text: "(#{collection_count})" @@ -169,73 +173,36 @@ class ProjectsTest < ActionDispatch::IntegrationTest "Project 5678 should now be inside project 1234") end - def show_project_using(auth_key, proj_key='aproject') - project_uuid = api_fixture('groups')[proj_key]['uuid'] - visit(page_with_token(auth_key, "/projects/#{project_uuid}")) - assert(page.has_text?("A Project"), "not on expected project page") + def open_groups_sharing(project_name="aproject", token_name="active") + project = api_fixture("groups", project_name) + visit(page_with_token(token_name, "/projects/#{project['uuid']}")) + click_on "Sharing" + click_on "Share with groups" end - def share_rows - find('#project_sharing').all('tr') + def group_name(group_key) + api_fixture("groups", group_key, "name") end - def add_share_and_check(share_type, name, obj=nil) - assert(page.has_no_text?(name), "project is already shared with #{name}") - start_share_count = share_rows.size - click_on("Share with #{share_type}") - within(".modal-container") do - # Order is important here: we should find something that appears in the - # modal before we make any assertions about what's not in the modal. - # Otherwise, the not-included assertions might falsely pass because - # the modal hasn't loaded yet. - find(".selectable", text: name).click - assert(has_no_selector?(".modal-dialog-preview-pane"), - "preview pane available in sharing dialog") - if share_type == 'users' and obj and obj['email'] - assert(page.has_text?(obj['email']), "Did not find user's email") - end - assert_raises(Capybara::ElementNotFound, - "Projects pulldown available from sharing dialog") do - click_on "All projects" - end - click_on "Add" - end - using_wait_time(Capybara.default_wait_time * 3) do - assert(page.has_link?(name), - "new share was not added to sharing table") - assert_equal(start_share_count + 1, share_rows.size, - "new share did not add row to sharing table") - end - end - - def modify_share_and_check(name) - start_rows = share_rows - link_row = start_rows.select { |row| row.has_text?(name) } - assert_equal(1, link_row.size, "row with new permission not found") - within(link_row.first) do - click_on("Read") - select("Write", from: "share_change_level") - click_on("editable-submit") - assert(has_link?("Write"), - "failed to change access level on new share") - click_on "Revoke" - if Capybara.current_driver == :selenium - page.driver.browser.switch_to.alert.accept - else - # poltergeist returns true for confirm(), so we don't need to accept. - end - end - wait_for_ajax - using_wait_time(Capybara.default_wait_time * 3) do - assert(page.has_no_text?(name), - "new share row still exists after being revoked") - assert_equal(start_rows.size - 1, share_rows.size, - "revoking share did not remove row from sharing table") - end + test "projects not publicly sharable when anonymous browsing disabled" do + Rails.configuration.anonymous_user_token = false + open_groups_sharing + # Check for a group we do expect first, to make sure the modal's loaded. + assert_selector(".modal-container .selectable", + text: group_name("all_users")) + assert_no_selector(".modal-container .selectable", + text: group_name("anonymous_group")) + end + + test "projects publicly sharable when anonymous browsing enabled" do + Rails.configuration.anonymous_user_token = "testonlytoken" + open_groups_sharing + assert_selector(".modal-container .selectable", + text: group_name("anonymous_group")) end test "project viewer can't see project sharing tab" do - show_project_using("project_viewer") + show_object_using('project_viewer', 'groups', 'aproject', 'A Project') assert(page.has_no_link?("Sharing"), "read-only project user sees sharing tab") end @@ -244,7 +211,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest add_user = api_fixture('users')['future_project_user'] new_name = ["first_name", "last_name"].map { |k| add_user[k] }.join(" ") - show_project_using("active") + show_object_using('active', 'groups', 'aproject', 'A Project') click_on "Sharing" add_share_and_check("users", new_name, add_user) modify_share_and_check(new_name) @@ -253,14 +220,14 @@ class ProjectsTest < ActionDispatch::IntegrationTest test "project owner can manage sharing for another group" do new_name = api_fixture('groups')['future_project_viewing_group']['name'] - show_project_using("active") + show_object_using('active', 'groups', 'aproject', 'A Project') click_on "Sharing" add_share_and_check("groups", new_name) modify_share_and_check(new_name) end test "'share with group' listing does not offer projects" do - show_project_using("active") + show_object_using('active', 'groups', 'aproject', 'A Project') click_on "Sharing" click_on "Share with groups" good_uuid = api_fixture("groups")["private"]["uuid"] @@ -290,6 +257,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/' find("#projects-menu").click find(".dropdown-menu a", text: dest['name']).click + click_link 'Data collections' assert page.has_text?(my_collection['name']), 'Collection not found in dest project after copy' when 'Move' @@ -297,18 +265,11 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/' find("#projects-menu").click find(".dropdown-menu a", text: dest['name']).click + click_link 'Data collections' assert page.has_text?(my_collection['name']), 'Collection not found in dest project after move' when 'Remove' assert page.has_no_text?(my_collection['name']), 'Collection still found in src project after remove' - visit page_with_token 'active', '/' - find("#projects-menu").click - find(".dropdown-menu a", text: "Home").click - assert page.has_text?(my_collection['name']), 'Collection not found in home project after remove' - if expect_name_change - assert page.has_text?(my_collection['name']+' removed from ' + src['name']), - 'Collection with update name is not found in home project after remove' - end end end end @@ -317,6 +278,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/' find("#projects-menu").click find(".dropdown-menu a", text: src['name']).click + click_link 'Data collections' assert page.has_text?(item['name']), 'Collection not found in src project' within('tr', text: item['name']) do @@ -355,6 +317,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest find("#projects-menu").click find(".dropdown-menu a", text: my_project['name']).click + click_link 'Data collections' click_button 'Selection' within('.selection-action-container') do assert_selector 'li.disabled', text: 'Create new collection with selected collections' @@ -368,6 +331,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/' find("#projects-menu").click find(".dropdown-menu a", text: my_project['name']).click + click_link 'Data collections' assert page.has_text?(my_collection['name']), 'Collection not found in project' within('tr', text: my_collection['name']) do @@ -501,11 +465,13 @@ class ProjectsTest < ActionDispatch::IntegrationTest end end - # "Move selected" and "Remove selected" options should not be available when current user cannot write to the project + # "Move selected" and "Remove selected" options should not be + # available when current user cannot write to the project test "move selected and remove selected actions not available when current user cannot write to project" do my_project = api_fixture('groups')['anonymously_accessible_project'] visit page_with_token 'active', "/projects/#{my_project['uuid']}" + click_link 'Data collections' click_button 'Selection' within('.selection-action-container') do assert_selector 'li', text: 'Create new collection with selected collections' @@ -527,6 +493,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token user, '/' find("#projects-menu").click find(".dropdown-menu a", text: my_project['name']).click + click_link 'Data collections' assert page.has_text?(my_collection['name']), 'Collection not found in project' within('tr', text: my_collection['name']) do @@ -546,7 +513,6 @@ class ProjectsTest < ActionDispatch::IntegrationTest assert page.has_text?("Created new collection in your Home project"), 'Not found flash message that new collection is created in Home project' end - assert page.has_text?('Content hash'), 'Not found content hash in collection page' end end @@ -710,7 +676,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/projects/' + api_fixture('groups')['aproject']['uuid'] # Point to a bad api server url to generate error - Rails.configuration.arvados_v1_base = "https://[100::f]:1/" + Rails.configuration.arvados_v1_base = "https://[::1]:1/" click_link 'Other objects' within '#Other_objects' do # Error @@ -749,11 +715,11 @@ class ProjectsTest < ActionDispatch::IntegrationTest # As of 2014-12-19, the first tab of project#show uses infinite scrolling. # Make sure that it loads data even if we visit another tab directly. need_selenium 'to land on specified tab using {url}#Advanced' - project = api_fixture("groups", "aproject") + user = api_fixture("users", "active") visit(page_with_token("active_trustedclient", - "/projects/#{project['uuid']}#Advanced")) + "/projects/#{user['uuid']}#Advanced")) assert_text("API response") find("#page-wrapper .nav-tabs :first-child a").click - assert_text("bytes Collection") + assert_text("Collection modified at") end end