X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/1301bb460ffc3e8d179492a08dbdb3a67aa080f8..ddfb91e9eee0902fba8b972e2724b2eb4707654a:/src/services/common-service/common-resource-service.test.ts diff --git a/src/services/common-service/common-resource-service.test.ts b/src/services/common-service/common-resource-service.test.ts index d00412b8a6..7f47f20ef7 100644 --- a/src/services/common-service/common-resource-service.test.ts +++ b/src/services/common-service/common-resource-service.test.ts @@ -5,8 +5,8 @@ import { CommonResourceService } from "./common-resource-service"; import axios, { AxiosInstance } from "axios"; import MockAdapter from "axios-mock-adapter"; -import { Resource } from "src/models/resource"; -import { ApiActions } from "~/services/api/api-actions"; +import { Resource } from "models/resource"; +import { ApiActions } from "services/api/api-actions"; const actions: ApiActions = { progressFn: (id: string, working: boolean) => {}, @@ -32,50 +32,50 @@ describe("CommonResourceService", () => { it("#create", async () => { axiosMock - .onPost("/resource") + .onPost("/resources") .reply(200, { owner_uuid: "ownerUuidValue" }); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); const resource = await commonResourceService.create({ ownerUuid: "ownerUuidValue" }); expect(resource).toEqual({ ownerUuid: "ownerUuidValue" }); }); it("#create maps request params to snake case", async () => { axiosInstance.post = jest.fn(() => Promise.resolve({data: {}})); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); await commonResourceService.create({ ownerUuid: "ownerUuidValue" }); - expect(axiosInstance.post).toHaveBeenCalledWith("/resource", {owner_uuid: "ownerUuidValue"}); + expect(axiosInstance.post).toHaveBeenCalledWith("/resources", {resource: {owner_uuid: "ownerUuidValue"}}); }); it("#create ignores fields listed as readonly", async () => { axiosInstance.post = jest.fn(() => Promise.resolve({data: {}})); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); // UUID fields are read-only on all resources. await commonResourceService.create({ uuid: "this should be ignored", ownerUuid: "ownerUuidValue" }); - expect(axiosInstance.post).toHaveBeenCalledWith("/resource", {owner_uuid: "ownerUuidValue"}); + expect(axiosInstance.post).toHaveBeenCalledWith("/resources", {resource: {owner_uuid: "ownerUuidValue"}}); }); it("#update ignores fields listed as readonly", async () => { axiosInstance.put = jest.fn(() => Promise.resolve({data: {}})); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); // UUID fields are read-only on all resources. await commonResourceService.update('resource-uuid', { uuid: "this should be ignored", ownerUuid: "ownerUuidValue" }); - expect(axiosInstance.put).toHaveBeenCalledWith("/resource/resource-uuid", {owner_uuid: "ownerUuidValue"}); + expect(axiosInstance.put).toHaveBeenCalledWith("/resources/resource-uuid", {resource: {owner_uuid: "ownerUuidValue"}}); }); it("#delete", async () => { axiosMock - .onDelete("/resource/uuid") + .onDelete("/resources/uuid") .reply(200, { deleted_at: "now" }); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); const resource = await commonResourceService.delete("uuid"); expect(resource).toEqual({ deletedAt: "now" }); }); it("#get", async () => { axiosMock - .onGet("/resource/uuid") + .onGet("/resources/uuid") .reply(200, { modified_at: "now", properties: { @@ -83,7 +83,7 @@ describe("CommonResourceService", () => { } }); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); const resource = await commonResourceService.get("uuid"); // Only first level keys are mapped to camel case expect(resource).toEqual({ @@ -96,7 +96,7 @@ describe("CommonResourceService", () => { it("#list", async () => { axiosMock - .onGet("/resource") + .onGet("/resources") .reply(200, { kind: "kind", offset: 2, @@ -110,7 +110,7 @@ describe("CommonResourceService", () => { items_available: 20 }); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); const resource = await commonResourceService.list({ limit: 10, offset: 1 }); // First level keys are mapped to camel case inside "items" arrays expect(resource).toEqual({ @@ -129,23 +129,24 @@ describe("CommonResourceService", () => { it("#list using POST when query string is too big", async () => { axiosMock - .onAny("/resource") + .onAny("/resources") .reply(200); const tooBig = 'x'.repeat(1500); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); await commonResourceService.list({ filters: tooBig }); expect(axiosMock.history.get.length).toBe(0); expect(axiosMock.history.post.length).toBe(1); - expect(axiosMock.history.post[0].data.get('filters')).toBe(`[${tooBig}]`); - expect(axiosMock.history.post[0].params._method).toBe('GET'); + const postParams = new URLSearchParams(axiosMock.history.post[0].data); + expect(postParams.get('filters')).toBe(`[${tooBig}]`); + expect(postParams.get('_method')).toBe('GET'); }); it("#list using GET when query string is not too big", async () => { axiosMock - .onAny("/resource") + .onAny("/resources") .reply(200); const notTooBig = 'x'.repeat(1480); - const commonResourceService = new CommonResourceService(axiosInstance, "resource", actions); + const commonResourceService = new CommonResourceService(axiosInstance, "resources", actions); await commonResourceService.list({ filters: notTooBig }); expect(axiosMock.history.post.length).toBe(0); expect(axiosMock.history.get.length).toBe(1);