X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/12eec0fb0fc7cce9d012c81b44a9684ea45d6926..a73295e64f58fe027b995e0cca3d103d4e2289ff:/lib/dispatchcloud/container/queue_test.go diff --git a/lib/dispatchcloud/container/queue_test.go b/lib/dispatchcloud/container/queue_test.go index 0075ee324e..928c6dd8c8 100644 --- a/lib/dispatchcloud/container/queue_test.go +++ b/lib/dispatchcloud/container/queue_test.go @@ -40,8 +40,9 @@ func (suite *IntegrationSuite) TearDownTest(c *check.C) { } func (suite *IntegrationSuite) TestGetLockUnlockCancel(c *check.C) { - typeChooser := func(ctr *arvados.Container) (arvados.InstanceType, error) { - return arvados.InstanceType{Name: "testType"}, nil + typeChooser := func(ctr *arvados.Container) ([]arvados.InstanceType, error) { + c.Check(ctr.Mounts["/tmp"].Capacity, check.Equals, int64(24000000000)) + return []arvados.InstanceType{{Name: "testType"}}, nil } client := arvados.NewClientFromEnv() @@ -61,9 +62,12 @@ func (suite *IntegrationSuite) TestGetLockUnlockCancel(c *check.C) { var wg sync.WaitGroup for uuid, ent := range ents { c.Check(ent.Container.UUID, check.Equals, uuid) - c.Check(ent.InstanceType.Name, check.Equals, "testType") + c.Check(ent.InstanceTypes, check.HasLen, 1) + c.Check(ent.InstanceTypes[0].Name, check.Equals, "testType") c.Check(ent.Container.State, check.Equals, arvados.ContainerStateQueued) c.Check(ent.Container.Priority > 0, check.Equals, true) + // Mounts should be deleted to avoid wasting memory + c.Check(ent.Container.Mounts, check.IsNil) ctr, ok := cq.Get(uuid) c.Check(ok, check.Equals, true) @@ -105,7 +109,7 @@ func (suite *IntegrationSuite) TestGetLockUnlockCancel(c *check.C) { } func (suite *IntegrationSuite) TestCancelIfNoInstanceType(c *check.C) { - errorTypeChooser := func(ctr *arvados.Container) (arvados.InstanceType, error) { + errorTypeChooser := func(ctr *arvados.Container) ([]arvados.InstanceType, error) { // Make sure the relevant container fields are // actually populated. c.Check(ctr.ContainerImage, check.Equals, "test") @@ -113,7 +117,7 @@ func (suite *IntegrationSuite) TestCancelIfNoInstanceType(c *check.C) { c.Check(ctr.RuntimeConstraints.RAM, check.Equals, int64(12000000000)) c.Check(ctr.Mounts["/tmp"].Capacity, check.Equals, int64(24000000000)) c.Check(ctr.Mounts["/var/spool/cwl"].Capacity, check.Equals, int64(24000000000)) - return arvados.InstanceType{}, errors.New("no suitable instance type") + return nil, errors.New("no suitable instance type") } client := arvados.NewClientFromEnv()