X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/12bfd7a65c6635a882cb2e5e419321db100b9d56..f98e0188777b3e2d229c968824b3e64307dae4e6:/services/api/app/models/user.rb diff --git a/services/api/app/models/user.rb b/services/api/app/models/user.rb index 553a3be5ae..9209411f1e 100644 --- a/services/api/app/models/user.rb +++ b/services/api/app/models/user.rb @@ -1,4 +1,9 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'can_be_an_owner' +require 'refresh_permission_view' class User < ArvadosModel include HasUuid @@ -10,7 +15,7 @@ class User < ArvadosModel has_many :api_client_authorizations validates(:username, format: { - with: /^[A-Za-z][A-Za-z0-9]*$/, + with: /\A[A-Za-z][A-Za-z0-9]*\z/, message: "must begin with a letter and contain only alphanumerics", }, uniqueness: true, @@ -20,11 +25,13 @@ class User < ArvadosModel before_update :verify_repositories_empty, :if => Proc.new { |user| user.username.nil? and user.username_changed? } + before_update :setup_on_activate before_create :check_auto_admin before_create :set_initial_username, :if => Proc.new { |user| user.username.nil? and user.email } after_create :add_system_group_permission_link + after_create :invalidate_permissions_cache after_create :auto_setup_new_user, :if => Proc.new { |user| Rails.configuration.auto_setup_new_users and (user.uuid != system_user_uuid) and @@ -57,6 +64,14 @@ class User < ArvadosModel ALL_PERMISSIONS = {read: true, write: true, manage: true} + # Map numeric permission levels (see lib/create_permission_view.sql) + # back to read/write/manage flags. + PERMS_FOR_VAL = + [{}, + {read: true}, + {read: true, write: true}, + {read: true, write: true, manage: true}] + def full_name "#{first_name} #{last_name}".strip end @@ -64,7 +79,7 @@ class User < ArvadosModel def is_invited !!(self.is_active || Rails.configuration.new_users_are_active || - self.groups_i_can(:read).select { |x| x.match /-f+$/ }.first) + self.groups_i_can(:read).select { |x| x.match(/-f+$/) }.first) end def groups_i_can(verb) @@ -128,96 +143,55 @@ class User < ArvadosModel timestamp = DbCurrentTime::db_current_time.to_i if timestamp.nil? connection.execute "NOTIFY invalidate_permissions_cache, '#{timestamp}'" else - Rails.cache.delete_matched(/^groups_for_user_/) + refresh_permission_view end end - # Return a hash of {group_uuid: perm_hash} where perm_hash[:read] - # and perm_hash[:write] are true if this user can read and write - # objects owned by group_uuid. - # - # The permission graph is built by repeatedly enumerating all - # permission links reachable from self.uuid, and then calling - # search_permissions - def calculate_group_permissions - permissions_from = {} - todo = {self.uuid => true} - done = {} - # Build the equivalence class of permissions starting with - # self.uuid. On each iteration of this loop, todo contains - # the next set of uuids in the permission equivalence class - # to evaluate. - while !todo.empty? - lookup_uuids = todo.keys - lookup_uuids.each do |uuid| done[uuid] = true end - todo = {} - newgroups = [] - # include all groups owned by the current set of uuids. - Group.where('owner_uuid in (?)', lookup_uuids).each do |group| - newgroups << [group.owner_uuid, group.uuid, 'can_manage'] - end - # add any permission links from the current lookup_uuids to a Group. - Link.where('link_class = ? and tail_uuid in (?) and ' \ - '(head_uuid like ? or (name = ? and head_uuid like ?))', - 'permission', - lookup_uuids, - Group.uuid_like_pattern, - 'can_manage', - User.uuid_like_pattern).each do |link| - newgroups << [link.tail_uuid, link.head_uuid, link.name] - end - newgroups.each do |tail_uuid, head_uuid, perm_name| - unless done.has_key? head_uuid - todo[head_uuid] = true - end - link_permissions = {} - case perm_name - when 'can_read' - link_permissions = {read:true} - when 'can_write' - link_permissions = {read:true,write:true} - when 'can_manage' - link_permissions = ALL_PERMISSIONS - end - permissions_from[tail_uuid] ||= {} - permissions_from[tail_uuid][head_uuid] ||= {} - link_permissions.each do |k,v| - permissions_from[tail_uuid][head_uuid][k] ||= v - end - end - end - perms = search_permissions(self.uuid, permissions_from) - Rails.cache.write "groups_for_user_#{self.uuid}", perms - perms + def invalidate_permissions_cache(timestamp=nil) + User.invalidate_permissions_cache + end + + # Return a hash of {user_uuid: group_perms} + def self.all_group_permissions + all_perms = {} + ActiveRecord::Base.connection. + exec_query("SELECT user_uuid, target_owner_uuid, perm_level, trashed + FROM #{PERMISSION_VIEW} + WHERE target_owner_uuid IS NOT NULL", + # "name" arg is a query label that appears in logs: + "all_group_permissions", + ).rows.each do |user_uuid, group_uuid, max_p_val, trashed| + all_perms[user_uuid] ||= {} + all_perms[user_uuid][group_uuid] = PERMS_FOR_VAL[max_p_val.to_i] + end + all_perms end # Return a hash of {group_uuid: perm_hash} where perm_hash[:read] # and perm_hash[:write] are true if this user can read and write # objects owned by group_uuid. def group_permissions - r = Rails.cache.read "groups_for_user_#{self.uuid}" - if r.nil? - if Rails.configuration.async_permissions_update - while r.nil? - sleep(0.1) - r = Rails.cache.read "groups_for_user_#{self.uuid}" - end - else - r = calculate_group_permissions - end + group_perms = {self.uuid => {:read => true, :write => true, :manage => true}} + ActiveRecord::Base.connection. + exec_query("SELECT target_owner_uuid, perm_level, trashed + FROM #{PERMISSION_VIEW} + WHERE user_uuid = $1 + AND target_owner_uuid IS NOT NULL", + # "name" arg is a query label that appears in logs: + "group_permissions for #{uuid}", + # "binds" arg is an array of [col_id, value] for '$1' vars: + [[nil, uuid]], + ).rows.each do |group_uuid, max_p_val, trashed| + group_perms[group_uuid] = PERMS_FOR_VAL[max_p_val.to_i] end - r - end - - def self.setup(user, openid_prefix, repo_name=nil, vm_uuid=nil) - return user.setup_repo_vm_links(repo_name, vm_uuid, openid_prefix) + group_perms end # create links - def setup_repo_vm_links(repo_name, vm_uuid, openid_prefix) + def setup(openid_prefix:, repo_name: nil, vm_uuid: nil) oid_login_perm = create_oid_login_perm openid_prefix repo_perm = create_user_repo_link repo_name - vm_login_perm = create_vm_login_permission_link vm_uuid, username + vm_login_perm = create_vm_login_permission_link(vm_uuid, username) if vm_uuid group_perm = create_user_group_link return [oid_login_perm, repo_perm, vm_login_perm, group_perm, self].compact @@ -242,7 +216,7 @@ class User < ArvadosModel # delete "All users" group read permissions for this user group = Group.where(name: 'All users').select do |g| - g[:uuid].match /-f+$/ + g[:uuid].match(/-f+$/) end.first Link.destroy_all(tail_uuid: self.uuid, head_uuid: group[:uuid], @@ -261,6 +235,51 @@ class User < ArvadosModel self.save! end + def set_initial_username(requested: false) + if !requested.is_a?(String) || requested.empty? + email_parts = email.partition("@") + local_parts = email_parts.first.partition("+") + if email_parts.any?(&:empty?) + return + elsif not local_parts.first.empty? + requested = local_parts.first + else + requested = email_parts.first + end + end + requested.sub!(/^[^A-Za-z]+/, "") + requested.gsub!(/[^A-Za-z0-9]/, "") + unless requested.empty? + self.username = find_usable_username_from(requested) + end + end + + def update_uuid(new_uuid:) + if !current_user.andand.is_admin + raise PermissionDeniedError + end + if uuid == system_user_uuid || uuid == anonymous_user_uuid + raise "update_uuid cannot update system accounts" + end + if self.class != self.class.resource_class_for_uuid(new_uuid) + raise "invalid new_uuid #{new_uuid.inspect}" + end + transaction(requires_new: true) do + reload + old_uuid = self.uuid + self.uuid = new_uuid + save!(validate: false) + ActiveRecord::Base.descendants.reject(&:abstract_class?).each do |klass| + klass.columns.each do |col| + if col.name.end_with?('_uuid') + column = col.name.to_sym + klass.where(column => old_uuid).update_all(column => new_uuid) + end + end + end + end + end + protected def ensure_ownership_path_leads_to_user @@ -312,8 +331,8 @@ class User < ArvadosModel self.class. where("username like '#{pattern}'"). select(:username). - order(username: :asc). - find_each do |other_user| + order('username asc'). + each do |other_user| if other_user.username > next_username break elsif other_user.username == next_username @@ -326,23 +345,6 @@ class User < ArvadosModel nil end - def set_initial_username - email_parts = email.partition("@") - local_parts = email_parts.first.partition("+") - if email_parts.any?(&:empty?) - return - elsif not local_parts.first.empty? - base_username = local_parts.first - else - base_username = email_parts.first - end - base_username.sub!(/^[^A-Za-z]+/, "") - base_username.gsub!(/[^A-Za-z0-9]/, "") - unless base_username.empty? - self.username = find_usable_username_from(base_username) - end - end - def prevent_privilege_escalation if current_user.andand.is_admin return true @@ -389,13 +391,12 @@ class User < ArvadosModel merged end - def create_oid_login_perm (openid_prefix) - login_perm_props = { "identity_url_prefix" => openid_prefix} - + def create_oid_login_perm(openid_prefix) # Check oid_login_perm oid_login_perms = Link.where(tail_uuid: self.email, - link_class: 'permission', - name: 'can_login').where("head_uuid = ?", self.uuid) + head_uuid: self.uuid, + link_class: 'permission', + name: 'can_login') if !oid_login_perms.any? # create openid login permission @@ -403,8 +404,9 @@ class User < ArvadosModel name: 'can_login', tail_uuid: self.email, head_uuid: self.uuid, - properties: login_perm_props - ) + properties: { + "identity_url_prefix" => openid_prefix, + }) logger.info { "openid login permission: " + oid_login_perm[:uuid] } else oid_login_perm = oid_login_perms.first @@ -432,15 +434,12 @@ class User < ArvadosModel # create login permission for the given vm_uuid, if it does not already exist def create_vm_login_permission_link(vm_uuid, repo_name) # vm uuid is optional - if vm_uuid - vm = VirtualMachine.where(uuid: vm_uuid).first + return if !vm_uuid - if not vm - logger.warn "Could not find virtual machine for #{vm_uuid.inspect}" - raise "No vm found for #{vm_uuid}" - end - else - return + vm = VirtualMachine.where(uuid: vm_uuid).first + if !vm + logger.warn "Could not find virtual machine for #{vm_uuid.inspect}" + raise "No vm found for #{vm_uuid}" end logger.info { "vm uuid: " + vm[:uuid] } @@ -487,15 +486,23 @@ class User < ArvadosModel # Send admin notifications def send_admin_notifications - AdminNotifier.new_user(self).deliver + AdminNotifier.new_user(self).deliver_now if not self.is_active then - AdminNotifier.new_inactive_user(self).deliver + AdminNotifier.new_inactive_user(self).deliver_now + end + end + + # Automatically setup if is_active flag turns on + def setup_on_activate + return if [system_user_uuid, anonymous_user_uuid].include?(self.uuid) + if is_active && (new_record? || is_active_changed?) + setup(openid_prefix: Rails.configuration.default_openid_prefix) end end # Automatically setup new user during creation def auto_setup_new_user - setup_repo_vm_links(nil, nil, Rails.configuration.default_openid_prefix) + setup(openid_prefix: Rails.configuration.default_openid_prefix) if username create_vm_login_permission_link(Rails.configuration.auto_setup_new_users_with_vm_uuid, username) @@ -514,7 +521,7 @@ class User < ArvadosModel if self.prefs_changed? if self.prefs_was.andand.empty? || !self.prefs_was.andand['profile'] profile_notification_address = Rails.configuration.user_profile_notification_address - ProfileNotifier.profile_created(self, profile_notification_address).deliver if profile_notification_address + ProfileNotifier.profile_created(self, profile_notification_address).deliver_now if profile_notification_address end end end