X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/126dd750f48654cb3b1a4e53c5b7d337003e112f..f15c51d123da2db1deeeb0e76685cf17eb56e039:/services/api/app/models/arvados_model.rb diff --git a/services/api/app/models/arvados_model.rb b/services/api/app/models/arvados_model.rb index 5fdb5f3e2f..0828d01687 100644 --- a/services/api/app/models/arvados_model.rb +++ b/services/api/app/models/arvados_model.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'has_uuid' require 'record_filters' require 'serializers' @@ -46,6 +50,12 @@ class ArvadosModel < ActiveRecord::Base end end + class LockFailedError < StandardError + def http_status + 422 + end + end + class InvalidStateTransitionError < StandardError def http_status 422 @@ -98,6 +108,12 @@ class ArvadosModel < ActiveRecord::Base super(self.class.permit_attribute_params(raw_params), *args) end + # Reload "old attributes" for logging, too. + def reload(*args) + super + log_start_state + end + def self.create raw_params={}, *args super(permit_attribute_params(raw_params), *args) end @@ -184,6 +200,14 @@ class ArvadosModel < ActiveRecord::Base ["id", "uuid"] end + def self.limit_index_columns_read + # This method returns a list of column names. + # If an index request reads that column from the database, + # APIs that return lists will only fetch objects until reaching + # max_index_database_read bytes of data from those columns. + [] + end + # If current user can manage the object, return an array of uuids of # users and groups that have permission to write the object. The # first two elements are always [self.owner_uuid, current user's @@ -228,48 +252,52 @@ class ArvadosModel < ActiveRecord::Base kwargs = {} end - # Check if any of the users are admin. If so, we're done. - if users_list.select { |u| u.is_admin }.any? - return self - end - # Collect the UUIDs of the authorized users. - user_uuids = users_list.map { |u| u.uuid } - - # Collect the UUIDs of all groups readable by any of the - # authorized users. If one of these (or the UUID of one of the - # authorized users themselves) is an object's owner_uuid, that - # object is readable. - owner_uuids = user_uuids + users_list.flat_map { |u| u.groups_i_can(:read) } - owner_uuids.uniq! + sql_table = kwargs.fetch(:table_name, table_name) + include_trash = kwargs.fetch(:include_trash, false) + query_on = kwargs.fetch(:query_on, self) sql_conds = [] - sql_table = kwargs.fetch(:table_name, table_name) + user_uuids = users_list.map { |u| u.uuid } - # Match any object (evidently a group or user) whose UUID is - # listed explicitly in owner_uuids. - sql_conds += ["#{sql_table}.uuid in (:owner_uuids)"] + if users_list.select { |u| u.is_admin }.any? + if !include_trash + # exclude rows that are explicitly trashed. + if sql_table != "api_client_authorizations" + sql_conds.push "NOT EXISTS(SELECT 1 + FROM #{PERMISSION_VIEW} + WHERE trashed = 1 AND + (#{sql_table}.uuid = target_uuid OR #{sql_table}.owner_uuid = target_uuid))" + end + end + else + if include_trash + trashed_check = "" + else + trashed_check = "AND trashed = 0" + end - # Match any object whose owner is listed explicitly in - # owner_uuids. - sql_conds += ["#{sql_table}.owner_uuid IN (:owner_uuids)"] + if sql_table != "api_client_authorizations" and sql_table != "groups" + owner_check = "OR (target_uuid = #{sql_table}.owner_uuid AND target_owner_uuid IS NOT NULL)" + else + owner_check = "" + end - # Match the head of any permission link whose tail is listed - # explicitly in owner_uuids. - sql_conds += ["#{sql_table}.uuid IN (SELECT head_uuid FROM links WHERE link_class='permission' AND tail_uuid IN (:owner_uuids))"] + sql_conds.push "EXISTS(SELECT 1 FROM #{PERMISSION_VIEW} "+ + "WHERE user_uuid IN (:user_uuids) AND perm_level >= 1 #{trashed_check} AND (target_uuid = #{sql_table}.uuid #{owner_check}))" - if sql_table == "links" - # Match any permission link that gives one of the authorized - # users some permission _or_ gives anyone else permission to - # view one of the authorized users. - sql_conds += ["(#{sql_table}.link_class in (:permission_link_classes) AND "+ - "(#{sql_table}.head_uuid IN (:user_uuids) OR #{sql_table}.tail_uuid IN (:user_uuids)))"] + if sql_table == "links" + # Match any permission link that gives one of the authorized + # users some permission _or_ gives anyone else permission to + # view one of the authorized users. + sql_conds.push "(#{sql_table}.link_class IN (:permission_link_classes) AND "+ + "(#{sql_table}.head_uuid IN (:user_uuids) OR #{sql_table}.tail_uuid IN (:user_uuids)))" + end end - where(sql_conds.join(' OR '), - owner_uuids: owner_uuids, - user_uuids: user_uuids, - permission_link_classes: ['permission', 'resources']) + query_on.where(sql_conds.join(' OR '), + user_uuids: user_uuids, + permission_link_classes: ['permission', 'resources']) end def save_with_unique_name! @@ -415,36 +443,31 @@ class ArvadosModel < ActiveRecord::Base raise PermissionDeniedError end - # Verify "write" permission on old owner - # default fail unless one of: - # owner_uuid did not change - # previous owner_uuid is nil - # current user is the old owner - # current user is this object - # current user can_write old owner - unless !owner_uuid_changed? or - owner_uuid_was.nil? or - current_user.uuid == self.owner_uuid_was or - current_user.uuid == self.uuid or - current_user.can? write: self.owner_uuid_was - logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{uuid} but does not have permission to write old owner_uuid #{owner_uuid_was}" - errors.add :owner_uuid, "cannot be changed without write permission on old owner" - raise PermissionDeniedError - end - - # Verify "write" permission on new owner - # default fail unless one of: - # current_user is this object - # current user can_write new owner, or this object if owner unchanged - if new_record? or owner_uuid_changed? or is_a?(ApiClientAuthorization) - write_target = owner_uuid + if new_record? || owner_uuid_changed? + # Permission on owner_uuid_was is needed to move an existing + # object away from its previous owner (which implies permission + # to modify this object itself, so we don't need to check that + # separately). Permission on the new owner_uuid is also needed. + [['old', owner_uuid_was], + ['new', owner_uuid] + ].each do |which, check_uuid| + if check_uuid.nil? + # old_owner_uuid is nil? New record, no need to check. + elsif !current_user.can?(write: check_uuid) + logger.warn "User #{current_user.uuid} tried to set ownership of #{self.class.to_s} #{self.uuid} but does not have permission to write #{which} owner_uuid #{check_uuid}" + errors.add :owner_uuid, "cannot be set or changed without write permission on #{which} owner" + raise PermissionDeniedError + end + end else - write_target = uuid - end - unless current_user == self or current_user.can? write: write_target - logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{uuid} but does not have permission to write new owner_uuid #{owner_uuid}" - errors.add :owner_uuid, "cannot be changed without write permission on new owner" - raise PermissionDeniedError + # If the object already existed and we're not changing + # owner_uuid, we only need write permission on the object + # itself. + if !current_user.can?(write: self.uuid) + logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{self.uuid} without write permission" + errors.add :uuid, "is not writable" + raise PermissionDeniedError + end end true