X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/0e01a46b111ee565c236f3be8d8fed894fc35a5e..f9ba8a730dbc1a457485886aa4591991e9dbbf0d:/apps/workbench/test/integration/projects_test.rb diff --git a/apps/workbench/test/integration/projects_test.rb b/apps/workbench/test/integration/projects_test.rb index ae156b8a53..5da61536f0 100644 --- a/apps/workbench/test/integration/projects_test.rb +++ b/apps/workbench/test/integration/projects_test.rb @@ -161,7 +161,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest end wait_for_ajax - click_link 'Move to project...' + click_link 'Move project...' find('.selectable', text: 'Project 1234').click find('.modal-footer a,button', text: 'Move').click wait_for_ajax @@ -182,7 +182,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest find('#project_sharing').all('tr') end - def add_share_and_check(share_type, name) + def add_share_and_check(share_type, name, obj=nil) assert(page.has_no_text?(name), "project is already shared with #{name}") start_share_count = share_rows.size click_on("Share with #{share_type}") @@ -194,6 +194,9 @@ class ProjectsTest < ActionDispatch::IntegrationTest find(".selectable", text: name).click assert(has_no_selector?(".modal-dialog-preview-pane"), "preview pane available in sharing dialog") + if share_type == 'users' and obj and obj['email'] + assert(page.has_text?(obj['email']), "Did not find user's email") + end assert_raises(Capybara::ElementNotFound, "Projects pulldown available from sharing dialog") do click_on "All projects" @@ -240,7 +243,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest show_project_using("active") click_on "Sharing" - add_share_and_check("users", new_name) + add_share_and_check("users", new_name, add_user) modify_share_and_check(new_name) end @@ -439,32 +442,44 @@ class ProjectsTest < ActionDispatch::IntegrationTest end end - test "combine selected collections into new collection" do - my_project = api_fixture('groups')['aproject'] - my_collection = api_fixture('collections')['collection_to_move_around_in_aproject'] - - visit page_with_token 'active', '/' - find("#projects-menu").click - find(".dropdown-menu a", text: my_project['name']).click - assert page.has_text?(my_collection['name']), 'Collection not found in project' + [ + ['active', true], + ['project_viewer', false], + ].each do |user, expect_collection_in_aproject| + test "combine selected collections into new collection #{user} #{expect_collection_in_aproject}" do + my_project = api_fixture('groups')['aproject'] + my_collection = api_fixture('collections')['collection_to_move_around_in_aproject'] + + visit page_with_token user, '/' + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click + assert page.has_text?(my_collection['name']), 'Collection not found in project' + + within('tr', text: my_collection['name']) do + find('input[type=checkbox]').click + end - within('tr', text: my_collection['name']) do - find('input[type=checkbox]').click - end + click_button 'Selection...' + within('.selection-action-container') do + click_link 'Create new collection with selected collections' + end - click_button 'Selection...' - within('.selection-action-container') do - click_link 'Create new collection with selected collections' + # now in the new collection page + if expect_collection_in_aproject + assert page.has_text?("Created new collection in the project #{my_project['name']}"), + 'Not found flash message that new collection is created in aproject' + else + assert page.has_text?("Created new collection in your Home project"), + 'Not found flash message that new collection is created in Home project' + end + assert page.has_text?('Content hash'), 'Not found content hash in collection page' end - - # back in project page - assert page.has_text?(my_collection['name']), 'Collection not found in project' - assert page.has_link?('Jobs and pipelines'), 'Jobs and pipelines link not found in project' end - [["jobs", "/jobs"], - ["pipelines", "/pipeline_instances"], - ["collections", "/collections"] + [ + ["jobs", "/jobs"], + ["pipelines", "/pipeline_instances"], + ["collections", "/collections"] ].each do |target,path| test "Test dashboard button all #{target}" do visit page_with_token 'active', '/' @@ -473,4 +488,150 @@ class ProjectsTest < ActionDispatch::IntegrationTest end end + def scroll_setup(project_name, + total_nbr_items, + item_list_parameter, + sorted = false, + sort_parameters = nil) + headless = Headless.new + headless.start + Capybara.current_driver = :selenium + + project_uuid = api_fixture('groups')[project_name]['uuid'] + visit page_with_token 'user1_with_load', '/projects/' + project_uuid + + assert(page.has_text?("#{item_list_parameter.humanize} (#{total_nbr_items})"), "Number of #{item_list_parameter.humanize} did not match the input amount") + + click_link item_list_parameter.humanize + wait_for_ajax + + if sorted + find("th[data-sort-order='#{sort_parameters.gsub(/\s/,'')}']").click + wait_for_ajax + end + end + + def scroll_items_check(nbr_items, + fixture_prefix, + item_list_parameter, + item_selector, + sorted = false) + items = [] + for i in 1..nbr_items + items << "#{fixture_prefix}#{i}" + end + + verify_items = items.dup + unexpected_items = [] + item_count = 0 + within(".arv-project-#{item_list_parameter}") do + page.execute_script "window.scrollBy(0,999000)" + begin + wait_for_ajax + rescue + end + + # Visit all rows. If not all expected items are found, retry + found_items = page.all(item_selector) + item_count = found_items.count + + previous = nil + (0..item_count-1).each do |i| + # Found row text using the fixture string e.g. "Show Collection_#{n} " + item_name = found_items[i].text.split[1] + if !items.include? item_name + unexpected_items << item_name + else + verify_items.delete item_name + end + if sorted + # check sort order + assert_operator( previous.downcase, :<=, item_name.downcase) if previous + previous = item_name + end + end + + assert_equal true, unexpected_items.empty?, "Found unexpected #{item_list_parameter.humanize} #{unexpected_items.inspect}" + assert_equal nbr_items, item_count, "Found different number of #{item_list_parameter.humanize}" + assert_equal true, verify_items.empty?, "Did not find all the #{item_list_parameter.humanize}" + end + end + + [ + ['project_with_10_collections', 10], + ['project_with_201_collections', 201], # two pages of data + ].each do |project_name, nbr_items| + test "scroll collections tab for #{project_name} with #{nbr_items} objects" do + item_list_parameter = "Data_collections" + scroll_setup project_name, + nbr_items, + item_list_parameter + scroll_items_check nbr_items, + "Collection_", + item_list_parameter, + 'tr[data-kind="arvados#collection"]' + end + end + + [ + ['project_with_10_collections', 10], + ['project_with_201_collections', 201], # two pages of data + ].each do |project_name, nbr_items| + test "scroll collections tab for #{project_name} with #{nbr_items} objects with ascending sort (case insensitive)" do + item_list_parameter = "Data_collections" + scroll_setup project_name, + nbr_items, + item_list_parameter, + true, + "collections.name" + scroll_items_check nbr_items, + "Collection_", + item_list_parameter, + 'tr[data-kind="arvados#collection"]', + true + end + end + + [ + ['project_with_10_pipelines', 10, 0], + ['project_with_2_pipelines_and_60_jobs', 2, 60], + ['project_with_25_pipelines', 25, 0], + ].each do |project_name, num_pipelines, num_jobs| + test "scroll pipeline instances tab for #{project_name} with #{num_pipelines} pipelines and #{num_jobs} jobs" do + item_list_parameter = "Jobs_and_pipelines" + scroll_setup project_name, + num_pipelines + num_jobs, + item_list_parameter + # check the general scrolling and the pipelines + scroll_items_check num_pipelines, + "pipeline_", + item_list_parameter, + 'tr[data-kind="arvados#pipelineInstance"]' + # Check job count separately + jobs_found = page.all('tr[data-kind="arvados#job"]') + found_job_count = jobs_found.count + assert_equal num_jobs, found_job_count, 'Did not find expected number of jobs' + end + end + + # Move button accessibility + [ + ['admin', true], + ['active', true], # project owner + ['project_viewer', false], + ].each do |user, can_move| + test "#{user} can move subproject under another user's Home #{can_move}" do + project = api_fixture('groups')['aproject'] + collection = api_fixture('collections')['collection_to_move_around_in_aproject'] + + # verify the project move button + visit page_with_token user, "/projects/#{project['uuid']}" + if can_move + assert page.has_link? 'Move project...' + else + assert page.has_no_link? 'Move project...' + end + end + end + end