X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/0a98952530fb465fa31566fa5e0192bea9fc16e4..b53513423ab948804425424278ac554870864997:/sdk/go/arvados/client_test.go?ds=sidebyside

diff --git a/sdk/go/arvados/client_test.go b/sdk/go/arvados/client_test.go
index 2db50bfd6c..2363803cab 100644
--- a/sdk/go/arvados/client_test.go
+++ b/sdk/go/arvados/client_test.go
@@ -1,3 +1,7 @@
+// Copyright (C) The Arvados Authors. All rights reserved.
+//
+// SPDX-License-Identifier: Apache-2.0
+
 package arvados
 
 import (
@@ -5,8 +9,13 @@ import (
 	"fmt"
 	"io/ioutil"
 	"net/http"
+	"net/url"
+	"os"
+	"strings"
 	"sync"
-	"testing"
+	"testing/iotest"
+
+	check "gopkg.in/check.v1"
 )
 
 type stubTransport struct {
@@ -46,38 +55,165 @@ func (stub *errorTransport) RoundTrip(req *http.Request) (*http.Response, error)
 	return nil, fmt.Errorf("something awful happened")
 }
 
-func TestCurrentUser(t *testing.T) {
-	t.Parallel()
+type timeoutTransport struct {
+	response []byte
+}
+
+func (stub *timeoutTransport) RoundTrip(req *http.Request) (*http.Response, error) {
+	return &http.Response{
+		Status:     "200 OK",
+		StatusCode: 200,
+		Proto:      "HTTP/1.1",
+		ProtoMajor: 1,
+		ProtoMinor: 1,
+		Request:    req,
+		Body:       ioutil.NopCloser(iotest.TimeoutReader(bytes.NewReader(stub.response))),
+	}, nil
+}
+
+var _ = check.Suite(&clientSuite{})
+
+type clientSuite struct{}
+
+func (*clientSuite) TestCurrentUser(c *check.C) {
 	stub := &stubTransport{
 		Responses: map[string]string{
 			"/arvados/v1/users/current": `{"uuid":"zzzzz-abcde-012340123401234"}`,
 		},
 	}
-	c := &Client{
+	client := &Client{
 		Client: &http.Client{
 			Transport: stub,
 		},
 		APIHost:   "zzzzz.arvadosapi.com",
 		AuthToken: "xyzzy",
 	}
-	u, err := c.CurrentUser()
-	if err != nil {
-		t.Fatal(err)
-	}
-	if x := "zzzzz-abcde-012340123401234"; u.UUID != x {
-		t.Errorf("got uuid %q, expected %q", u.UUID, x)
-	}
-	if len(stub.Requests) < 1 {
-		t.Fatal("empty stub.Requests")
-	}
+	u, err := client.CurrentUser()
+	c.Check(err, check.IsNil)
+	c.Check(u.UUID, check.Equals, "zzzzz-abcde-012340123401234")
+	c.Check(stub.Requests, check.Not(check.HasLen), 0)
 	hdr := stub.Requests[len(stub.Requests)-1].Header
-	if hdr.Get("Authorization") != "OAuth2 xyzzy" {
-		t.Errorf("got headers %+q, expected Authorization header", hdr)
+	c.Check(hdr.Get("Authorization"), check.Equals, "OAuth2 xyzzy")
+
+	client.Client.Transport = &errorTransport{}
+	u, err = client.CurrentUser()
+	c.Check(err, check.NotNil)
+}
+
+func (*clientSuite) TestAnythingToValues(c *check.C) {
+	type testCase struct {
+		in interface{}
+		// ok==nil means anythingToValues should return an
+		// error, otherwise it's a func that returns true if
+		// out is correct
+		ok func(out url.Values) bool
 	}
+	for _, tc := range []testCase{
+		{
+			in: map[string]interface{}{"foo": "bar"},
+			ok: func(out url.Values) bool {
+				return out.Get("foo") == "bar"
+			},
+		},
+		{
+			in: map[string]interface{}{"foo": 2147483647},
+			ok: func(out url.Values) bool {
+				return out.Get("foo") == "2147483647"
+			},
+		},
+		{
+			in: map[string]interface{}{"foo": 1.234},
+			ok: func(out url.Values) bool {
+				return out.Get("foo") == "1.234"
+			},
+		},
+		{
+			in: map[string]interface{}{"foo": "1.234"},
+			ok: func(out url.Values) bool {
+				return out.Get("foo") == "1.234"
+			},
+		},
+		{
+			in: map[string]interface{}{"foo": map[string]interface{}{"bar": 1.234}},
+			ok: func(out url.Values) bool {
+				return out.Get("foo") == `{"bar":1.234}`
+			},
+		},
+		{
+			in: url.Values{"foo": {"bar"}},
+			ok: func(out url.Values) bool {
+				return out.Get("foo") == "bar"
+			},
+		},
+		{
+			in: 1234,
+			ok: nil,
+		},
+		{
+			in: []string{"foo"},
+			ok: nil,
+		},
+	} {
+		c.Logf("%#v", tc.in)
+		out, err := anythingToValues(tc.in)
+		if tc.ok == nil {
+			c.Check(err, check.NotNil)
+			continue
+		}
+		c.Check(err, check.IsNil)
+		c.Check(tc.ok(out), check.Equals, true)
+	}
+}
 
-	c.Client.Transport = &errorTransport{}
-	u, err = c.CurrentUser()
-	if err == nil {
-		t.Errorf("got nil error, expected something awful")
+func (*clientSuite) TestLoadConfig(c *check.C) {
+	oldenv := os.Environ()
+	defer func() {
+		os.Clearenv()
+		for _, s := range oldenv {
+			i := strings.IndexRune(s, '=')
+			os.Setenv(s[:i], s[i+1:])
+		}
+	}()
+
+	tmp := c.MkDir()
+	os.Setenv("HOME", tmp)
+	for _, s := range os.Environ() {
+		if strings.HasPrefix(s, "ARVADOS_") {
+			i := strings.IndexRune(s, '=')
+			os.Unsetenv(s[:i])
+		}
 	}
+	os.Mkdir(tmp+"/.config", 0777)
+	os.Mkdir(tmp+"/.config/arvados", 0777)
+
+	// Use $HOME/.config/arvados/settings.conf if no env vars are
+	// set
+	os.WriteFile(tmp+"/.config/arvados/settings.conf", []byte(`
+		ARVADOS_API_HOST = localhost:1
+		ARVADOS_API_TOKEN = token_from_settings_file1
+	`), 0777)
+	client := NewClientFromEnv()
+	c.Check(client.AuthToken, check.Equals, "token_from_settings_file1")
+	c.Check(client.APIHost, check.Equals, "localhost:1")
+	c.Check(client.Insecure, check.Equals, false)
+
+	// ..._INSECURE=true, comments, ignored lines in settings.conf
+	os.WriteFile(tmp+"/.config/arvados/settings.conf", []byte(`
+		(ignored) = (ignored)
+		#ARVADOS_API_HOST = localhost:2
+		ARVADOS_API_TOKEN = token_from_settings_file2
+		ARVADOS_API_HOST_INSECURE = true
+	`), 0777)
+	client = NewClientFromEnv()
+	c.Check(client.AuthToken, check.Equals, "token_from_settings_file2")
+	c.Check(client.APIHost, check.Equals, "")
+	c.Check(client.Insecure, check.Equals, true)
+
+	// Environment variables override settings.conf
+	os.Setenv("ARVADOS_API_HOST", "[::]:3")
+	os.Setenv("ARVADOS_API_HOST_INSECURE", "0")
+	client = NewClientFromEnv()
+	c.Check(client.AuthToken, check.Equals, "token_from_settings_file2")
+	c.Check(client.APIHost, check.Equals, "[::]:3")
+	c.Check(client.Insecure, check.Equals, false)
 }