X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/07782f1743267638c996cb1d9bb3a85f24c8243e..58b12d248ed05f8b75b16cee33b0e153e7be71f6:/sdk/cwl/arvados_cwl/executor.py diff --git a/sdk/cwl/arvados_cwl/executor.py b/sdk/cwl/arvados_cwl/executor.py index ffbc6a439f..c358426166 100644 --- a/sdk/cwl/arvados_cwl/executor.py +++ b/sdk/cwl/arvados_cwl/executor.py @@ -5,7 +5,8 @@ from __future__ import division from builtins import next from builtins import object -from past.utils import old_div +from builtins import str +from future.utils import viewvalues import argparse import logging @@ -58,6 +59,7 @@ class RuntimeStatusLoggingHandler(logging.Handler): def __init__(self, runtime_status_update_func): super(RuntimeStatusLoggingHandler, self).__init__() self.runtime_status_update = runtime_status_update_func + self.updatingRuntimeStatus = False def emit(self, record): kind = None @@ -65,22 +67,27 @@ class RuntimeStatusLoggingHandler(logging.Handler): kind = 'error' elif record.levelno >= logging.WARNING: kind = 'warning' - if kind is not None: - log_msg = record.getMessage() - if '\n' in log_msg: - # If the logged message is multi-line, use its first line as status - # and the rest as detail. - status, detail = log_msg.split('\n', 1) - self.runtime_status_update( - kind, - "%s: %s" % (record.name, status), - detail - ) - else: - self.runtime_status_update( - kind, - "%s: %s" % (record.name, record.getMessage()) - ) + if kind is not None and self.updatingRuntimeStatus is not True: + self.updatingRuntimeStatus = True + try: + log_msg = record.getMessage() + if '\n' in log_msg: + # If the logged message is multi-line, use its first line as status + # and the rest as detail. + status, detail = log_msg.split('\n', 1) + self.runtime_status_update( + kind, + "%s: %s" % (record.name, status), + detail + ) + else: + self.runtime_status_update( + kind, + "%s: %s" % (record.name, record.getMessage()) + ) + finally: + self.updatingRuntimeStatus = False + class ArvCwlExecutor(object): """Execute a CWL tool or workflow, submit work (using either jobs or @@ -162,7 +169,7 @@ class ArvCwlExecutor(object): raise Exception("Unsupported API '%s', expected one of %s" % (arvargs.work_api, expected_api)) if self.work_api == "jobs": - logger.warn(""" + logger.warning(""" ******************************* Using the deprecated 'jobs' API. @@ -185,6 +192,11 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods # if running inside a container if arvados_cwl.util.get_current_container(self.api, self.num_retries, logger): root_logger = logging.getLogger('') + + # Remove existing RuntimeStatusLoggingHandlers if they exist + handlers = [h for h in root_logger.handlers if not isinstance(h, RuntimeStatusLoggingHandler)] + root_logger.handlers = handlers + handler = RuntimeStatusLoggingHandler(self.runtime_status_update) root_logger.addHandler(handler) @@ -337,7 +349,7 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods if self.stop_polling.is_set(): break with self.workflow_eval_lock: - keys = list(self.processes.keys()) + keys = list(self.processes) if not keys: remain_wait = self.poll_interval continue @@ -355,8 +367,8 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods keys = keys[pageSize:] try: proc_states = table.list(filters=[["uuid", "in", page]]).execute(num_retries=self.num_retries) - except Exception as e: - logger.warn("Error checking states on API server: %s", e) + except Exception: + logger.exception("Error checking states on API server: %s") remain_wait = self.poll_interval continue @@ -387,9 +399,9 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods for i in self.intermediate_output_collections: try: self.api.collections().delete(uuid=i).execute(num_retries=self.num_retries) - except: - logger.warn("Failed to delete intermediate output: %s", sys.exc_info()[1], exc_info=(sys.exc_info()[1] if self.debug else False)) - if sys.exc_info()[0] is KeyboardInterrupt or sys.exc_info()[0] is SystemExit: + except Exception: + logger.warning("Failed to delete intermediate output: %s", sys.exc_info()[1], exc_info=(sys.exc_info()[1] if self.debug else False)) + except (KeyboardInterrupt, SystemExit): break def check_features(self, obj): @@ -406,7 +418,7 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods "Option 'dockerOutputDirectory' must be an absolute path.") if obj.get("class") == "http://commonwl.org/cwltool#Secrets" and self.work_api != "containers": raise SourceLine(obj, "class", UnsupportedRequirement).makeError("Secrets not supported with --api=jobs") - for v in obj.values(): + for v in viewvalues(obj): self.check_features(v) elif isinstance(obj, list): for i,v in enumerate(obj): @@ -429,7 +441,7 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods keep_client=self.keep_client, num_retries=self.num_retries) - for k,v in list(generatemapper.items()): + for k,v in generatemapper.items(): if k.startswith("_:"): if v.type == "Directory": continue @@ -450,7 +462,7 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods logger.error("Creating CollectionReader for '%s' '%s': %s", k, v, e) raise except IOError as e: - logger.warn("While preparing output collection: %s", e) + logger.warning("While preparing output collection: %s", e) def rewrite(fileobj): fileobj["location"] = generatemapper.mapper(fileobj["location"]).target @@ -462,8 +474,8 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods adjustFileObjs(outputObj, rewrite) with final.open("cwl.output.json", "w") as f: - res = json.dumps(outputObj, sort_keys=True, indent=4, separators=(',',': '), ensure_ascii=False).encode('utf-8').decode() - f.write(res) + res = str(json.dumps(outputObj, sort_keys=True, indent=4, separators=(',',': '), ensure_ascii=False)) + f.write(res) final.save_new(name=name, owner_uuid=self.project_uuid, storage_classes=storage_classes, ensure_unique_name=True) @@ -500,8 +512,9 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods body={ 'is_trashed': True }).execute(num_retries=self.num_retries) - except Exception as e: - logger.info("Setting container output: %s", e) + except Exception: + logger.exception("Setting container output") + return elif self.work_api == "jobs" and "TASK_UUID" in os.environ: self.api.job_tasks().update(uuid=os.environ["TASK_UUID"], body={ @@ -614,7 +627,7 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods visited.add(m.group(1)) estimated_size[0] += int(m.group(2)) visit_class(job_order, ("File", "Directory"), estimate_collection_cache) - runtimeContext.collection_cache_size = max((old_div((estimated_size[0]*192), (1024*1024)))+1, 256) + runtimeContext.collection_cache_size = max(((estimated_size[0]*192) // (1024*1024))+1, 256) self.collection_cache.set_cap(runtimeContext.collection_cache_size*1024*1024) logger.info("Using collection cache size %s MiB", runtimeContext.collection_cache_size) @@ -725,8 +738,11 @@ http://doc.arvados.org/install/install-api-server.html#disable_api_methods except: if sys.exc_info()[0] is KeyboardInterrupt or sys.exc_info()[0] is SystemExit: logger.error("Interrupted, workflow will be cancelled") + elif isinstance(sys.exc_info()[1], WorkflowException): + logger.error("Workflow execution failed:\n%s", sys.exc_info()[1], exc_info=(sys.exc_info()[1] if self.debug else False)) else: - logger.error("Execution failed:\n%s", sys.exc_info()[1], exc_info=(sys.exc_info()[1] if self.debug else False)) + logger.exception("Workflow execution failed") + if self.pipeline: self.api.pipeline_instances().update(uuid=self.pipeline["uuid"], body={"state": "Failed"}).execute(num_retries=self.num_retries)