*Textile description for A project* - "take me home":/
And a new paragraph in description.
') find('.editable-submit').click end wait_for_ajax end + + # visit project page visit current_path + assert(has_no_text?('.container-fluid', text: '*Textile description for A project*'), + "Description is not rendered properly") assert(find?('.container-fluid', text: 'Textile description for A project'), "Description update did not survive page refresh") - assert(!find?('.container-fluid', text: '*Textile description for A project*'), - "Textile description is displayed with uninterpreted formatting characters") + assert(find?('.container-fluid', text: 'And a new paragraph in description'), + "Description did not contain the expected new paragraph") assert(page.has_link?("take me home"), "link not found in description") + click_link 'take me home' - assert page.has_text?('My projects') - assert page.has_text?('Projects shared with me') + + # now in dashboard + assert(page.has_text?('Active pipelines'), 'Active pipelines - not found on dashboard') end test 'Find a project and edit description to html description' do visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: 'A Project'). - click + find("#projects-menu").click + find(".dropdown-menu a", text: "A Project").click within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do find('span', text: api_fixture('groups')['aproject']['name']).click within('.arv-description-as-subtitle') do @@ -69,14 +82,13 @@ class ProjectsTest < ActionDispatch::IntegrationTest "Textile description is displayed with uninterpreted formatting characters") assert(page.has_link?("take me home"),"link not found in description") click_link 'take me home' - assert page.has_text?('My projects') - assert page.has_text?('Projects shared with me') + assert page.has_text?('Active pipelines') end test 'Find a project and edit description to textile description with link to object' do visit page_with_token 'active', '/' - find('.arv-project-list a,button', text: 'A Project'). - click + find("#projects-menu").click + find(".dropdown-menu a", text: "A Project").click within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do find('span', text: api_fixture('groups')['aproject']['name']).click within('.arv-description-as-subtitle') do @@ -126,7 +138,9 @@ class ProjectsTest < ActionDispatch::IntegrationTest test 'Create a project and move it into a different project' do visit page_with_token 'active', '/projects' - find('.btn', text: "Add new project").click + find("#projects-menu").click + find(".dropdown-menu a", text: "Home").click + find('.btn', text: "Add a subproject").click # within('.editable', text: 'New project') do within('h2') do @@ -137,7 +151,9 @@ class ProjectsTest < ActionDispatch::IntegrationTest wait_for_ajax visit '/projects' - find('.btn', text: "Add new project").click + find("#projects-menu").click + find(".dropdown-menu a", text: "Home").click + find('.btn', text: "Add a subproject").click within('h2') do find('.fa-pencil').click find('.editable-input input').set('Project 5678') @@ -166,7 +182,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest find('#project_sharing').all('tr') end - def add_share_and_check(share_type, name) + def add_share_and_check(share_type, name, obj=nil) assert(page.has_no_text?(name), "project is already shared with #{name}") start_share_count = share_rows.size click_on("Share with #{share_type}") @@ -178,6 +194,9 @@ class ProjectsTest < ActionDispatch::IntegrationTest find(".selectable", text: name).click assert(has_no_selector?(".modal-dialog-preview-pane"), "preview pane available in sharing dialog") + if share_type == 'users' and obj and obj['email'] + assert(page.has_text?(obj['email']), "Did not find user's email") + end assert_raises(Capybara::ElementNotFound, "Projects pulldown available from sharing dialog") do click_on "All projects" @@ -224,7 +243,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest show_project_using("active") click_on "Sharing" - add_share_and_check("users", new_name) + add_share_and_check("users", new_name, add_user) modify_share_and_check(new_name) end @@ -248,4 +267,371 @@ class ProjectsTest < ActionDispatch::IntegrationTest assert(page.has_no_selector?(".selectable[data-object-uuid=\"#{bad_uuid}\"]"), "'share with groups' listing includes project") end + + [ + ['Move',api_fixture('collections')['collection_to_move_around_in_aproject'], + api_fixture('groups')['aproject'],api_fixture('groups')['asubproject']], + ['Remove',api_fixture('collections')['collection_to_move_around_in_aproject'], + api_fixture('groups')['aproject']], + ['Copy',api_fixture('collections')['collection_to_move_around_in_aproject'], + api_fixture('groups')['aproject'],api_fixture('groups')['asubproject']], + ['Remove',api_fixture('collections')['collection_in_aproject_with_same_name_as_in_home_project'], + api_fixture('groups')['aproject'],nil,true], + ].each do |action, my_collection, src, dest=nil, expect_name_change=nil| + test "selection #{action} #{expect_name_change} for project" do + perform_selection_action src, dest, my_collection, action + + case action + when 'Copy' + assert page.has_text?(my_collection['name']), 'Collection not found in src project after copy' + visit page_with_token 'active', '/' + find("#projects-menu").click + find(".dropdown-menu a", text: dest['name']).click + assert page.has_text?(my_collection['name']), 'Collection not found in dest project after copy' + + # now remove it from destination project to restore to original state + perform_selection_action dest, nil, my_collection, 'Remove' + when 'Move' + assert page.has_no_text?(my_collection['name']), 'Collection still found in src project after move' + visit page_with_token 'active', '/' + find("#projects-menu").click + find(".dropdown-menu a", text: dest['name']).click + assert page.has_text?(my_collection['name']), 'Collection not found in dest project after move' + + # move it back to src project to restore to original state + perform_selection_action dest, src, my_collection, action + when 'Remove' + assert page.has_no_text?(my_collection['name']), 'Collection still found in src project after remove' + visit page_with_token 'active', '/' + find("#projects-menu").click + find(".dropdown-menu a", text: "Home").click + assert page.has_text?(my_collection['name']), 'Collection not found in home project after remove' + if expect_name_change + assert page.has_text?(my_collection['name']+' removed from ' + src['name']), + 'Collection with update name is not found in home project after remove' + end + end + end + end + + def perform_selection_action src, dest, item, action + visit page_with_token 'active', '/' + find("#projects-menu").click + find(".dropdown-menu a", text: src['name']).click + assert page.has_text?(item['name']), 'Collection not found in src project' + + within('tr', text: item['name']) do + find('input[type=checkbox]').click + end + + click_button 'Selection...' + + within('.selection-action-container') do + assert page.has_text?("Compare selected"), "Compare selected link text not found" + assert page.has_link?("Copy selected"), "Copy selected link not found" + assert page.has_link?("Move selected"), "Move selected link not found" + assert page.has_link?("Remove selected"), "Remove selected link not found" + + click_link "#{action} selected" + end + + # select the destination project if a Copy or Move action is being performed + if action == 'Copy' || action == 'Move' + within(".modal-container") do + find('.selectable', text: dest['name']).click + find('.modal-footer a,button', text: action).click + wait_for_ajax + end + end + end + + # Test copy action state. It should not be available when a subproject is selected. + test "copy action is disabled when a subproject is selected" do + my_project = api_fixture('groups')['aproject'] + my_collection = api_fixture('collections')['collection_to_move_around_in_aproject'] + my_subproject = api_fixture('groups')['asubproject'] + + # verify that selection options are disabled on the project until an item is selected + visit page_with_token 'active', '/' + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click + + click_button 'Selection...' + within('.selection-action-container') do + page.assert_selector 'li.disabled', text: 'Create new collection with selected collections' + page.assert_selector 'li.disabled', text: 'Compare selected' + page.assert_selector 'li.disabled', text: 'Copy selected' + page.assert_selector 'li.disabled', text: 'Move selected' + page.assert_selector 'li.disabled', text: 'Remove selected' + end + + # select collection and verify links are enabled + visit page_with_token 'active', '/' + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click + assert page.has_text?(my_collection['name']), 'Collection not found in project' + + within('tr', text: my_collection['name']) do + find('input[type=checkbox]').click + end + + click_button 'Selection...' + within('.selection-action-container') do + page.assert_no_selector 'li.disabled', text: 'Create new collection with selected collections' + page.assert_selector 'li', text: 'Create new collection with selected collections' + page.assert_selector 'li.disabled', text: 'Compare selected' + page.assert_no_selector 'li.disabled', text: 'Copy selected' + page.assert_selector 'li', text: 'Copy selected' + page.assert_no_selector 'li.disabled', text: 'Move selected' + page.assert_selector 'li', text: 'Move selected' + page.assert_no_selector 'li.disabled', text: 'Remove selected' + page.assert_selector 'li', text: 'Remove selected' + end + + # select subproject and verify that copy action is disabled + visit page_with_token 'active', '/' + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click + + click_link 'Subprojects' + assert page.has_text?(my_subproject['name']), 'Subproject not found in project' + + within('tr', text: my_subproject['name']) do + find('input[type=checkbox]').click + end + + click_button 'Selection...' + within('.selection-action-container') do + page.assert_selector 'li.disabled', text: 'Create new collection with selected collections' + page.assert_selector 'li.disabled', text: 'Compare selected' + page.assert_selector 'li.disabled', text: 'Copy selected' + page.assert_no_selector 'li.disabled', text: 'Move selected' + page.assert_selector 'li', text: 'Move selected' + page.assert_no_selector 'li.disabled', text: 'Remove selected' + page.assert_selector 'li', text: 'Remove selected' + end + + # select subproject and a collection and verify that copy action is still disabled + visit page_with_token 'active', '/' + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click + + click_link 'Subprojects' + assert page.has_text?(my_subproject['name']), 'Subproject not found in project' + + within('tr', text: my_subproject['name']) do + find('input[type=checkbox]').click + end + + click_link 'Data collections' + assert page.has_text?(my_collection['name']), 'Collection not found in project' + + within('tr', text: my_collection['name']) do + find('input[type=checkbox]').click + end + + click_button 'Selection...' + within('.selection-action-container') do + page.assert_selector 'li.disabled', text: 'Create new collection with selected collections' + page.assert_selector 'li.disabled', text: 'Compare selected' + page.assert_selector 'li.disabled', text: 'Copy selected' + page.assert_no_selector 'li.disabled', text: 'Move selected' + page.assert_selector 'li', text: 'Move selected' + page.assert_no_selector 'li.disabled', text: 'Remove selected' + page.assert_selector 'li', text: 'Remove selected' + end + end + + [ + ['active', true], + ['project_viewer', false], + ].each do |user, expect_collection_in_aproject| + test "combine selected collections into new collection #{user} #{expect_collection_in_aproject}" do + my_project = api_fixture('groups')['aproject'] + my_collection = api_fixture('collections')['collection_to_move_around_in_aproject'] + + visit page_with_token user, '/' + find("#projects-menu").click + find(".dropdown-menu a", text: my_project['name']).click + assert page.has_text?(my_collection['name']), 'Collection not found in project' + + within('tr', text: my_collection['name']) do + find('input[type=checkbox]').click + end + + click_button 'Selection...' + within('.selection-action-container') do + click_link 'Create new collection with selected collections' + end + + # now in the new collection page + if expect_collection_in_aproject + assert page.has_text?("Created new collection in the project #{my_project['name']}"), + 'Not found flash message that new collection is created in aproject' + else + assert page.has_text?("Created new collection in your Home project"), + 'Not found flash message that new collection is created in Home project' + end + assert page.has_text?('Content hash'), 'Not found content hash in collection page' + end + end + + [ + ["jobs", "/jobs"], + ["pipelines", "/pipeline_instances"], + ["collections", "/collections"] + ].each do |target,path| + test "Test dashboard button all #{target}" do + visit page_with_token 'active', '/' + click_link "All #{target}" + assert_equal path, current_path + end + end + + def scroll_setup(project_name, + total_nbr_items, + item_list_parameter, + sorted = false, + sort_parameters = nil) + headless = Headless.new + headless.start + Capybara.current_driver = :selenium + + project_uuid = api_fixture('groups')[project_name]['uuid'] + visit page_with_token 'user1_with_load', '/projects/' + project_uuid + + assert(page.has_text?("#{item_list_parameter.humanize} (#{total_nbr_items})"), "Number of #{item_list_parameter.humanize} did not match the input amount") + + click_link item_list_parameter.humanize + wait_for_ajax + + if sorted + find("th[data-sort-order='#{sort_parameters.gsub(/\s/,'')}']").click + wait_for_ajax + end + end + + def scroll_items_check(nbr_items, + fixture_prefix, + item_list_parameter, + item_selector, + sorted = false) + items = [] + for i in 1..nbr_items + items << "#{fixture_prefix}#{i}" + end + + verify_items = items.dup + unexpected_items = [] + item_count = 0 + within(".arv-project-#{item_list_parameter}") do + page.execute_script "window.scrollBy(0,999000)" + begin + wait_for_ajax + rescue + end + + # Visit all rows. If not all expected items are found, retry + found_items = page.all(item_selector) + item_count = found_items.count + + previous = nil + (0..item_count-1).each do |i| + # Found row text using the fixture string e.g. "Show Collection_#{n} " + item_name = found_items[i].text.split[1] + if !items.include? item_name + unexpected_items << item_name + else + verify_items.delete item_name + end + if sorted + # check sort order + assert_operator( previous.downcase, :<=, item_name.downcase) if previous + previous = item_name + end + end + + assert_equal true, unexpected_items.empty?, "Found unexpected #{item_list_parameter.humanize} #{unexpected_items.inspect}" + assert_equal nbr_items, item_count, "Found different number of #{item_list_parameter.humanize}" + assert_equal true, verify_items.empty?, "Did not find all the #{item_list_parameter.humanize}" + end + end + + [ + ['project_with_10_collections', 10], + ['project_with_201_collections', 201], # two pages of data + ].each do |project_name, nbr_items| + test "scroll collections tab for #{project_name} with #{nbr_items} objects" do + item_list_parameter = "Data_collections" + scroll_setup project_name, + nbr_items, + item_list_parameter + scroll_items_check nbr_items, + "Collection_", + item_list_parameter, + 'tr[data-kind="arvados#collection"]' + end + end + + [ + ['project_with_10_collections', 10], + ['project_with_201_collections', 201], # two pages of data + ].each do |project_name, nbr_items| + test "scroll collections tab for #{project_name} with #{nbr_items} objects with ascending sort (case insensitive)" do + item_list_parameter = "Data_collections" + scroll_setup project_name, + nbr_items, + item_list_parameter, + true, + "collections.name" + scroll_items_check nbr_items, + "Collection_", + item_list_parameter, + 'tr[data-kind="arvados#collection"]', + true + end + end + + [ + ['project_with_10_pipelines', 10, 0], + ['project_with_2_pipelines_and_60_jobs', 2, 60], + ['project_with_25_pipelines', 25, 0], + ].each do |project_name, num_pipelines, num_jobs| + test "scroll pipeline instances tab for #{project_name} with #{num_pipelines} pipelines and #{num_jobs} jobs" do + item_list_parameter = "Jobs_and_pipelines" + scroll_setup project_name, + num_pipelines + num_jobs, + item_list_parameter + # check the general scrolling and the pipelines + scroll_items_check num_pipelines, + "pipeline_", + item_list_parameter, + 'tr[data-kind="arvados#pipelineInstance"]' + # Check job count separately + jobs_found = page.all('tr[data-kind="arvados#job"]') + found_job_count = jobs_found.count + assert_equal num_jobs, found_job_count, 'Did not find expected number of jobs' + end + end + + # Move button accessibility + [ + ['admin', true], + ['active', true], # project owner + ['project_viewer', false], + ].each do |user, can_move| + test "#{user} can move subproject under another user's Home #{can_move}" do + project = api_fixture('groups')['aproject'] + collection = api_fixture('collections')['collection_to_move_around_in_aproject'] + + # verify the project move button + visit page_with_token user, "/projects/#{project['uuid']}" + if can_move + assert page.has_link? 'Move project...' + else + assert page.has_no_link? 'Move project...' + end + end + end + end