projects
/
arvados.git
/ blobdiff
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Merge branch '15028-cwl-v1.1' refs #15028
[arvados.git]
/
services
/
keepstore
/
s3_volume_test.go
diff --git
a/services/keepstore/s3_volume_test.go
b/services/keepstore/s3_volume_test.go
index 10c71125df39acb3feadc4e69e4d2190d53a10fe..6377420ff4b381cba49b07d2813fb4803f03aa62 100644
(file)
--- a/
services/keepstore/s3_volume_test.go
+++ b/
services/keepstore/s3_volume_test.go
@@
-20,6
+20,7
@@
import (
"github.com/AdRoll/goamz/s3"
"github.com/AdRoll/goamz/s3/s3test"
"github.com/ghodss/yaml"
"github.com/AdRoll/goamz/s3"
"github.com/AdRoll/goamz/s3/s3test"
"github.com/ghodss/yaml"
+ "github.com/prometheus/client_golang/prometheus"
check "gopkg.in/check.v1"
)
check "gopkg.in/check.v1"
)
@@
-170,7
+171,8
@@
func (s *StubbedS3Suite) testContextCancel(c *check.C, testFunc func(context.Con
vol := *v.S3Volume
vol.Endpoint = srv.URL
v = &TestableS3Volume{S3Volume: &vol}
vol := *v.S3Volume
vol.Endpoint = srv.URL
v = &TestableS3Volume{S3Volume: &vol}
- v.Start()
+ metrics := newVolumeMetricsVecs(prometheus.NewRegistry())
+ v.Start(metrics)
ctx, cancel := context.WithCancel(context.Background())
ctx, cancel := context.WithCancel(context.Background())
@@
-430,7
+432,8
@@
func (s *StubbedS3Suite) newTestableVolume(c *check.C, raceWindow time.Duration,
server: srv,
serverClock: clock,
}
server: srv,
serverClock: clock,
}
- v.Start()
+ metrics := newVolumeMetricsVecs(prometheus.NewRegistry())
+ v.Start(metrics)
err = v.bucket.PutBucket(s3.ACL("private"))
c.Assert(err, check.IsNil)
return v
err = v.bucket.PutBucket(s3.ACL("private"))
c.Assert(err, check.IsNil)
return v
@@
-448,7
+451,7
@@
Volumes:
c.Check(cfg.Volumes[0].GetStorageClasses(), check.DeepEquals, []string{"class_a", "class_b"})
}
c.Check(cfg.Volumes[0].GetStorageClasses(), check.DeepEquals, []string{"class_a", "class_b"})
}
-func (v *TestableS3Volume) Start() error {
+func (v *TestableS3Volume) Start(
vm *volumeMetricsVecs
) error {
tmp, err := ioutil.TempFile("", "keepstore")
v.c.Assert(err, check.IsNil)
defer os.Remove(tmp.Name())
tmp, err := ioutil.TempFile("", "keepstore")
v.c.Assert(err, check.IsNil)
defer os.Remove(tmp.Name())
@@
-459,7
+462,7
@@
func (v *TestableS3Volume) Start() error {
v.S3Volume.AccessKeyFile = tmp.Name()
v.S3Volume.SecretKeyFile = tmp.Name()
v.S3Volume.AccessKeyFile = tmp.Name()
v.S3Volume.SecretKeyFile = tmp.Name()
- v.c.Assert(v.S3Volume.Start(), check.IsNil)
+ v.c.Assert(v.S3Volume.Start(
vm
), check.IsNil)
return nil
}
return nil
}
@@
-490,3
+493,7
@@
func (v *TestableS3Volume) TouchWithDate(locator string, lastPut time.Time) {
func (v *TestableS3Volume) Teardown() {
v.server.Quit()
}
func (v *TestableS3Volume) Teardown() {
v.server.Quit()
}
+
+func (v *TestableS3Volume) ReadWriteOperationLabelValues() (r, w string) {
+ return "get", "put"
+}