- # disallow starting with '-' so verision strings can't be interpreted as command line options
- valid_pattern = /[A-Za-z0-9_][A-Za-z0-9_-]/
- if (minimum and !minimum.match valid_pattern) || !maximum.match valid_pattern
- logger.warn "find_commit_range called with string containing invalid characters: '#{minimum}', '#{maximum}'"
+ if minimum and minimum.empty?
+ minimum = nil
+ end
+
+ if minimum and !git_check_ref_format(minimum)
+ logger.warn "find_commit_range called with invalid minimum revision: '#{minimum}'"