4088: code review feedback

[arvados.git] / apps / workbench / app / views / collections / _show_files.html.erb

diff --git a/apps/workbench/app/views/collections/_show_files.html.erb b/apps/workbench/app/views/collections/_show_files.html.erb
index 9b39b61d44240e44a81ef913487cd30ed768c4d7..5b6dac81ed72846e510d1515051ca7e3e287dc74 100644 (file)
--- a/apps/workbench/app/views/collections/_show_files.html.erb
+++ b/apps/workbench/app/views/collections/_show_files.html.erb
@@ -1,3 +1,24 @@
+<script>
+// The "each" loop in select_all_files() and unselect_all_files()
+// is needed because .trigger("change") does not play well with clippy.
+// Once clippy has been retired, we should be able to compress this
+// into .filter(":visible").prop("checked", true).trigger("change").
+//
+function select_all_files() {
+  $("#collection_files :checkbox").filter(":visible").each(
+    function() {
+      $(this).prop("checked", true).trigger("change");
+    });
+}
+
+function unselect_all_files() {
+  $("#collection_files :checkbox").filter(":visible").each(
+    function() {
+      $(this).prop("checked", false).trigger("change");
+    });
+}
+</script>
+
 <div class="selection-action-container" style="padding-left: 1em">
   <% if !defined? no_checkboxes or !no_checkboxes %>
   <div class="row">
@@ -16,30 +37,18 @@
             %></li>
         </ul>
       </div>
+      <div class="btn-group btn-group-sm">
+       <button id="select-all" type="button" class="btn btn-default" onClick="select_all_files()">Select all</button>
+       <button id="unselect-all" type="button" class="btn btn-default" onClick="unselect_all_files()">Unselect all</button>
+      </div>
     </div>
     <div class="pull-right">
-      <%= form_tag collection_path(@object.uuid), {method: 'get'} do %>
-        <input class="form-control" id="file_regex" name="file_regex" value="<%= params[:file_regex] %>" type="text"/>
-        <button id="file_regex_submit" type="submit" class="btn btn-primary" autofocus>Filter</button>
-      <% end %>
+      <input class="form-control filterable-control" data-filterable-target="ul#collection_files" id="file_regex" name="file_regex" placeholder="filename regex" type="text"/>
     </div>
   </div>
   <p/>
   <% end %>
 
-<%
-  file_regex = nil
-  if params[:file_regex]
-    begin
-      file_regex = Regexp.new(params[:file_regex])
-    rescue RegexpError
-      # If the pattern is not a valid regex, quote it
-      # (i.e. use it as a simple substring search)
-      file_regex = Regexp.new(Regexp.quote(params[:file_regex]))
-    end
-  end
-%>
-
 <% file_tree = @object.andand.files_tree %>
 <% if file_tree.nil? or file_tree.empty? %>
   <p>This collection is empty.</p>
@@ -59,12 +68,9 @@
       </div>
       <ul class="collection_files">
     <% else %>
-      <% if !file_regex.nil? and !file_regex.match(filename) %>
-        <% next %>
-      <% end %>
       <% link_params = {controller: 'collections', action: 'show_file',
                         uuid: @object.portable_data_hash, file: file_path, size: size} %>
-       <div class="collection_files_row">
+       <div class="collection_files_row filterable">
         <div class="collection_files_buttons pull-right">
           <%= raw(human_readable_bytes_html(size)) %>
           <% disable_search = (Rails.configuration.filename_suffixes_with_view_icon.include? file_path.split('.')[-1]) ? false : true %>