post :create, user: {
first_name: "test_first_name",
last_name: "test_last_name",
- email: "test@abc.com"
+ email: "foo@example.com"
}
assert_response :success
created = JSON.parse(@response.body)
uuid: "this_is_agreeable",
first_name: "in_create_test_first_name",
last_name: "test_last_name",
- email: "test@abc.com"
+ email: "foo@example.com"
}
}
assert_response :success
-
response_items = JSON.parse(@response.body)['items']
- created = response_items['user']
+ created = find_obj_in_resp response_items, 'User', nil
assert_equal 'in_create_test_first_name', created['first_name']
assert_not_nil created['uuid'], 'expected non-null uuid for the new user'
assert_equal 'this_is_agreeable', created['uuid']
assert_not_nil created['email'], 'expected non-nil email'
assert_nil created['identity_url'], 'expected no identity_url'
- # since no such vm exists, expect only three new links:
- # oid_login_perm, repo link and link add user to 'All users' group
+ # arvados#user, repo link and link add user to 'All users' group
verify_num_links @all_links_at_start, 3
- verify_link response_items, 'oid_login_perm', true, 'permission', 'can_login',
+ verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
created['uuid'], created['email'], 'arvados#user', false, 'User'
- verify_link response_items, 'repo_perm', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
repo_name, created['uuid'], 'arvados#repository', true, 'Repository'
- verify_link response_items, 'group_perm', true, 'permission', 'can_read',
+ verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
- verify_link response_items, 'vm_login_perm', false, 'permission', 'can_login',
+ verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+
+ # invoke setup again with the same data
+ post :setup, {
+ repo_name: repo_name,
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'https://www.google.com/accounts/o8/id',
+ user: {
+ uuid: "this_is_agreeable",
+ first_name: "in_create_test_first_name",
+ last_name: "test_last_name",
+ email: "foo@example.com"
+ }
+ }
+
+ response_items = JSON.parse(@response.body)['items']
+
+ created = find_obj_in_resp response_items, 'User', nil
+ assert_equal 'in_create_test_first_name', created['first_name']
+ assert_not_nil created['uuid'], 'expected non-null uuid for the new user'
+ assert_equal 'this_is_agreeable', created['uuid']
+ assert_not_nil created['email'], 'expected non-nil email'
+ assert_nil created['identity_url'], 'expected no identity_url'
+
+ # arvados#user, repo link and link add user to 'All users' group
+ verify_num_links @all_links_at_start, 4
+
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ repo_name, created['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
+ 'All users', created['uuid'], 'arvados#group', true, 'Group'
+
+ verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
+ @vm_uuid, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+ end
+
+ test "setup user with bogus uuid and expect error" do
+ authorize_with :admin
+
+ post :setup, {
+ uuid: 'bogus_uuid',
+ repo_name: 'test_repo',
+ vm_uuid: @vm_uuid
+ }
+ response_body = JSON.parse(@response.body)
+ response_errors = response_body['errors']
+ assert_not_nil response_errors, 'Expected error in response'
+ assert (response_errors.first.include? 'Path not found'), 'Expected 404'
end
- test "create user with bogus uuid, vm and repo as input" do
+ test "setup user with bogus uuid in user and expect error" do
authorize_with :admin
post :setup, {
- uuid: 'not_an_existing_uuid_and_not_email_format',
+ user: {uuid: 'bogus_uuid'},
repo_name: 'test_repo',
vm_uuid: @vm_uuid,
openid_prefix: 'https://www.google.com/accounts/o8/id'
response_body = JSON.parse(@response.body)
response_errors = response_body['errors']
assert_not_nil response_errors, 'Expected error in response'
- assert (response_errors.first.include? 'Path not found'), 'Expected 404'
+ assert (response_errors.first.include? 'ArgumentError: Require user email'),
+ 'Expected RuntimeError'
+ end
+
+ test "setup user with no uuid and user, expect error" do
+ authorize_with :admin
+
+ post :setup, {
+ repo_name: 'test_repo',
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+ response_body = JSON.parse(@response.body)
+ response_errors = response_body['errors']
+ assert_not_nil response_errors, 'Expected error in response'
+ assert (response_errors.first.include? 'Required uuid or user'),
+ 'Expected ArgumentError'
+ end
+
+ test "setup user with no uuid and email, expect error" do
+ authorize_with :admin
+
+ post :setup, {
+ user: {},
+ repo_name: 'test_repo',
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+ response_body = JSON.parse(@response.body)
+ response_errors = response_body['errors']
+ assert_not_nil response_errors, 'Expected error in response'
+ assert (response_errors.first.include? '<ArgumentError: Require user email'),
+ 'Expected ArgumentError'
end
test "invoke setup with existing uuid, vm and repo and verify links" do
authorize_with :admin
post :setup, {
- user: {uuid: inactive_user['uuid']},
+ uuid: inactive_user['uuid'],
repo_name: 'test_repo',
- vm_uuid: @vm_uuid,
- openid_prefix: 'https://www.google.com/accounts/o8/id'
+ vm_uuid: @vm_uuid
}
assert_response :success
response_items = JSON.parse(@response.body)['items']
- resp_obj = response_items['user']
+ resp_obj = find_obj_in_resp response_items, 'User', nil
assert_not_nil resp_obj['uuid'], 'expected uuid for the new user'
assert_equal inactive_user['uuid'], resp_obj['uuid']
'expecting inactive user email'
# expect repo and vm links
- verify_link response_items, 'repo_perm', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
'test_repo', resp_obj['uuid'], 'arvados#repository', true, 'Repository'
- verify_link response_items, 'vm_login_perm', true, 'permission', 'can_login',
+ verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
@vm_uuid, resp_obj['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
end
- test "create user with valid email and repo as input" do
+ test "invoke setup with existing uuid in user, verify response" do
+ authorize_with :inactive
+ get :current
+ assert_response :success
+ inactive_user = JSON.parse(@response.body)
+
+ authorize_with :admin
+
+ post :setup, {
+ user: {uuid: inactive_user['uuid']},
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ resp_obj = find_obj_in_resp response_items, 'User', nil
+
+ assert_not_nil resp_obj['uuid'], 'expected uuid for the new user'
+ assert_equal inactive_user['uuid'], resp_obj['uuid']
+ assert_equal inactive_user['email'], resp_obj['email'],
+ 'expecting inactive user email'
+ end
+
+ test "invoke setup with existing uuid but different email, expect original email" do
+ authorize_with :inactive
+ get :current
+ assert_response :success
+ inactive_user = JSON.parse(@response.body)
+
+ authorize_with :admin
+
+ post :setup, {
+ uuid: inactive_user['uuid'],
+ user: {email: 'junk_email'}
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ resp_obj = find_obj_in_resp response_items, 'User', nil
+
+ assert_not_nil resp_obj['uuid'], 'expected uuid for the new user'
+ assert_equal inactive_user['uuid'], resp_obj['uuid']
+ assert_equal inactive_user['email'], resp_obj['email'],
+ 'expecting inactive user email'
+ end
+
+ test "setup user with valid email and repo as input" do
authorize_with :admin
post :setup, {
repo_name: 'test_repo',
- user: {email: 'abc@xyz.com'},
+ user: {email: 'foo@example.com'},
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
assert_response :success
- response_object = JSON.parse(@response.body)['items']['user']
+ response_items = JSON.parse(@response.body)['items']
+ response_object = find_obj_in_resp response_items, 'User', nil
assert_not_nil response_object['uuid'], 'expected uuid for the new user'
- assert_equal response_object['email'], 'abc@xyz.com', 'expected given email'
+ assert_equal response_object['email'], 'foo@example.com', 'expected given email'
# three extra links; login link, group link and repo link
verify_num_links @all_links_at_start, 3
end
- test "create user with valid email, repo and fake vm as input" do
+ test "setup user with fake vm and expect error" do
authorize_with :admin
post :setup, {
repo_name: 'test_repo',
vm_uuid: 'no_such_vm',
- user: {email: 'abc@xyz.com'},
+ user: {email: 'foo@example.com'},
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
'Expected RuntimeError: No vm found for no_such_vm'
end
- test "create user with valid email, repo and real vm as input" do
+ test "setup user with valid email, repo and real vm as input" do
authorize_with :admin
post :setup, {
repo_name: 'test_repo',
openid_prefix: 'https://www.google.com/accounts/o8/id',
vm_uuid: @vm_uuid,
- user: {email: 'abc@xyz.com'}
+ user: {email: 'foo@example.com'}
}
assert_response :success
- response_object = JSON.parse(@response.body)['items']['user']
+ response_items = JSON.parse(@response.body)['items']
+ response_object = find_obj_in_resp response_items, 'User', nil
assert_not_nil response_object['uuid'], 'expected uuid for the new user'
- assert_equal response_object['email'], 'abc@xyz.com', 'expected given email'
+ assert_equal response_object['email'], 'foo@example.com', 'expected given email'
# three extra links; login link, group link and repo link
verify_num_links @all_links_at_start, 4
end
- test "create user with valid email, no vm and repo as input" do
+ test "setup user with valid email, no vm and repo as input" do
authorize_with :admin
post :setup, {
- user: {email: 'abc@xyz.com'},
+ user: {email: 'foo@example.com'},
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
assert_response :success
- response_object = JSON.parse(@response.body)['items']['user']
+ response_items = JSON.parse(@response.body)['items']
+ response_object = find_obj_in_resp response_items, 'User', nil
assert_not_nil response_object['uuid'], 'expected uuid for new user'
- assert_equal response_object['email'], 'abc@xyz.com', 'expected given email'
+ assert_equal response_object['email'], 'foo@example.com', 'expected given email'
# two extra links; login link and group link
verify_num_links @all_links_at_start, 2
end
- test "create user with email, first name, repo name and vm uuid" do
+ test "setup user with email, first name, repo name and vm uuid" do
authorize_with :admin
post :setup, {
vm_uuid: @vm_uuid,
user: {
first_name: 'test_first_name',
- email: 'abc@xyz.com'
+ email: 'foo@example.com'
}
}
assert_response :success
- response_object = JSON.parse(@response.body)['items']['user']
+ response_items = JSON.parse(@response.body)['items']
+ response_object = find_obj_in_resp response_items, 'User', nil
assert_not_nil response_object['uuid'], 'expected uuid for new user'
- assert_equal response_object['email'], 'abc@xyz.com', 'expected given email'
+ assert_equal response_object['email'], 'foo@example.com', 'expected given email'
assert_equal 'test_first_name', response_object['first_name'],
'expecting first name'
verify_num_links @all_links_at_start, 4
end
- test "create user twice with email and check two different objects created" do
+ test "setup user twice with email and check two different objects created" do
authorize_with :admin
post :setup, {
openid_prefix: 'https://www.google.com/accounts/o8/id',
repo_name: 'test_repo',
user: {
- email: 'abc@xyz.com'
+ email: 'foo@example.com'
}
}
assert_response :success
- response_object = JSON.parse(@response.body)['items']['user']
+ response_items = JSON.parse(@response.body)['items']
+ response_object = find_obj_in_resp response_items, 'User', nil
assert_not_nil response_object['uuid'], 'expected uuid for new user'
- assert_equal response_object['email'], 'abc@xyz.com', 'expected given email'
+ assert_equal response_object['email'], 'foo@example.com', 'expected given email'
verify_num_links @all_links_at_start, 3 # openid, group, and repo. no vm
# create again
post :setup, {
- user: {email: 'abc@xyz.com'},
+ user: {email: 'foo@example.com'},
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
assert_response :success
- response_object2 = JSON.parse(@response.body)['items']['user']
+ response_items = JSON.parse(@response.body)['items']
+ response_object2 = find_obj_in_resp response_items, 'User', nil
assert_not_equal response_object['uuid'], response_object2['uuid'],
'expected same uuid as first create operation'
- assert_equal response_object['email'], 'abc@xyz.com', 'expected given email'
+ assert_equal response_object['email'], 'foo@example.com', 'expected given email'
# extra login link only
verify_num_links @all_links_at_start, 4
end
- test "create user with openid prefix" do
+ test "setup user with openid prefix" do
authorize_with :admin
post :setup, {
repo_name: 'test_repo',
- openid_prefix: 'http://www.xyz.com/account',
+ openid_prefix: 'http://www.example.com/account',
user: {
first_name: "in_create_test_first_name",
last_name: "test_last_name",
- email: "test@abc.com"
+ email: "foo@example.com"
}
}
assert_response :success
response_items = JSON.parse(@response.body)['items']
- created = response_items['user']
+ created = find_obj_in_resp response_items, 'User', nil
assert_equal 'in_create_test_first_name', created['first_name']
assert_not_nil created['uuid'], 'expected uuid for new user'
assert_nil created['identity_url'], 'expected no identity_url'
# verify links
- # 3 new links: oid_login_perm, repo, and 'All users' group.
+ # 3 new links: arvados#user, repo, and 'All users' group.
verify_num_links @all_links_at_start, 3
- verify_link response_items, 'oid_login_perm', true, 'permission', 'can_login',
+ verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
created['uuid'], created['email'], 'arvados#user', false, 'User'
- verify_link response_items, 'repo_perm', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
- verify_link response_items, 'group_perm', true, 'permission', 'can_read',
+ verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
- verify_link response_items, 'vm_login_perm', false, 'permission', 'can_login',
+ verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
end
user: {
first_name: "in_create_test_first_name",
last_name: "test_last_name",
- email: "test@abc.com"
+ email: "foo@example.com"
}
}
'Expected ArgumentError'
end
- test "create user with user, vm and repo and verify links" do
+ test "setup user with user, vm and repo and verify links" do
authorize_with :admin
post :setup, {
user: {
first_name: "in_create_test_first_name",
last_name: "test_last_name",
- email: "test@abc.com"
+ email: "foo@example.com"
},
vm_uuid: @vm_uuid,
repo_name: 'test_repo',
assert_response :success
response_items = JSON.parse(@response.body)['items']
- created = response_items['user']
+ created = find_obj_in_resp response_items, 'User', nil
assert_equal 'in_create_test_first_name', created['first_name']
assert_not_nil created['uuid'], 'expected uuid for new user'
assert_not_nil created['email'], 'expected non-nil email'
assert_nil created['identity_url'], 'expected no identity_url'
- # expect 4 new links: oid_login_perm, repo, vm and 'All users' group link
+ # expect 4 new links: arvados#user, repo, vm and 'All users' group link
verify_num_links @all_links_at_start, 4
- verify_link response_items, 'oid_login_perm', true, 'permission', 'can_login',
+ verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
created['uuid'], created['email'], 'arvados#user', false, 'User'
- verify_link response_items, 'repo_perm', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
- verify_link response_items, 'group_perm', true, 'permission', 'can_read',
+ verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
- verify_link response_items, 'vm_login_perm', true, 'permission', 'can_login',
+ verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
@vm_uuid, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
end
- test "try to create user as non admin user" do
+ test "create user as non admin user and expect error" do
authorize_with :active
post :create, {
- user: {email: 'abc@xyz.com'}
+ user: {email: 'foo@example.com'}
}
response_body = JSON.parse(@response.body)
'Expected PermissionDeniedError'
end
- test "try to setup user as non admin user" do
+ test "setup user as non admin user and expect error" do
authorize_with :active
post :setup, {
openid_prefix: 'https://www.google.com/accounts/o8/id',
- user: {email: 'abc@xyz.com'}
+ user: {email: 'foo@example.com'}
}
response_body = JSON.parse(@response.body)
'Expected PermissionDeniedError'
end
+ test "setup user in multiple steps and verify response" do
+ authorize_with :admin
+
+ post :setup, {
+ openid_prefix: 'http://www.example.com/account',
+ user: {
+ email: "foo@example.com"
+ }
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ created = find_obj_in_resp response_items, 'User', nil
+
+ assert_not_nil created['uuid'], 'expected uuid for new user'
+ assert_not_nil created['email'], 'expected non-nil email'
+ assert_equal created['email'], 'foo@example.com', 'expected input email'
+
+ # verify links; 2 new links: arvados#user, and 'All users' group.
+ verify_num_links @all_links_at_start, 2
+
+ verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
+ created['uuid'], created['email'], 'arvados#user', false, 'User'
+
+ verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
+ 'All users', created['uuid'], 'arvados#group', true, 'Group'
+
+ verify_link response_items, 'arvados#repository', false, 'permission', 'can_write',
+ 'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
+ nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+
+ # invoke setup with a repository
+ post :setup, {
+ openid_prefix: 'http://www.example.com/account',
+ repo_name: 'new_repo',
+ uuid: created['uuid']
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ created = find_obj_in_resp response_items, 'User', nil
+
+ assert_equal 'foo@example.com', created['email'], 'expected input email'
+
+ # verify links
+ verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
+ 'All users', created['uuid'], 'arvados#group', true, 'Group'
+
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ 'new_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
+ nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+
+ # invoke setup with a vm_uuid
+ post :setup, {
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'http://www.example.com/account',
+ user: {
+ email: 'junk_email'
+ },
+ uuid: created['uuid']
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ created = find_obj_in_resp response_items, 'User', nil
+
+ assert_equal created['email'], 'foo@example.com', 'expected original email'
+
+ # verify links
+ verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
+ 'All users', created['uuid'], 'arvados#group', true, 'Group'
+
+ # since no repo name in input, we won't get any; even though user has one
+ verify_link response_items, 'arvados#repository', false, 'permission', 'can_write',
+ 'new_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
+ @vm_uuid, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+ end
+
def verify_num_links (original_links, expected_additional_links)
links_now = Link.all
assert_equal original_links.size+expected_additional_links, Link.all.size,
"Expected #{expected_additional_links.inspect} more links"
end
+ def find_obj_in_resp (response_items, object_type, head_kind=nil)
+ return_obj = nil
+ response_items.each { |x|
+ if !x
+ next
+ end
+
+ if object_type == 'User'
+ if !x['head_kind']
+ return_obj = x
+ break
+ end
+ else # looking for a link
+ if x['head_kind'] == head_kind
+ return_obj = x
+ break
+ end
+ end
+ }
+ return return_obj
+ end
+
def verify_link(response_items, link_object_name, expect_link, link_class,
link_name, head_uuid, tail_uuid, head_kind, fetch_object, class_name)
- link = response_items[link_object_name]
+
+ link = find_obj_in_resp response_items, 'Link', link_object_name
if !expect_link
- assert_nil link
+ assert_nil link, "Expected no link for #{link_object_name}"
return
end
- assert_not_nil link
+ assert_not_nil link, "Expected link for #{link_object_name}"
if fetch_object
object = Object.const_get(class_name).where(name: head_uuid)
assert [] != object, "expected #{class_name} with name #{head_uuid}"
head_uuid = object.first[:uuid]
end
-
assert_equal link['link_class'], link_class,
"did not find expected link_class for #{link_object_name}"
projects / arvados.git / blobdiff