19249: Mime-encode metadata headers that have control chars.

[arvados.git] / services / keep-web / s3.go

diff --git a/services/keep-web/s3.go b/services/keep-web/s3.go
index 90b75f8a306019c2b646d15228da0c1c54a62956..1f458f8e59ad2e2fa9139d4e388fe8554f70a420 100644 (file)
--- a/services/keep-web/s3.go
+++ b/services/keep-web/s3.go
@@ -607,7 +607,7 @@ func (h *handler) serveS3(w http.ResponseWriter, r *http.Request) bool {
 func setFileInfoHeaders(header http.Header, fs arvados.CustomFileSystem, path string) error {
        maybeEncode := func(s string) string {
                for _, c := range s {
-                       if c > '\u007f' {
+                       if c > '\u007f' || c < ' ' {
                                return mime.BEncoding.Encode("UTF-8", s)
                        }
                }