clean code

[arvados.git] / src / views-components / search-bar / search-bar-view.tsx

diff --git a/src/views-components/search-bar/search-bar-view.tsx b/src/views-components/search-bar/search-bar-view.tsx
index 385c4fa2573453f0a146b0a1cd51d1cbd0754eb2..f26cb7e6909139f613923e3858b97ff9c9c4fbff 100644 (file)
--- a/src/views-components/search-bar/search-bar-view.tsx
+++ b/src/views-components/search-bar/search-bar-view.tsx
@@ -19,11 +19,12 @@ import { RemoveIcon } from '~/components/icon/icon';
 import { SearchView } from '~/store/search-bar/search-bar-reducer';
 import { SearchBarBasicView } from '~/views-components/search-bar/search-bar-basic-view';
 import { SearchBarAdvancedView } from '~/views-components/search-bar/search-bar-advanced-view';
-import { SearchBarAutocompleteView } from '~/views-components/search-bar/search-bar-autocomplete-view';
+import { SearchBarAutocompleteView, SearchBarAutocompleteViewDataProps } from '~/views-components/search-bar/search-bar-autocomplete-view';
+import { ArvadosTheme } from '~/common/custom-theme';
 
 type CssRules = 'container' | 'input' | 'searchBar';
 
-const styles: StyleRulesCallback<CssRules> = theme => {
+const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => {
     return {
         container: {
             position: 'relative',
@@ -40,11 +41,11 @@ const styles: StyleRulesCallback<CssRules> = theme => {
     };
 };
 
-interface SearchBarDataProps {
-    value: string;
+type SearchBarDataProps = {
+    searchValue: string;
     currentView: string;
     open: boolean;
-}
+} & SearchBarAutocompleteViewDataProps;
 
 interface SearchBarActionProps {
     onSearch: (value: string) => any;
@@ -60,16 +61,20 @@ interface SearchBarState {
     value: string;
 }
 
-export const renderRecentQueries = (text: string) => {
+interface RenderQueriesProps {
+    text: string | JSX.Element;
+}
+
+export const RecentQueriesItem = (props: RenderQueriesProps) => {
     return <ListItem button>
-        <ListItemText secondary={text} />
+        <ListItemText secondary={props.text} />
     </ListItem>;
 };
 
 
-export const renderSavedQueries = (text: string) => {
+export const RenderSavedQueries = (props: RenderQueriesProps) => {
     return <ListItem button>
-        <ListItemText secondary={text} />
+        <ListItemText secondary={props.text} />
         <ListItemSecondaryAction>
             <Tooltip title="Remove">
                 <IconButton aria-label="Remove">
@@ -119,12 +124,12 @@ export const SearchBarView = withStyles(styles)(
         }
 
         componentDidMount() {
-            this.setState({ value: this.props.value });
+            this.setState({ value: this.props.searchValue });
         }
 
         componentWillReceiveProps(nextProps: SearchBarProps) {
-            if (nextProps.value !== this.props.value) {
-                this.setState({ value: nextProps.value });
+            if (nextProps.searchValue !== this.props.searchValue) {
+                this.setState({ value: nextProps.searchValue });
             }
         }
 
@@ -139,7 +144,9 @@ export const SearchBarView = withStyles(styles)(
                 case SearchView.ADVANCED:
                     return <SearchBarAdvancedView setView={this.props.onSetView} />;
                 case SearchView.AUTOCOMPLETE:
-                    return <SearchBarAutocompleteView />;
+                    return <SearchBarAutocompleteView 
+                                searchResults={this.props.searchResults} 
+                                searchValue={this.props.searchValue} />;
                 default:
                     return <SearchBarBasicView setView={this.props.onSetView} />;
             }