6260: Remove test for impossible condition.
[arvados.git] / services / datamanager / keep / keep.go
index c666337d0dd98da68b1a21e24dd06304b80f4930..1a75bb1e3356e6bd6cd407f3023e092ada286870 100644 (file)
@@ -5,22 +5,24 @@ package keep
 import (
        "bufio"
        "encoding/json"
-       "flag"
+       "errors"
        "fmt"
        "git.curoverse.com/arvados.git/sdk/go/arvadosclient"
        "git.curoverse.com/arvados.git/sdk/go/blockdigest"
+       "git.curoverse.com/arvados.git/sdk/go/keepclient"
        "git.curoverse.com/arvados.git/sdk/go/logger"
        "git.curoverse.com/arvados.git/services/datamanager/loggerutil"
+       "io"
        "io/ioutil"
        "log"
        "net/http"
        "strconv"
        "strings"
-       "sync"
        "time"
 )
 
 type ServerAddress struct {
+       SSL  bool   `json:service_ssl_flag`
        Host string `json:"service_host"`
        Port int    `json:"service_port"`
        Uuid string `json:"uuid"`
@@ -67,50 +69,17 @@ type KeepServiceList struct {
        KeepServers    []ServerAddress `json:"items"`
 }
 
-var (
-       // Don't access the token directly, use getDataManagerToken() to
-       // make sure it's been read.
-       dataManagerToken             string
-       dataManagerTokenFile         string
-       dataManagerTokenFileReadOnce sync.Once
-)
-
-func init() {
-       flag.StringVar(&dataManagerTokenFile,
-               "data-manager-token-file",
-               "",
-               "File with the API token we should use to contact keep servers.")
-}
-
 // TODO(misha): Change this to include the UUID as well.
 func (s ServerAddress) String() string {
-       return s.HostPort()
+       return s.URL()
 }
 
-func (s ServerAddress) HostPort() string {
-       return fmt.Sprintf("%s:%d", s.Host, s.Port)
-}
-
-func getDataManagerToken(arvLogger *logger.Logger) string {
-       readDataManagerToken := func() {
-               if dataManagerTokenFile == "" {
-                       flag.Usage()
-                       loggerutil.FatalWithMessage(arvLogger,
-                               "Data Manager Token needed, but data manager token file not specified.")
-               } else {
-                       rawRead, err := ioutil.ReadFile(dataManagerTokenFile)
-                       if err != nil {
-                               loggerutil.FatalWithMessage(arvLogger,
-                                       fmt.Sprintf("Unexpected error reading token file %s: %v",
-                                               dataManagerTokenFile,
-                                               err))
-                       }
-                       dataManagerToken = strings.TrimSpace(string(rawRead))
-               }
+func (s ServerAddress) URL() string {
+       if s.SSL {
+               return fmt.Sprintf("https://%s:%d", s.Host, s.Port)
+       } else {
+               return fmt.Sprintf("http://%s:%d", s.Host, s.Port)
        }
-
-       dataManagerTokenFileReadOnce.Do(readDataManagerToken)
-       return dataManagerToken
 }
 
 func GetKeepServersAndSummarize(params GetKeepServersParams) (results ReadServers) {
@@ -125,11 +94,6 @@ func GetKeepServersAndSummarize(params GetKeepServersParams) (results ReadServer
 }
 
 func GetKeepServers(params GetKeepServersParams) (results ReadServers) {
-       if &params.Client == nil {
-               log.Fatalf("params.Client passed to GetKeepServers() should " +
-                       "contain a valid ArvadosClient, but instead it is nil.")
-       }
-
        sdkParams := arvadosclient.Dict{
                "filters": [][]string{[]string{"service_type", "=", "disk"}},
        }
@@ -169,9 +133,6 @@ func GetKeepServers(params GetKeepServersParams) (results ReadServers) {
 
        log.Printf("Got Server Addresses: %v", results)
 
-       // This is safe for concurrent use
-       client := http.Client{}
-
        // Send off all the index requests concurrently
        responseChan := make(chan ServerResponse)
        for _, keepServer := range sdkResponse.KeepServers {
@@ -184,7 +145,7 @@ func GetKeepServers(params GetKeepServersParams) (results ReadServers) {
                go func(keepServer ServerAddress) {
                        responseChan <- GetServerContents(params.Logger,
                                keepServer,
-                               client)
+                               params.Client)
                }(keepServer)
        }
 
@@ -212,12 +173,12 @@ func GetKeepServers(params GetKeepServersParams) (results ReadServers) {
 
 func GetServerContents(arvLogger *logger.Logger,
        keepServer ServerAddress,
-       client http.Client) (response ServerResponse) {
+       arv arvadosclient.ArvadosClient) (response ServerResponse) {
 
-       GetServerStatus(arvLogger, keepServer, client)
+       GetServerStatus(arvLogger, keepServer, arv)
 
-       req := CreateIndexRequest(arvLogger, keepServer)
-       resp, err := client.Do(req)
+       req := CreateIndexRequest(arvLogger, keepServer, arv)
+       resp, err := arv.Client.Do(req)
        if err != nil {
                loggerutil.FatalWithMessage(arvLogger,
                        fmt.Sprintf("Error fetching %s: %v. Response was %+v",
@@ -231,7 +192,7 @@ func GetServerContents(arvLogger *logger.Logger,
 
 func GetServerStatus(arvLogger *logger.Logger,
        keepServer ServerAddress,
-       client http.Client) {
+       arv arvadosclient.ArvadosClient) {
        url := fmt.Sprintf("http://%s:%d/status.json",
                keepServer.Host,
                keepServer.Port)
@@ -249,7 +210,7 @@ func GetServerStatus(arvLogger *logger.Logger,
                })
        }
 
-       resp, err := client.Get(url)
+       resp, err := arv.Client.Get(url)
        if err != nil {
                loggerutil.FatalWithMessage(arvLogger,
                        fmt.Sprintf("Error getting keep status from %s: %v", url, err))
@@ -281,7 +242,8 @@ func GetServerStatus(arvLogger *logger.Logger,
 }
 
 func CreateIndexRequest(arvLogger *logger.Logger,
-       keepServer ServerAddress) (req *http.Request) {
+       keepServer ServerAddress,
+       arv arvadosclient.ArvadosClient) (req *http.Request) {
        url := fmt.Sprintf("http://%s:%d/index", keepServer.Host, keepServer.Port)
        log.Println("About to fetch keep server contents from " + url)
 
@@ -300,8 +262,7 @@ func CreateIndexRequest(arvLogger *logger.Logger,
                        fmt.Sprintf("Error building http request for %s: %v", url, err))
        }
 
-       req.Header.Add("Authorization",
-               fmt.Sprintf("OAuth2 %s", getDataManagerToken(arvLogger)))
+       req.Header.Add("Authorization", "OAuth2 " + arv.ApiToken)
        return
 }
 
@@ -328,11 +289,35 @@ func ReadServerResponse(arvLogger *logger.Logger,
        response.Address = keepServer
        response.Contents.BlockDigestToInfo =
                make(map[blockdigest.DigestWithSize]BlockInfo)
-       scanner := bufio.NewScanner(resp.Body)
+       reader := bufio.NewReader(resp.Body)
        numLines, numDuplicates, numSizeDisagreements := 0, 0, 0
-       for scanner.Scan() {
+       for {
                numLines++
-               blockInfo, err := parseBlockInfoFromIndexLine(scanner.Text())
+               line, err := reader.ReadString('\n')
+               if err == io.EOF {
+                       loggerutil.FatalWithMessage(arvLogger,
+                               fmt.Sprintf("Index from %s truncated at line %d",
+                                       keepServer.String(), numLines))
+               } else if err != nil {
+                       loggerutil.FatalWithMessage(arvLogger,
+                               fmt.Sprintf("Error reading index response from %s at line %d: %v",
+                                       keepServer.String(), numLines, err))
+               }
+               if line == "\n" {
+                       if _, err := reader.Peek(1); err == nil {
+                               extra, _ := reader.ReadString('\n')
+                               loggerutil.FatalWithMessage(arvLogger,
+                                       fmt.Sprintf("Index from %s had trailing data at line %d after EOF marker: %s",
+                                               keepServer.String(), numLines+1, extra))
+                       } else if err != io.EOF {
+                               loggerutil.FatalWithMessage(arvLogger,
+                                       fmt.Sprintf("Index from %s had read error after EOF marker at line %d: %v",
+                                               keepServer.String(), numLines, err))
+                       }
+                       numLines--
+                       break
+               }
+               blockInfo, err := parseBlockInfoFromIndexLine(line)
                if err != nil {
                        loggerutil.FatalWithMessage(arvLogger,
                                fmt.Sprintf("Error parsing BlockInfo from index line "+
@@ -352,31 +337,25 @@ func ReadServerResponse(arvLogger *logger.Logger,
                        response.Contents.BlockDigestToInfo[blockInfo.Digest] = blockInfo
                }
        }
-       if err := scanner.Err(); err != nil {
-               loggerutil.FatalWithMessage(arvLogger,
-                       fmt.Sprintf("Received error scanning index response from %s: %v",
-                               keepServer.String(),
-                               err))
-       } else {
-               log.Printf("%s index contained %d lines with %d duplicates with "+
-                       "%d size disagreements",
-                       keepServer.String(),
-                       numLines,
-                       numDuplicates,
-                       numSizeDisagreements)
-
-               if arvLogger != nil {
-                       now := time.Now()
-                       arvLogger.Update(func(p map[string]interface{}, e map[string]interface{}) {
-                               keepInfo := logger.GetOrCreateMap(p, "keep_info")
-                               serverInfo := keepInfo[keepServer.Uuid].(map[string]interface{})
-
-                               serverInfo["processing_finished_at"] = now
-                               serverInfo["lines_received"] = numLines
-                               serverInfo["duplicates_seen"] = numDuplicates
-                               serverInfo["size_disagreements_seen"] = numSizeDisagreements
-                       })
-               }
+
+       log.Printf("%s index contained %d lines with %d duplicates with "+
+               "%d size disagreements",
+               keepServer.String(),
+               numLines,
+               numDuplicates,
+               numSizeDisagreements)
+
+       if arvLogger != nil {
+               now := time.Now()
+               arvLogger.Update(func(p map[string]interface{}, e map[string]interface{}) {
+                       keepInfo := logger.GetOrCreateMap(p, "keep_info")
+                       serverInfo := keepInfo[keepServer.Uuid].(map[string]interface{})
+
+                       serverInfo["processing_finished_at"] = now
+                       serverInfo["lines_received"] = numLines
+                       serverInfo["duplicates_seen"] = numDuplicates
+                       serverInfo["size_disagreements_seen"] = numSizeDisagreements
+               })
        }
        resp.Body.Close()
        return
@@ -428,3 +407,69 @@ func (readServers *ReadServers) Summarize(arvLogger *logger.Logger) {
        }
 
 }
+
+type TrashRequest struct {
+       Locator    string `json:"locator"`
+       BlockMtime int64  `json:"block_mtime"`
+}
+
+type TrashList []TrashRequest
+
+func SendTrashLists(kc *keepclient.KeepClient, spl map[string]TrashList) (errs []error) {
+       count := 0
+       barrier := make(chan error)
+
+       client := kc.Client
+
+       for url, v := range spl {
+               count += 1
+               log.Printf("Sending trash list to %v", url)
+
+               go (func(url string, v TrashList) {
+                       pipeReader, pipeWriter := io.Pipe()
+                       go (func() {
+                               enc := json.NewEncoder(pipeWriter)
+                               enc.Encode(v)
+                               pipeWriter.Close()
+                       })()
+
+                       req, err := http.NewRequest("PUT", fmt.Sprintf("%s/trash", url), pipeReader)
+                       if err != nil {
+                               log.Printf("Error creating trash list request for %v error: %v", url, err.Error())
+                               barrier <- err
+                               return
+                       }
+
+                       req.Header.Add("Authorization", "OAuth2 " + kc.Arvados.ApiToken)
+
+                       // Make the request
+                       var resp *http.Response
+                       if resp, err = client.Do(req); err != nil {
+                               log.Printf("Error sending trash list to %v error: %v", url, err.Error())
+                               barrier <- err
+                               return
+                       }
+
+                       log.Printf("Sent trash list to %v: response was HTTP %v", url, resp.Status)
+
+                       io.Copy(ioutil.Discard, resp.Body)
+                       resp.Body.Close()
+
+                       if resp.StatusCode != 200 {
+                               barrier <- errors.New(fmt.Sprintf("Got HTTP code %v", resp.StatusCode))
+                       } else {
+                               barrier <- nil
+                       }
+               })(url, v)
+
+       }
+
+       for i := 0; i < count; i += 1 {
+               b := <-barrier
+               if b != nil {
+                       errs = append(errs, b)
+               }
+       }
+
+       return errs
+}