require 'test_helper'
+require 'helpers/users_test_helper'
class Arvados::V1::UsersControllerTest < ActionController::TestCase
include CurrentApiClient
+ include UsersTestHelper
setup do
@all_links_at_start = Link.all
name: 'click',
tail_uuid: users(:inactive).uuid,
head_uuid: required_uuids).
- collect(&:head_uuid)
+ collect(&:head_uuid)
assert_equal 0, signed_uuids.length
end
authorize_with :inactive
+ assert_equal false, users(:inactive).is_active
post :activate, id: users(:inactive).uuid
assert_response 403
- response_body = JSON.parse(@response.body)
- assert response_body['errors'].first.include? 'Cannot activate without user agreements'
+ resp = json_response
+ assert resp['errors'].first.include? 'Cannot activate without user agreements'
+ assert_nil resp['is_active']
end
test "activate an already-active user" do
test "create user with user, vm and repo as input" do
authorize_with :admin
- repo_name = 'test_repo'
+ repo_name = 'usertestrepo'
post :setup, {
repo_name: repo_name,
created['uuid'], created['email'], 'arvados#user', false, 'User'
verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
- repo_name, created['uuid'], 'arvados#repository', true, 'Repository'
+ "foo/#{repo_name}", created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
post :setup, {
uuid: 'bogus_uuid',
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
vm_uuid: @vm_uuid
}
response_body = JSON.parse(@response.body)
post :setup, {
user: {uuid: 'bogus_uuid'},
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
vm_uuid: @vm_uuid,
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
authorize_with :admin
post :setup, {
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
vm_uuid: @vm_uuid,
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
post :setup, {
user: {},
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
vm_uuid: @vm_uuid,
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
post :setup, {
uuid: users(:inactive).uuid,
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
vm_uuid: @vm_uuid
}
# expect repo and vm links
verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
- 'test_repo', resp_obj['uuid'], 'arvados#repository', true, 'Repository'
+ 'inactiveuser/usertestrepo', resp_obj['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
@vm_uuid, resp_obj['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
authorize_with :admin
post :setup, {
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
user: {email: 'foo@example.com'},
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
authorize_with :admin
post :setup, {
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
vm_uuid: 'no_such_vm',
user: {email: 'foo@example.com'},
openid_prefix: 'https://www.google.com/accounts/o8/id'
authorize_with :admin
post :setup, {
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
openid_prefix: 'https://www.google.com/accounts/o8/id',
vm_uuid: @vm_uuid,
user: {email: 'foo@example.com'}
verify_num_links @all_links_at_start, 5
end
- test "setup user with valid email, no vm and repo as input" do
+ test "setup user with valid email, no vm and no repo as input" do
authorize_with :admin
post :setup, {
# three extra links; system_group, login, and group
verify_num_links @all_links_at_start, 3
+
+ verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
+ response_object['uuid'], response_object['email'], 'arvados#user', false, 'User'
+
+ verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
+ 'All users', response_object['uuid'], 'arvados#group', true, 'Group'
+
+ verify_link response_items, 'arvados#repository', false, 'permission', 'can_manage',
+ 'foo/usertestrepo', response_object['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
+ nil, response_object['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
end
test "setup user with email, first name, repo name and vm uuid" do
post :setup, {
openid_prefix: 'https://www.google.com/accounts/o8/id',
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
vm_uuid: @vm_uuid,
user: {
first_name: 'test_first_name',
verify_num_links @all_links_at_start, 5
end
- test "setup user with an exising user email and check different object is created" do
+ test "setup user with an existing user email and check different object is created" do
authorize_with :admin
inactive_user = users(:inactive)
post :setup, {
openid_prefix: 'https://www.google.com/accounts/o8/id',
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
user: {
email: inactive_user['email']
}
authorize_with :admin
post :setup, {
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
openid_prefix: 'http://www.example.com/account',
user: {
first_name: "in_create_test_first_name",
created['uuid'], created['email'], 'arvados#user', false, 'User'
verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
- 'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+ 'foo/usertestrepo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
authorize_with :admin
post :setup, {
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
user: {
first_name: "in_create_test_first_name",
last_name: "test_last_name",
email: "foo@example.com"
},
vm_uuid: @vm_uuid,
- repo_name: 'test_repo',
+ repo_name: 'usertestrepo',
openid_prefix: 'https://www.google.com/accounts/o8/id'
}
created['uuid'], created['email'], 'arvados#user', false, 'User'
verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
- 'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+ 'foo/usertestrepo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
'Expected Forbidden error'
end
- test "setup user in multiple steps and verify response" do
+ test "setup active user with repo and no vm" do
authorize_with :admin
+ active_user = users(:active)
+ # invoke setup with a repository
post :setup, {
- openid_prefix: 'http://www.example.com/account',
- user: {
- email: "foo@example.com"
- }
- }
-
- assert_response :success
- response_items = JSON.parse(@response.body)['items']
- created = find_obj_in_resp response_items, 'User', nil
-
- assert_not_nil created['uuid'], 'expected uuid for new user'
- assert_not_nil created['email'], 'expected non-nil email'
- assert_equal created['email'], 'foo@example.com', 'expected input email'
-
- # three new links: system_group, arvados#user, and 'All users' group.
- verify_num_links @all_links_at_start, 3
-
- verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
- created['uuid'], created['email'], 'arvados#user', false, 'User'
-
- verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
- 'All users', created['uuid'], 'arvados#group', true, 'Group'
-
- verify_link response_items, 'arvados#repository', false, 'permission', 'can_manage',
- 'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
-
- verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
- nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
-
- # invoke setup with a repository
- post :setup, {
- openid_prefix: 'http://www.example.com/account',
- repo_name: 'new_repo',
- uuid: created['uuid']
+ repo_name: 'usertestrepo',
+ uuid: active_user['uuid']
}
assert_response :success
response_items = JSON.parse(@response.body)['items']
created = find_obj_in_resp response_items, 'User', nil
- assert_equal 'foo@example.com', created['email'], 'expected input email'
+ assert_equal active_user[:email], created['email'], 'expected input email'
# verify links
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
- 'new_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+ 'active/usertestrepo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+ end
+
+ test "setup active user with vm and no repo" do
+ authorize_with :admin
+ active_user = users(:active)
+ repos_query = Repository.where(owner_uuid: active_user.uuid)
+ repo_link_query = Link.where(tail_uuid: active_user.uuid,
+ link_class: "permission", name: "can_manage")
+ repos_count = repos_query.count
+ repo_link_count = repo_link_query.count
- # invoke setup with a vm_uuid
+ # invoke setup with a repository
post :setup, {
vm_uuid: @vm_uuid,
- openid_prefix: 'http://www.example.com/account',
- user: {
- email: 'junk_email'
- },
- uuid: created['uuid']
+ uuid: active_user['uuid'],
+ email: 'junk_email'
}
assert_response :success
response_items = JSON.parse(@response.body)['items']
created = find_obj_in_resp response_items, 'User', nil
- assert_equal created['email'], 'foo@example.com', 'expected original email'
+ assert_equal active_user['email'], created['email'], 'expected original email'
# verify links
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
- # since no repo name in input, we won't get any; even though user has one
- verify_link response_items, 'arvados#repository', false, 'permission', 'can_manage',
- 'new_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+ assert_equal(repos_count, repos_query.count)
+ assert_equal(repo_link_count, repo_link_query.count)
verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
@vm_uuid, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
assert active_user['is_active'], 'expected is_active for active user'
verify_link_existence active_user['uuid'], active_user['email'],
- false, true, false, true, true
+ false, true, true, true, true
authorize_with :admin
assert_equal Rails.configuration.user_notifier_email_from, setup_email.from[0]
assert_equal 'foo@example.com', setup_email.to[0]
- assert_equal 'Welcome to Curoverse', setup_email.subject
- assert (setup_email.body.to_s.include? 'Your Arvados account has been set up'),
- 'Expected Your Arvados account has been set up in email body'
- assert (setup_email.body.to_s.include? 'foo@example.com'),
- 'Expected user email in email body'
+ assert_equal 'Welcome to Curoverse - shell account enabled', setup_email.subject
+ assert (setup_email.body.to_s.include? 'Your Arvados shell account has been set up'),
+ 'Expected Your Arvados shell account has been set up in email body'
+ assert (setup_email.body.to_s.include? '/virtual_machines'),
+ 'Expected /virtual_machines link to appear in email body'
assert (setup_email.body.to_s.include? Rails.configuration.workbench_address),
'Expected workbench url in email body'
end
check_non_admin_show
end
- test "non-admin user can limit index" do
- g = act_as_system_user do
- create :group
- end
- users = create_list :active_user, 4, join_groups: [g]
- token = create :token, user: users[0]
+ [2, 4].each do |limit|
+ test "non-admin user can limit index to #{limit}" do
+ g = act_as_system_user do
+ create :group
+ end
+ users = create_list :active_user, 4, join_groups: [g]
+ token = create :token, user: users[0]
- [2, 4].each do |limit|
authorize_with_token token
get(:index, limit: limit)
check_non_admin_index
authorize_with :admin
user = {}
- user[:prefs] = users(:active_no_prefs_profile).prefs
+ user[:prefs] = users(:active_no_prefs_profile_no_getting_started_shown).prefs
user[:prefs][:profile] = {:profile => {'organization' => 'example.com'}}
put :update, {
- id: users(:active_no_prefs_profile).uuid,
+ id: users(:active_no_prefs_profile_no_getting_started_shown).uuid,
user: user
}
assert_response :success
found_email = false
ActionMailer::Base.deliveries.andand.each do |email|
- if email.subject == "Profile created by #{users(:active_no_prefs_profile).email}"
+ if email.subject == "Profile created by #{users(:active_no_prefs_profile_no_getting_started_shown).email}"
found_email = true
break
end
assert_equal false, found_email, 'Expected no email after updating profile'
end
+ test "user API response includes writable_by" do
+ authorize_with :active
+ get :current
+ assert_response :success
+ assert_includes(json_response["writable_by"], users(:active).uuid,
+ "user's writable_by should include self")
+ assert_includes(json_response["writable_by"], users(:active).owner_uuid,
+ "user's writable_by should include its owner_uuid")
+ end
+
NON_ADMIN_USER_DATA = ["uuid", "kind", "is_active", "email", "first_name",
"last_name"].sort
}
return return_obj
end
-
- def verify_link(response_items, link_object_name, expect_link, link_class,
- link_name, head_uuid, tail_uuid, head_kind, fetch_object, class_name)
-
- link = find_obj_in_resp response_items, 'Link', link_object_name
-
- if !expect_link
- assert_nil link, "Expected no link for #{link_object_name}"
- return
- end
-
- assert_not_nil link, "Expected link for #{link_object_name}"
-
- if fetch_object
- object = Object.const_get(class_name).where(name: head_uuid)
- assert [] != object, "expected #{class_name} with name #{head_uuid}"
- head_uuid = object.first[:uuid]
- end
- assert_equal link_class, link['link_class'],
- "did not find expected link_class for #{link_object_name}"
-
- assert_equal link_name, link['name'],
- "did not find expected link_name for #{link_object_name}"
-
- assert_equal tail_uuid, link['tail_uuid'],
- "did not find expected tail_uuid for #{link_object_name}"
-
- assert_equal head_kind, link['head_kind'],
- "did not find expected head_kind for #{link_object_name}"
-
- assert_equal head_uuid, link['head_uuid'],
- "did not find expected head_uuid for #{link_object_name}"
- end
-
- def verify_link_existence uuid, email, expect_oid_login_perms,
- expect_repo_perms, expect_vm_perms, expect_group_perms, expect_signatures
- # verify that all links are deleted for the user
- oid_login_perms = Link.where(tail_uuid: email,
- link_class: 'permission',
- name: 'can_login').where("head_uuid like ?", User.uuid_like_pattern)
- if expect_oid_login_perms
- assert oid_login_perms.any?, "expected oid_login_perms"
- else
- assert !oid_login_perms.any?, "expected all oid_login_perms deleted"
- end
-
- repo_perms = Link.where(tail_uuid: uuid,
- link_class: 'permission',
- name: 'can_manage').where("head_uuid like ?", Repository.uuid_like_pattern)
- if expect_repo_perms
- assert repo_perms.any?, "expected repo_perms"
- else
- assert !repo_perms.any?, "expected all repo_perms deleted"
- end
-
- vm_login_perms = Link.
- where(tail_uuid: uuid,
- link_class: 'permission',
- name: 'can_login').
- where("head_uuid like ?",
- VirtualMachine.uuid_like_pattern).
- where('uuid <> ?',
- links(:auto_setup_vm_login_username_can_login_to_test_vm).uuid)
- if expect_vm_perms
- assert vm_login_perms.any?, "expected vm_login_perms"
- else
- assert !vm_login_perms.any?, "expected all vm_login_perms deleted"
- end
-
- group = Group.where(name: 'All users').select do |g|
- g[:uuid].match /-f+$/
- end.first
- group_read_perms = Link.where(tail_uuid: uuid,
- head_uuid: group[:uuid],
- link_class: 'permission',
- name: 'can_read')
- if expect_group_perms
- assert group_read_perms.any?, "expected all users group read perms"
- else
- assert !group_read_perms.any?, "expected all users group perm deleted"
- end
-
- signed_uuids = Link.where(link_class: 'signature',
- tail_uuid: uuid)
-
- if expect_signatures
- assert signed_uuids.any?, "expected signatures"
- else
- assert !signed_uuids.any?, "expected all signatures deleted"
- end
-
- end
-
- def verify_system_group_permission_link_for user_uuid
- assert_equal 1, Link.where(link_class: 'permission',
- name: 'can_manage',
- tail_uuid: system_group_uuid,
- head_uuid: user_uuid).count
- end
end
projects / arvados.git / blobdiff