Merge branch '1880-check-duplicate-public-key'

[arvados.git] / services / api / app / models / arvados_model.rb

diff --git a/services/api/app/models/arvados_model.rb b/services/api/app/models/arvados_model.rb
index c5c3dd2579111ba0d17a7f776996d43a30d88422..2999b5271331ed9d11ef382fb826350d6646e417 100644 (file)
--- a/services/api/app/models/arvados_model.rb
+++ b/services/api/app/models/arvados_model.rb
@@ -4,11 +4,12 @@ class ArvadosModel < ActiveRecord::Base
   include CurrentApiClient      # current_user, current_api_client, etc.
 
   attr_protected :created_at
-  attr_protected :modified_by_user
-  attr_protected :modified_by_client
+  attr_protected :modified_by_user_uuid
+  attr_protected :modified_by_client_uuid
   attr_protected :modified_at
   before_create :ensure_permission_to_create
   before_update :ensure_permission_to_update
+  before_destroy :ensure_permission_to_destroy
   before_create :update_modified_by_fields
   before_update :maybe_update_modified_by_fields
   validate :ensure_serialized_attribute_type
@@ -16,12 +17,33 @@ class ArvadosModel < ActiveRecord::Base
   has_many :permissions, :foreign_key => :head_uuid, :class_name => 'Link', :primary_key => :uuid, :conditions => "link_class = 'permission'"
 
   class PermissionDeniedError < StandardError
+    def http_status
+      403
+    end
+  end
+
+  class UnauthorizedError < StandardError
+    def http_status
+      401
+    end
   end
 
   def self.kind_class(kind)
     kind.match(/^arvados\#(.+?)(_list|List)?$/)[1].pluralize.classify.constantize rescue nil
   end
 
+  def href
+    "#{current_api_base}/#{self.class.to_s.pluralize.underscore}/#{self.uuid}"
+  end
+
+  def self.searchable_columns
+    self.columns.collect do |col|
+      if [:string, :text].index(col.type) && col.name != 'owner_uuid'
+        col.name
+      end
+    end.compact
+  end
+
   def eager_load_associations
     self.class.columns.each do |col|
       re = col.name.match /^(.*)_kind$/
@@ -58,41 +80,49 @@ class ArvadosModel < ActiveRecord::Base
       logger.warn "Inactive user #{current_user.uuid} tried to update #{self.class.to_s} #{self.uuid_was}"
       return false
     end
+    return true if current_user.is_admin
     if self.uuid_changed?
       logger.warn "User #{current_user.uuid} tried to change uuid of #{self.class.to_s} #{self.uuid_was} to #{self.uuid}"
       return false
     end
-    return true if current_user.is_admin
-    if self.owner_changed?
-      if current_user.uuid == self.owner or
-          current_user.can? write: self.owner
+    if self.owner_uuid_changed?
+      if current_user.uuid == self.owner_uuid or
+          current_user.can? write: self.owner_uuid
         # current_user is, or has :write permission on, the new owner
       else
-        logger.warn "User #{current_user.uuid} tried to change owner of #{self.class.to_s} #{self.uuid} to #{self.owner} but does not have permission to write to #{self.owner}"
+        logger.warn "User #{current_user.uuid} tried to change owner_uuid of #{self.class.to_s} #{self.uuid} to #{self.owner_uuid} but does not have permission to write to #{self.owner_uuid}"
         return false
       end
     end
-    if current_user.uuid == self.owner_was or
+    if current_user.uuid == self.owner_uuid_was or
         current_user.uuid == self.uuid or
-        current_user.can? write: self.owner_was
+        current_user.can? write: self.owner_uuid_was
       # current user is, or has :write permission on, the previous owner
       return true
     else
-      logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{self.uuid} but does not have permission to write #{self.owner_was}"
+      logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{self.uuid} but does not have permission to write #{self.owner_uuid_was}"
       return false
     end
   end
 
+  def ensure_permission_to_destroy
+    raise PermissionDeniedError unless permission_to_destroy
+  end
+
+  def permission_to_destroy
+    permission_to_update
+  end
+
   def maybe_update_modified_by_fields
     update_modified_by_fields if self.changed?
   end
 
   def update_modified_by_fields
     self.created_at ||= Time.now
-    self.owner ||= current_default_owner
+    self.owner_uuid ||= current_default_owner
     self.modified_at = Time.now
-    self.modified_by_user = current_user ? current_user.uuid : nil
-    self.modified_by_client = current_api_client ? current_api_client.uuid : nil
+    self.modified_by_user_uuid = current_user ? current_user.uuid : nil
+    self.modified_by_client_uuid = current_api_client ? current_api_client.uuid : nil
   end
 
   def ensure_serialized_attribute_type