verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
created['uuid'], created['email'], 'arvados#user', false, 'User'
- verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
repo_name, created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
# arvados#user, repo link and link add user to 'All users' group
verify_num_links @all_links_at_start, 5
- verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
repo_name, created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'expecting inactive user email'
# expect repo and vm links
- verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
'test_repo', resp_obj['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
created['uuid'], created['email'], 'arvados#user', false, 'User'
- verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
verify_link response_items, 'arvados#user', true, 'permission', 'can_login',
created['uuid'], created['email'], 'arvados#user', false, 'User'
- verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
- verify_link response_items, 'arvados#repository', false, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', false, 'permission', 'can_manage',
'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
- verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
'new_repo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#virtualMachine', false, 'permission', 'can_login',
'All users', created['uuid'], 'arvados#group', true, 'Group'
# since no repo name in input, we won't get any; even though user has one
- verify_link response_items, 'arvados#repository', false, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', false, 'permission', 'can_manage',
'new_repo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
verify_link response_items, 'arvados#group', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
- verify_link response_items, 'arvados#repository', true, 'permission', 'can_write',
+ verify_link response_items, 'arvados#repository', true, 'permission', 'can_manage',
'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
verify_link response_items, 'arvados#virtualMachine', true, 'permission', 'can_login',
verify_link_existence response_user['uuid'], response_user['email'],
false, false, false, false, false
+
+ active_user = User.find_by_uuid(users(:active).uuid)
+ readable_groups = active_user.groups_i_can(:read)
+ all_users_group = Group.all.collect(&:uuid).select { |g| g.match /-f+$/ }
+ refute_includes(readable_groups, all_users_group,
+ "active user can read All Users group after being deactivated")
+ assert_equal(false, active_user.is_invited,
+ "active user is_invited after being deactivated & reloaded")
end
test "setup user with send notification param false and verify no email" do
'Expected workbench url in email body'
end
- test "non-admin user can get basic information about active users" do
+ test "non-admin user can get basic information about readable users" do
authorize_with :spectator
get(:index)
check_non_admin_index
- check_active_users_index
+ check_readable_users_index [:spectator], [:inactive, :active]
+ end
+
+ test "non-admin user gets only safe attributes from users#show" do
+ g = act_as_system_user do
+ create :group
+ end
+ users = create_list :active_user, 2, join_groups: [g]
+ token = create :token, user: users[0]
+ authorize_with_token token
+ get :show, id: users[1].uuid
+ check_non_admin_show
end
test "non-admin user can limit index" do
+ g = act_as_system_user do
+ create :group
+ end
+ users = create_list :active_user, 4, join_groups: [g]
+ token = create :token, user: users[0]
+
+ [2, 4].each do |limit|
+ authorize_with_token token
+ get(:index, limit: limit)
+ check_non_admin_index
+ assert_equal(limit, json_response["items"].size,
+ "non-admin index limit was ineffective")
+ end
+ end
+
+ test "admin has full index powers" do
+ authorize_with :admin
+ check_inactive_user_findable
+ end
+
+ test "reader token can grant admin index powers" do
authorize_with :spectator
- get(:index, limit: 2)
- check_non_admin_index
- assert_equal(2, json_response["items"].size,
- "non-admin index limit was ineffective")
+ check_inactive_user_findable(reader_tokens: [api_token(:admin)])
end
- test "filters are ignored for non-admin index" do
- check_index_condition_fails(:spectator,
- filters: [["last_name", "=", "__nonexistent__"]])
+ test "admin can filter on user.is_active" do
+ authorize_with :admin
+ get(:index, filters: [["is_active", "=", "true"]])
+ assert_response :success
+ check_readable_users_index [:active, :spectator], [:inactive]
end
- test "where is ignored for non-admin index" do
- check_index_condition_fails(:spectator,
- where: {last_name: "__nonexistent__"})
+ test "admin can search where user.is_active" do
+ authorize_with :admin
+ get(:index, where: {is_active: true})
+ assert_response :success
+ check_readable_users_index [:active, :spectator], [:inactive]
end
- test "group admin is treated like non-admin for index" do
- check_index_condition_fails(:rominiadmin,
- filters: [["last_name", "=", "__nonexistent__"]])
+ test "update active_no_prefs user profile and expect notification email" do
+ authorize_with :admin
+
+ put :update, {
+ id: users(:active_no_prefs).uuid,
+ user: {
+ prefs: {:profile => {'organization' => 'example.com'}}
+ }
+ }
+ assert_response :success
+
+ found_email = false
+ ActionMailer::Base.deliveries.andand.each do |email|
+ if email.subject == "Profile created by #{users(:active_no_prefs).email}"
+ found_email = true
+ break
+ end
+ end
+ assert_equal true, found_email, 'Expected email after creating profile'
end
- test "admin has full index powers" do
+ test "update active_no_prefs_profile user profile and expect notification email" do
authorize_with :admin
- check_inactive_user_findable
+
+ user = {}
+ user[:prefs] = users(:active_no_prefs_profile).prefs
+ user[:prefs][:profile] = {:profile => {'organization' => 'example.com'}}
+ put :update, {
+ id: users(:active_no_prefs_profile).uuid,
+ user: user
+ }
+ assert_response :success
+
+ found_email = false
+ ActionMailer::Base.deliveries.andand.each do |email|
+ if email.subject == "Profile created by #{users(:active_no_prefs_profile).email}"
+ found_email = true
+ break
+ end
+ end
+ assert_equal true, found_email, 'Expected email after creating profile'
end
- test "reader token can grant admin index powers" do
- authorize_with :spectator
- check_inactive_user_findable(reader_tokens: [api_token(:admin)])
+ test "update active user profile and expect no notification email" do
+ authorize_with :admin
+
+ put :update, {
+ id: users(:active).uuid,
+ user: {
+ prefs: {:profile => {'organization' => 'anotherexample.com'}}
+ }
+ }
+ assert_response :success
+
+ found_email = false
+ ActionMailer::Base.deliveries.andand.each do |email|
+ if email.subject == "Profile created by #{users(:active).email}"
+ found_email = true
+ break
+ end
+ end
+ assert_equal false, found_email, 'Expected no email after updating profile'
end
+
NON_ADMIN_USER_DATA = ["uuid", "kind", "is_active", "email", "first_name",
"last_name"].sort
response_items = json_response["items"]
assert_not_nil response_items
response_items.each do |user_data|
- assert_equal(NON_ADMIN_USER_DATA, user_data.keys.sort,
- "data in all users response did not match expectations")
- assert_equal("arvados#user", user_data["kind"])
+ check_non_admin_item user_data
assert(user_data["is_active"], "non-admin index returned inactive user")
end
end
- def check_active_users_index
+ def check_non_admin_show
+ assert_response :success
+ check_non_admin_item json_response
+ end
+
+ def check_non_admin_item user_data
+ assert_equal(NON_ADMIN_USER_DATA, user_data.keys.sort,
+ "data in response had missing or extra attributes")
+ assert_equal("arvados#user", user_data["kind"])
+ end
+
+
+ def check_readable_users_index expect_present, expect_missing
response_uuids = json_response["items"].map { |u| u["uuid"] }
- [:admin, :miniadmin, :active, :spectator].each do |user_key|
+ expect_present.each do |user_key|
assert_includes(response_uuids, users(user_key).uuid,
"#{user_key} missing from index")
end
- refute_includes(response_uuids, users(:inactive).uuid,
- "inactive user included in index")
- end
-
- def check_index_condition_fails(user_sym, params)
- authorize_with user_sym
- get(:index, params)
- check_non_admin_index
- assert(json_response["items"]
- .any? { |u| u["last_name"] != "__nonexistent__" },
- "#{params.inspect} successfully applied to non-admin index")
+ expect_missing.each do |user_key|
+ refute_includes(response_uuids, users(user_key).uuid,
+ "#{user_key} included in index")
+ end
end
def check_inactive_user_findable(params={})
end
repo_perms = Link.where(tail_uuid: uuid,
- link_class: 'permission',
- name: 'can_write').where("head_uuid like ?", Repository.uuid_like_pattern)
+ link_class: 'permission',
+ name: 'can_manage').where("head_uuid like ?", Repository.uuid_like_pattern)
if expect_repo_perms
assert repo_perms.any?, "expected repo_perms"
else
assert !repo_perms.any?, "expected all repo_perms deleted"
end
- vm_login_perms = Link.where(tail_uuid: uuid,
- link_class: 'permission',
- name: 'can_login').where("head_uuid like ?", VirtualMachine.uuid_like_pattern)
+ vm_login_perms = Link.
+ where(tail_uuid: uuid,
+ link_class: 'permission',
+ name: 'can_login').
+ where("head_uuid like ?",
+ VirtualMachine.uuid_like_pattern).
+ where('uuid <> ?',
+ links(:auto_setup_vm_login_username_can_login_to_test_vm).uuid)
if expect_vm_perms
assert vm_login_perms.any?, "expected vm_login_perms"
else
g[:uuid].match /-f+$/
end.first
group_read_perms = Link.where(tail_uuid: uuid,
- head_uuid: group[:uuid],
- link_class: 'permission',
- name: 'can_read')
+ head_uuid: group[:uuid],
+ link_class: 'permission',
+ name: 'can_read')
if expect_group_perms
assert group_read_perms.any?, "expected all users group read perms"
else
end
signed_uuids = Link.where(link_class: 'signature',
- tail_uuid: uuid)
+ tail_uuid: uuid)
if expect_signatures
assert signed_uuids.any?, "expected signatures"
projects / arvados.git / blobdiff