+
+ test "'in docker' filter accepts arrays" do
+ get :index, params: {
+ filters: [["docker_image_locator", "in docker",
+ ["_nonesuchname_", "arvados/apitestfixture"]]]
+ }
+ assert_response :success
+ assert_not_nil assigns(:objects)
+ assert_includes(assigns(:objects).map { |job| job.uuid },
+ jobs(:previous_docker_job_run).uuid)
+ refute_includes(assigns(:objects).map { |job| job.uuid },
+ jobs(:previous_job_run).uuid)
+ end
+
+ test "'not in docker' filter accepts arrays" do
+ get :index, params: {
+ filters: [["docker_image_locator", "not in docker",
+ ["_nonesuchname_", "arvados/apitestfixture"]]]
+ }
+ assert_response :success
+ assert_not_nil assigns(:objects)
+ assert_includes(assigns(:objects).map { |job| job.uuid },
+ jobs(:previous_job_run).uuid)
+ refute_includes(assigns(:objects).map { |job| job.uuid },
+ jobs(:previous_docker_job_run).uuid)
+ end
+
+ JOB_SUBMIT_KEYS = [:script, :script_parameters, :script_version, :repository]
+ DEFAULT_START_JOB = :previous_job_run
+
+ def create_job_params(params, start_from=DEFAULT_START_JOB)
+ if not params.has_key?(:find_or_create)
+ params[:find_or_create] = true
+ end
+ job_attrs = params.delete(:job) || {}
+ start_job = jobs(start_from)
+ params[:job] = Hash[JOB_SUBMIT_KEYS.map do |key|
+ [key, start_job.send(key)]
+ end]
+ params[:job][:runtime_constraints] =
+ job_attrs.delete(:runtime_constraints) || {}
+ { arvados_sdk_version: :arvados_sdk_version,
+ docker_image_locator: :docker_image }.each do |method, constraint_key|
+ if constraint_value = start_job.send(method)
+ params[:job][:runtime_constraints][constraint_key] ||= constraint_value
+ end
+ end
+ params[:job].merge!(job_attrs)
+ params
+ end
+
+ def create_job_from(params, start_from)
+ post(:create, params: create_job_params(params, start_from))
+ assert_response :success
+ new_job = assigns(:object)
+ assert_not_nil new_job
+ new_job
+ end
+
+ def check_new_job_created_from(params, start_from=DEFAULT_START_JOB)
+ start_time = Time.now
+ new_job = create_job_from(params, start_from)
+ assert_operator(start_time, :<=, new_job.created_at)
+ new_job
+ end
+
+ def check_job_reused_from(params, start_from)
+ new_job = create_job_from(params, start_from)
+ assert_equal(jobs(start_from).uuid, new_job.uuid)
+ end
+
+ def check_errors_from(params, start_from=DEFAULT_START_JOB)
+ post(:create, params: create_job_params(params, start_from))
+ assert_includes(405..499, @response.code.to_i)
+ errors = json_response.fetch("errors", [])
+ assert(errors.any?, "no errors assigned from #{params}")
+ refute(errors.any? { |msg| msg =~ /^#<[A-Za-z]+: / },
+ "errors include raw exception: #{errors.inspect}")
+ errors
+ end
+
+ # 1de84a8 is on the b1 branch, after master's tip.
+ test "new job created from unsatisfiable minimum version filter" do
+ filters_hash = BASE_FILTERS.merge("script_version" => ["in git", "1de84a8"])
+ check_new_job_created_from(filters: filters_from_hash(filters_hash))
+ end
+
+ test "new job created from unsatisfiable minimum version parameter" do
+ check_new_job_created_from(minimum_script_version: "1de84a8")
+ end
+
+ test "new job created from unsatisfiable minimum version attribute" do
+ check_new_job_created_from(job: {minimum_script_version: "1de84a8"})
+ end
+
+ test "graceful error from nonexistent minimum version filter" do
+ filters_hash = BASE_FILTERS.merge("script_version" =>
+ ["in git", "__nosuchbranch__"])
+ errors = check_errors_from(filters: filters_from_hash(filters_hash))
+ assert(errors.any? { |msg| msg.include? "__nosuchbranch__" },
+ "bad refspec not mentioned in error message")
+ end
+
+ test "graceful error from nonexistent minimum version parameter" do
+ errors = check_errors_from(minimum_script_version: "__nosuchbranch__")
+ assert(errors.any? { |msg| msg.include? "__nosuchbranch__" },
+ "bad refspec not mentioned in error message")
+ end
+
+ test "graceful error from nonexistent minimum version attribute" do
+ errors = check_errors_from(job: {minimum_script_version: "__nosuchbranch__"})
+ assert(errors.any? { |msg| msg.include? "__nosuchbranch__" },
+ "bad refspec not mentioned in error message")
+ end
+
+ test "don't reuse job with older Arvados SDK version specified by branch" do
+ jobspec = {runtime_constraints: {
+ arvados_sdk_version: "master",
+ }}
+ check_new_job_created_from({job: jobspec},
+ :previous_job_run_with_arvados_sdk_version)
+ end
+
+ test "don't reuse job with older Arvados SDK version specified by commit" do
+ jobspec = {runtime_constraints: {
+ arvados_sdk_version: "ca68b24e51992e790f29df5cc4bc54ce1da4a1c2",
+ }}
+ check_new_job_created_from({job: jobspec},
+ :previous_job_run_with_arvados_sdk_version)
+ end
+
+ test "don't reuse job with newer Arvados SDK version specified by commit" do
+ jobspec = {runtime_constraints: {
+ arvados_sdk_version: "436637c87a1d2bdbf4b624008304064b6cf0e30c",
+ }}
+ check_new_job_created_from({job: jobspec},
+ :previous_job_run_with_arvados_sdk_version)
+ end
+
+ test "reuse job from arvados_sdk_version git filters" do
+ prev_job = jobs(:previous_job_run_with_arvados_sdk_version)
+ filters_hash = BASE_FILTERS.
+ merge("arvados_sdk_version" => ["in git", "commit2"],
+ "docker_image_locator" => ["=", prev_job.docker_image_locator])
+ filters_hash.delete("script_version")
+ params = create_job_params(filters: filters_from_hash(filters_hash))
+ post(:create, params: params)
+ assert_response :success
+ assert_equal(prev_job.uuid, assigns(:object).uuid)
+ end
+
+ test "create new job because of arvados_sdk_version 'not in git' filters" do
+ filters_hash = BASE_FILTERS.reject { |k| k == "script_version" }
+ filters = filters_from_hash(filters_hash)
+ # Allow anything from the root commit, but before commit 2.
+ filters += [["arvados_sdk_version", "in git", "436637c8"],
+ ["arvados_sdk_version", "not in git", "00634b2b"]]
+ check_new_job_created_from(filters: filters)
+ end