4091: enhance code to handle the case where there are more than one item in the next...

[arvados.git] / apps / workbench / app / controllers / pipeline_instances_controller.rb

diff --git a/apps/workbench/app/controllers/pipeline_instances_controller.rb b/apps/workbench/app/controllers/pipeline_instances_controller.rb
index 8ee06c3d011b8303f0c9726f894341533a8d0888..3d34c7b885253fc3e1f5625dc9aa8ed8f2e06696 100644 (file)
--- a/apps/workbench/app/controllers/pipeline_instances_controller.rb
+++ b/apps/workbench/app/controllers/pipeline_instances_controller.rb
@@ -16,12 +16,16 @@ class PipelineInstancesController < ApplicationController
       @object.components.each do |cname, component|
         # Go through the script parameters of each component
         # that are marked as user input and copy them over.
-        component[:script_parameters].each do |pname, val|
-          if val.is_a? Hash and val[:dataclass]
-            # this is user-inputtable, so check the value from the source pipeline
-            srcvalue = source.components[cname][:script_parameters][pname]
-            if not srcvalue.nil?
-              component[:script_parameters][pname] = srcvalue
+        # Skip any components that are not present in the
+        # source instance (there's nothing to copy)
+        if source.components.include? cname
+          component[:script_parameters].each do |pname, val|
+            if val.is_a? Hash and val[:dataclass]
+              # this is user-inputtable, so check the value from the source pipeline
+              srcvalue = source.components[cname][:script_parameters][pname]
+              if not srcvalue.nil?
+                component[:script_parameters][pname] = srcvalue
+              end
             end
           end
         end
@@ -33,7 +37,7 @@ class PipelineInstancesController < ApplicationController
     if params['script'] == 'use_same'
       # Go through each component and copy the script_version from each job.
       @object.components.each do |cname, component|
-        if source.components[cname][:job]
+        if source.components.include? cname and source.components[cname][:job]
           component[:script_version] = source.components[cname][:job][:script_version]
         end
       end
@@ -43,6 +47,13 @@ class PipelineInstancesController < ApplicationController
       component.delete :job
     end
     @object.state = 'New'
+
+    # set owner_uuid to that of source, provided it is a project and wriable by current user
+    current_project = Group.find(source.owner_uuid) rescue nil
+    if (current_project && current_project.writable_by.andand.include?(current_user.uuid))
+      @object.owner_uuid = source.owner_uuid
+    end
+
     super
   end
 
@@ -53,7 +64,8 @@ class PipelineInstancesController < ApplicationController
         if component[:script_parameters]
           component[:script_parameters].each do |param, value_info|
             if value_info.is_a? Hash
-              if resource_class_for_uuid(value_info[:value]) == Link
+              value_info_class = resource_class_for_uuid(value_info[:value])
+              if value_info_class == Link
                 # Use the link target, not the link itself, as script
                 # parameter; but keep the link info around as well.
                 link = Link.find value_info[:value]
@@ -65,6 +77,15 @@ class PipelineInstancesController < ApplicationController
                 value_info[:link_uuid] = nil
                 value_info[:link_name] = nil
               end
+              if value_info_class == Collection
+                # to ensure reproducibility, the script_parameter for a
+                # collection should be the portable_data_hash
+                # keep the collection name and uuid for human-readability
+                obj = Collection.find value_info[:value]
+                value_info[:value] = obj.portable_data_hash
+                value_info[:selection_uuid] = obj.uuid
+                value_info[:selection_name] = obj.name
+              end
             end
           end
         end