Merge branch 'master' into 3620-admin-only-gear-menu

[arvados.git] / services / api / test / functional / arvados / v1 / links_controller_test.rb

diff --git a/services/api/test/functional/arvados/v1/links_controller_test.rb b/services/api/test/functional/arvados/v1/links_controller_test.rb
index faeaae00a488b9d823b9884b07b0ac28803362c1..b4b78168f2444eb169d00c148bf076418f5830aa 100644 (file)
--- a/services/api/test/functional/arvados/v1/links_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/links_controller_test.rb
@@ -118,7 +118,7 @@ class Arvados::V1::LinksControllerTest < ActionController::TestCase
       link_class: 'test',
       name: 'stuff',
       head_uuid: users(:active).uuid,
-      tail_uuid: virtual_machines(:testvm).uuid
+      tail_uuid: virtual_machines(:testvm2).uuid
     }
     authorize_with :active
     post :create, link: link
@@ -298,16 +298,16 @@ class Arvados::V1::LinksControllerTest < ActionController::TestCase
     assert_response 404
   end
 
-  test "project owner can index project permissions" do
-    skip "Test tickles known bug"
-    # readable_by only lets users see permission links that relate to them
-    # directly.  It does not allow users to see permission links for groups
-    # they manage.
-    # We'd like to fix this general issue, but we haven't settled on a general
-    # way to do it that doesn't involve making readable_by ridiculously hairy.
-    # This test demonstrates the desired behavior once we're ready to tackle
-    # it.  In the meantime, clients should use /permissions to get this
-    # information.
+  test "retrieve all permissions using generic links index api" do
+    skip "(not implemented)"
+    # Links.readable_by() does not return the full set of permission
+    # links that are visible to a user (i.e., all permission links
+    # whose head_uuid references an object for which the user has
+    # ownership or can_manage permission). Therefore, neither does
+    # /arvados/v1/links.
+    #
+    # It is possible to retrieve the full set of permissions for a
+    # single object via /arvados/v1/permissions.
     authorize_with :active
     get :index, filters: [['link_class', '=', 'permission'],
                           ['head_uuid', '=', groups(:aproject).uuid]]