].each do |parameters|
test "verify job status #{parameters}" do
job = Job.create! job_attrs
- assert job.valid?, job.errors.full_messages.to_s
assert_equal 'Queued', job.state, "job.state"
parameters.each do |parameter|
test "verify job queue position" do
job1 = Job.create! job_attrs
- assert job1.valid?, job1.errors.full_messages.to_s
assert_equal 'Queued', job1.state, "Incorrect job state for newly created job1"
job2 = Job.create! job_attrs
- assert job2.valid?, job2.errors.full_messages.to_s
assert_equal 'Queued', job2.state, "Incorrect job state for newly created job2"
assert_not_nil job1.queue_position, "Expected non-nil queue position for job1"
SDK_TAGGED = "00634b2b8a492d6f121e3cf1d6587b821136a9a7"
def sdk_constraint(version)
- {runtime_constraints: {"arvados_sdk_version" => version}}
+ {runtime_constraints: {
+ "arvados_sdk_version" => version,
+ "docker_image" => links(:docker_image_collection_tag).name,
+ }}
end
def check_job_sdk_version(expected)
assert_nil(job.arvados_sdk_version)
end
+ test "job with SDK constraint, without Docker image is invalid" do
+ sdk_attrs = sdk_constraint("master")
+ sdk_attrs[:runtime_constraints].delete("docker_image")
+ job = Job.create(job_attrs(sdk_attrs))
+ refute(job.valid?, "Job valid with SDK version, without Docker image")
+ sdk_errors = job.errors.messages[:arvados_sdk_version] || []
+ refute_empty(sdk_errors.grep(/\bDocker\b/),
+ "no Job SDK errors mention that Docker is required")
+ end
+
+ test "invalid to clear Docker image constraint when SDK constraint exists" do
+ job = Job.create!(job_attrs(sdk_constraint("master")))
+ job.runtime_constraints.delete("docker_image")
+ refute(job.valid?,
+ "Job with SDK constraint valid after clearing Docker image")
+ end
+
test "can't create job with SDK version assigned directly" do
check_creation_prohibited(arvados_sdk_version: SDK_MASTER)
end
test "can't modify job to assign SDK version directly" do
check_modification_prohibited(arvados_sdk_version: SDK_MASTER)
end
+
+ test "job validation fails when collection uuid found in script_parameters" do
+ bad_params = {
+ script_parameters: {
+ 'input' => {
+ 'param1' => 'the collection uuid zzzzz-4zz18-012345678901234'
+ }
+ }
+ }
+ assert_raises(ActiveRecord::RecordInvalid,
+ "created job with a collection uuid in script_parameters") do
+ job = Job.create!(job_attrs(bad_params))
+ end
+ end
+
+ test "job validation succeeds when no collection uuid in script_parameters" do
+ good_params = {
+ script_parameters: {
+ 'arg1' => 'foo',
+ 'arg2' => [ 'bar', 'baz' ],
+ 'arg3' => {
+ 'a' => 1,
+ 'b' => [2, 3, 4],
+ }
+ }
+ }
+ job = Job.create!(job_attrs(good_params))
+ assert job.valid?
+ end
end