[
# Each test case is of the following format
# Array of parameters where each parameter is of the format:
- # attr name to be changed, attr value, (array of array of expectations OR the string "error")
+ # attr name to be changed, attr value, and array of expectations (where each expectation is an array)
[['running', false, [['state', 'Queued']]]],
- [['state', 'Running', [['running', true], ['started_at', 'not_nil'], ['success', 'nil']]]],
+ [['state', 'Running', [['started_at', 'not_nil']]]],
+ [['is_locked_by_uuid', 'use_current_user_uuid', [['state', 'Queued']]], ['state', 'Running', [['running', true], ['started_at', 'not_nil'], ['success', 'nil']]]],
[['running', false, [['state', 'Queued']]], ['state', 'Complete', [['success', true]]]],
- [['running', true, [['state', 'Running']]], ['cancelled_at', Time.now, [['state', 'Cancelled'],['running', false]]]],
- [['running', true, [['state', 'Running']]], ['state', 'Cancelled', [['running', false],['cancelled_at', 'not_nil']]]],
- [['running', true, [['state', 'Running']]], ['success', true, [['state', 'Complete'],['running', false],['finished_at', 'not_nil']]]],
- [['running', true, [['state', 'Running']]], ['success', 'false', [['state', 'Failed'],['running', false],['finished_at', 'not_nil']]]],
- [['running', true, [['state', 'Running']]], ['state', 'Complete', [['success', true],['running', false],['finished_at', 'not_nil']]]],
- [['running', true, [['state', 'Running']]], ['state', 'Failed', [['success', false],['running', false],['finished_at', 'not_nil']]]],
+ [['running', true, [['state', 'Running']]], ['cancelled_at', Time.now, [['state', 'Cancelled']]]],
+ [['running', true, [['state', 'Running']]], ['state', 'Cancelled', [['cancelled_at', 'not_nil']]]],
+ [['running', true, [['state', 'Running']]], ['success', true, [['state', 'Complete']]]],
+ [['running', true, [['state', 'Running']]], ['success', false, [['state', 'Failed']]]],
+ [['running', true, [['state', 'Running']]], ['state', 'Complete', [['success', true],['finished_at', 'not_nil']]]],
+ [['running', true, [['state', 'Running']]], ['state', 'Failed', [['success', false],['finished_at', 'not_nil']]]],
+ [['cancelled_at', Time.now, [['state', 'Cancelled']]], ['success', false, [['state', 'Cancelled'],['finished_at', 'nil'], ['cancelled_at', 'not_nil']]]],
+ [['cancelled_at', Time.now, [['state', 'Cancelled'],['running', false]]], ['success', true, [['state', 'Cancelled'],['running', false],['finished_at', 'nil'],['cancelled_at', 'not_nil']]]],
# potential migration cases
[['state', nil, [['state', 'Queued']]]],
[['state', nil, [['state', 'Queued']]], ['cancelled_at', Time.now, [['state', 'Cancelled']]]],
- [['running', true, [['state', 'Running'], ['started_at', 'not_nil']]], ['state', nil, [['state', 'Running']]]],
- # bogus initial status (started_at but not running), to produce error while setting state
- [['started_at', Time.now, [['state', 'Queued']]], ['state', nil, 'error']],
+ [['running', true, [['state', 'Running']]], ['state', nil, [['state', 'Running']]]],
].each do |parameters|
test "verify job status #{parameters}" do
job = Job.create! job_attrs
assert job.valid?, job.errors.full_messages.to_s
- assert_equal job.state, 'Queued'
+ assert_equal 'Queued', job.state, "job.state"
parameters.each do |parameter|
expectations = parameter[2]
+ if parameter[1] == 'use_current_user_uuid'
+ parameter[1] = Thread.current[:user].uuid
+ end
+
if expectations.instance_of? Array
job[parameter[0]] = parameter[1]
- job.save!
+ assert_equal true, job.save, job.errors.full_messages.to_s
expectations.each do |expectation|
if expectation[1] == 'not_nil'
- assert_not_nil job[expectation[0]]
+ assert_not_nil job[expectation[0]], expectation[0]
elsif expectation[1] == 'nil'
- assert_nil job[expectation[0]]
+ assert_nil job[expectation[0]], expectation[0]
else
- assert_equal expectation[1], job[expectation[0]]
+ assert_equal expectation[1], job[expectation[0]], expectation[0]
end
end
- else # String expectation, looking for error
- if expectations == 'error'
- rescued = false
- begin
- job[parameter[0]] = parameter[1]
- job.save!
- rescue
- rescued = true
- end
- assert rescued, 'Expected error'
+ else
+ raise 'I do not know how to handle this expectation'
+ end
+ end
+ end
+ end
+
+ test "Test job state changes" do
+ all = ["Queued", "Running", "Complete", "Failed", "Cancelled"]
+ valid = {"Queued" => all, "Running" => ["Complete", "Failed", "Cancelled"]}
+ all.each do |start|
+ all.each do |finish|
+ if start != finish
+ job = Job.create! job_attrs(state: start)
+ assert_equal start, job.state
+ job.state = finish
+ job.save
+ job.reload
+ if valid[start] and valid[start].include? finish
+ assert_equal finish, job.state
+ else
+ assert_equal start, job.state
end
end
end
end
end
+ test "Test job locking" do
+ set_user_from_auth :active_trustedclient
+ job = Job.create! job_attrs
+
+ assert_equal "Queued", job.state
+
+ # Should be able to lock successfully
+ job.lock current_user.uuid
+ assert_equal "Running", job.state
+
+ assert_raises ArvadosModel::AlreadyLockedError do
+ # Can't lock it again
+ job.lock current_user.uuid
+ end
+ job.reload
+ assert_equal "Running", job.state
+
+ set_user_from_auth :project_viewer
+ assert_raises ArvadosModel::AlreadyLockedError do
+ # Can't lock it as a different user either
+ job.lock current_user.uuid
+ end
+ job.reload
+ assert_equal "Running", job.state
+
+ assert_raises ArvadosModel::PermissionDeniedError do
+ # Can't update fields as a different user
+ job.update_attributes(state: "Failed")
+ end
+ job.reload
+ assert_equal "Running", job.state
+
+
+ set_user_from_auth :active_trustedclient
+
+ # Can update fields as the locked_by user
+ job.update_attributes(state: "Failed")
+ assert_equal "Failed", job.state
+ end
+
+ test "verify job queue position" do
+ job1 = Job.create! job_attrs
+ assert job1.valid?, job1.errors.full_messages.to_s
+ assert_equal 'Queued', job1.state, "Incorrect job state for newly created job1"
+
+ job2 = Job.create! job_attrs
+ assert job2.valid?, job2.errors.full_messages.to_s
+ assert_equal 'Queued', job2.state, "Incorrect job state for newly created job2"
+
+ assert_not_nil job1.queue_position, "Expected non-nil queue position for job1"
+ assert_not_nil job2.queue_position, "Expected non-nil queue position for job2"
+ assert_not_equal job1.queue_position, job2.queue_position
+ end
+
end
projects / arvados.git / blobdiff