+# Copyright (C) The Arvados Authors. All rights reserved.
+#
+# SPDX-License-Identifier: AGPL-3.0
+
require 'integration_helper'
class PipelineInstancesTest < ActionDispatch::IntegrationTest
need_javascript
end
+ def parse_browser_timestamp t
+ # Timestamps are displayed in the browser's time zone (which can
+ # differ from ours) and they come from toLocaleTimeString (which
+ # means they don't necessarily tell us which time zone they're
+ # using). In order to make sense of them, we need to ask the
+ # browser to parse them and generate a timestamp that can be
+ # parsed reliably.
+ #
+ # Note: Even with all this help, phantomjs seem to behave badly
+ # when parsing timestamps on the other side of a DST transition.
+ # See skipped tests below.
+
+ # In some locales (e.g., en_CA.UTF-8) Firefox can't parse what its
+ # own toLocaleString() puts out.
+ t.sub!(/(\d\d\d\d)-(\d\d)-(\d\d)/, '\2/\3/\1')
+
+ if /(\d+:\d+ [AP]M) (\d+\/\d+\/\d+)/ =~ t
+ # Currently dates.js renders timestamps as
+ # '{t.toLocaleTimeString()} {t.toLocaleDateString()}' which even
+ # en_US browsers can't make sense of. First we need to flip it
+ # around so it looks like what toLocaleString() would have made.
+ t = $~[2] + ', ' + $~[1]
+ end
+
+ utc = page.evaluate_script("new Date('#{t}').toUTCString()")
+ DateTime.parse(utc).to_time
+ end
+
+ if false
+ # No need to test (or mention) these all the time. If they start
+ # working (without need_selenium) then some real tests might not
+ # need_selenium any more.
+
+ test 'phantomjs DST' do
+ skip '^^'
+ t0s = '3/8/2015, 01:59 AM'
+ t1s = '3/8/2015, 03:01 AM'
+ t0 = parse_browser_timestamp t0s
+ t1 = parse_browser_timestamp t1s
+ assert_equal 120, t1-t0, "'#{t0s}' to '#{t1s}' was reported as #{t1-t0} seconds, should be 120"
+ end
+
+ test 'phantomjs DST 2' do
+ skip '^^'
+ t0s = '2015-03-08T10:43:00Z'
+ t1s = '2015-03-09T03:43:00Z'
+ t0 = parse_browser_timestamp page.evaluate_script("new Date('#{t0s}').toLocaleString()")
+ t1 = parse_browser_timestamp page.evaluate_script("new Date('#{t1s}').toLocaleString()")
+ assert_equal 17*3600, t1-t0, "'#{t0s}' to '#{t1s}' was reported as #{t1-t0} seconds, should be #{17*3600} (17 hours)"
+ end
+ end
+
test 'Create and run a pipeline' do
visit page_with_token('active_trustedclient', '/pipeline_templates')
within('tr', text: 'Two Part Pipeline Template') do
end
# project chooser
- within('.modal-dialog') do
+ within('.modal-dialog') do #FIXME: source of 1 test error
find('.selectable', text: 'A Project').click
find('button', text: 'Choose').click
end
first('span', text: 'foo_tag').click
find('.btn', text: 'Copy').click
end
- using_wait_time(Capybara.default_wait_time * 3) do
+ using_wait_time(Capybara.default_max_wait_time * 3) do
wait_for_ajax
end
- click_link 'Jobs and pipelines'
+ click_link 'Pipelines and processes'
find('tr[data-kind="arvados#pipelineInstance"]', text: '(none)').
find('a', text: 'Show').
click
page.assert_selector 'a,button', text: 'Re-run options'
# Since it is test env, no jobs are created to run. So, graph not visible
- assert_not page.has_text? 'Graph'
+ assert page.has_no_text? 'Graph'
end
# Create a pipeline instance from within a project and run
first('span', text: 'foo_tag').click
find('.btn', text: 'Copy').click
end
- using_wait_time(Capybara.default_wait_time * 3) do
+ using_wait_time(Capybara.default_max_wait_time * 3) do
wait_for_ajax
end
template_uuid = api_fixture("pipeline_templates", template_name, "uuid")
visit page_with_token("active", "/pipeline_templates/#{template_uuid}")
click_on "Run this pipeline"
- within(".modal-dialog") do
+ within(".modal-dialog") do # FIXME: source of 3 test errors
# Set project for the new pipeline instance
find(".selectable", text: project_name).click
click_on "Choose"
collection = api_fixture('collections', collection_fixture)
# create a pipeline instance
- find('.btn', text: 'Run a pipeline').click
+ find('.btn', text: 'Run a process').click
within('.modal-dialog') do
find('.selectable', text: template_name).click
find('.btn', text: 'Next: choose inputs').click
page.assert_selector 'a,button', text: 'Pause'
# Since it is test env, no jobs are created to run. So, graph not visible
- assert_not page.has_text? 'Graph'
+ assert page.has_no_text? 'Graph'
end
[
- ['zzzzz-d1hrv-10pipelines0001', 0], # run time 0 minutes
- ['zzzzz-d1hrv-10pipelines0010', 17*60*60 + 51*60], # run time 17 hours and 51 minutes
- ['zzzzz-d1hrv-10pipelines0002', nil], # state = running
- ].each do |uuid, run_time|
+ ['user1_with_load', 'zzzzz-d1hrv-10pipelines0001', 0], # run time 0 minutes
+ ['user1_with_load', 'zzzzz-d1hrv-10pipelines0010', 17*60*60 + 51*60], # run time 17 hours and 51 minutes
+ ['active', 'zzzzz-d1hrv-runningpipeline', nil], # state = running
+ ].each do |user, uuid, run_time|
test "pipeline start and finish time display for #{uuid}" do
- visit page_with_token("user1_with_load", "/pipeline_instances/#{uuid}")
+ need_selenium 'to parse timestamps correctly across DST boundaries'
+ visit page_with_token(user, "/pipeline_instances/#{uuid}")
assert page.has_text? 'This pipeline started at'
page_text = page.text
if run_time
- match = /This pipeline started at (.*)\. It failed after (.*) seconds at (.*)\. Check the Log/.match page_text
+ match = /This pipeline started at (.*)\. It failed after (.*) at (.*)\. Check the Log/.match page_text
else
match = /This pipeline started at (.*). It has been active for(.*)/.match page_text
end
start_at = match[1]
assert_not_nil(start_at, 'Did not find start_at time')
- # start and finished time display is of the format '2:20 PM 10/20/2014'
- start_time = DateTime.strptime(start_at, '%H:%M %p %m/%d/%Y').to_time
+ start_time = parse_browser_timestamp start_at
if run_time
finished_at = match[3]
assert_not_nil(finished_at, 'Did not find finished_at time')
- finished_time = DateTime.strptime(finished_at, '%H:%M %p %m/%d/%Y').to_time
+ finished_time = parse_browser_timestamp finished_at
assert_equal(run_time, finished_time-start_time,
"Time difference did not match for start_at #{start_at}, finished_at #{finished_at}, ran_for #{match[2]}")
else
end
end
end
+
+ test 'render job run time when job record is inaccessible' do
+ pi = api_fixture('pipeline_instances', 'has_component_with_completed_jobs')
+ visit page_with_token 'active', '/pipeline_instances/' + pi['uuid']
+ assert_text 'Queued for '
+ end
+
+ test "job logs linked for running pipeline" do
+ pi = api_fixture("pipeline_instances", "running_pipeline_with_complete_job")
+ visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}"))
+ find(:xpath, "//a[@href='#Log']").click
+ within "#Log" do
+ assert_text "Log for previous"
+ log_link = find("a", text: "Log for previous")
+ assert_includes(log_link[:href],
+ "/jobs/#{pi["components"]["previous"]["job"]["uuid"]}#Log")
+ assert_selector "#event_log_div"
+ end
+ end
+
+ test "job logs linked for complete pipeline" do
+ pi = api_fixture("pipeline_instances", "complete_pipeline_with_two_jobs")
+ visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}"))
+ find(:xpath, "//a[@href='#Log']").click
+ within "#Log" do
+ assert_text "Log for previous"
+ pi["components"].each do |cname, cspec|
+ log_link = find("a", text: "Log for #{cname}")
+ assert_includes(log_link[:href], "/jobs/#{cspec["job"]["uuid"]}#Log")
+ end
+ assert_no_selector "#event_log_div"
+ end
+ end
+
+ test "job logs linked for failed pipeline" do
+ pi = api_fixture("pipeline_instances", "failed_pipeline_with_two_jobs")
+ visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}"))
+ find(:xpath, "//a[@href='#Log']").click
+ within "#Log" do
+ assert_text "Log for previous"
+ pi["components"].each do |cname, cspec|
+ log_link = find("a", text: "Log for #{cname}")
+ assert_includes(log_link[:href], "/jobs/#{cspec["job"]["uuid"]}#Log")
+ end
+ assert_no_selector "#event_log_div"
+ end
+ end
end
projects / arvados.git / blobdiff