Test needs to ignore varying "acrContainerImage" field

[arvados.git] / sdk / cwl / tests / test_copy_deps.py

diff --git a/sdk/cwl/tests/test_copy_deps.py b/sdk/cwl/tests/test_copy_deps.py
index 1d8cc1219348590d0264d68eedc32f007fc6280d..54d90580f906f836fe9b31765decd23a0104fa7c 100644 (file)
--- a/sdk/cwl/tests/test_copy_deps.py
+++ b/sdk/cwl/tests/test_copy_deps.py
@@ -3,10 +3,60 @@
 # SPDX-License-Identifier: Apache-2.0
 
 import arvados
+import arvados.collection
 import subprocess
+import json
 
 api = arvados.api()
 
+workflow_content = """{
+    "$graph": [
+        {
+            "baseCommand": "echo",
+            "class": "CommandLineTool",
+            "cwlVersion": "v1.2",
+            "hints": [
+                {
+                    "class": "http://arvados.org/cwl#WorkflowRunnerResources"
+                }
+            ],
+            "id": "#main",
+            "inputs": [
+                {
+                    "default": {
+                        "basename": "b",
+                        "class": "File",
+                        "location": "keep:d7514270f356df848477718d58308cc4+94/b",
+                        "nameext": "",
+                        "nameroot": "b",
+                        "size": 0
+                    },
+                    "id": "#main/message",
+                    "inputBinding": {
+                        "position": 1
+                    },
+                    "type": "File"
+                }
+            ],
+            "outputs": []
+        }
+    ],
+    "cwlVersion": "v1.2"
+}"""
+
+def check_workflow_content(uuid):
+    c = arvados.collection.Collection(uuid)
+    try:
+        j = json.load(c.open("workflow.json"))
+    except IOError:
+        return False
+    # The value of "acrContainerImage" is tied to the specific version
+    # of arvados-cwl-runner so we can't just compare PDH of the whole
+    # workflow collection, it changes with every version.
+    del j["$graph"][0]["hints"][0]["acrContainerImage"]
+    print
+    return json.dumps(j, sort_keys=True, indent=4, separators=(',',': ')) == workflow_content
+
 def check_contents(group, wf_uuid):
     contents = api.groups().contents(uuid=group["uuid"]).execute()
     if len(contents["items"]) != 4:
@@ -35,10 +85,10 @@ def check_contents(group, wf_uuid):
 
     found = False
     for c in contents["items"]:
-        if c["kind"] == "arvados#collection" and c["portable_data_hash"] == "73b7a68c78205e793a5eb9520326d3ae+61":
+        if c["kind"] == "arvados#collection" and check_workflow_content(c["portable_data_hash"]):
             found = True
     if not found:
-        raise Exception("Couldn't find collection containing workflow")
+        raise Exception("Couldn't find collection containing expected workflow.json")
 
 
 def test_create():
@@ -84,10 +134,10 @@ def test_update():
 
         found = False
         for c in contents["items"]:
-            if c["kind"] == "arvados#collection" and c["portable_data_hash"] == "73b7a68c78205e793a5eb9520326d3ae+61":
+            if c["kind"] == "arvados#collection" and check_workflow_content(c["portable_data_hash"]):
                 found = True
         if not found:
-            raise Exception("Couldn't find collection containing workflow")
+            raise Exception("Couldn't find collection containing expected workflow.json")
 
         # Updating by default will copy missing items
         cmd = ["arvados-cwl-runner", "--disable-git", "--update-workflow", wf_uuid, "19070-copy-deps.cwl"]