require 'test_helper'
class CollectionsControllerTest < ActionController::TestCase
+ NONEXISTENT_COLLECTION = "ffffffffffffffffffffffffffffffff+0"
+
+ def stub_file_content
+ # For the duration of the current test case, stub file download
+ # content with a randomized (but recognizable) string. Return the
+ # string, the test case can use it in assertions.
+ txt = 'the quick brown fox ' + rand(2**32).to_s
+ @controller.stubs(:file_enumerator).returns([txt])
+ txt
+ end
+
def collection_params(collection_name, file_name=nil)
uuid = api_fixture('collections')[collection_name.to_s]['uuid']
params = {uuid: uuid, id: uuid}
assert_response response
end
- # Mock the collection file reader to avoid external calls and return
- # a predictable string.
- CollectionsController.class_eval do
- def file_enumerator(opts)
- [[opts[:arvados_api_token], opts[:uuid], opts[:file]].join('/')]
- end
- end
-
test "viewing a collection" do
show_collection(:foo_file, :active)
assert_equal([['.', 'foo', 3]], assigns(:object).files)
end
test "viewing a collection fetches related projects" do
- show_collection(:foo_file, :active)
- assert_includes(assigns(:projects).map(&:uuid),
+ show_collection({id: api_fixture('collections')["foo_file"]['portable_data_hash']}, :active)
+ assert_includes(assigns(:same_pdh).map(&:owner_uuid),
api_fixture('groups')['aproject']['uuid'],
"controller did not find linked project")
end
assert_no_session
end
+ test "reader token Collection links end with trailing slash" do
+ # Testing the fix for #2937.
+ session = session_for(:active_trustedclient)
+ post(:share, collection_params(:foo_file), session)
+ assert(@controller.download_link.ends_with? '/',
+ "Collection share link does not end with slash for wget")
+ end
+
test "getting a file from Keep" do
params = collection_params(:foo_file, 'foo')
sess = session_for(:active)
+ expect_content = stub_file_content
get(:show_file, params, sess)
assert_response :success
- assert_equal(expected_contents(params, sess), @response.body,
+ assert_equal(expect_content, @response.body,
"failed to get a correct file from Keep")
end
params = collection_params(:foo_file, 'foo')
read_token = api_fixture('api_client_authorizations')['active']['api_token']
params[:reader_token] = read_token
+ expect_content = stub_file_content
get(:show_file, params)
assert_response :success
- assert_equal(expected_contents(params, read_token), @response.body,
+ assert_equal(expect_content, @response.body,
"failed to get a correct file from Keep using a reader token")
assert_not_equal(read_token, session[:arvados_api_token],
"using a reader token set the session's API token")
sess = session_for(:expired)
read_token = api_fixture('api_client_authorizations')['active']['api_token']
params[:reader_token] = read_token
+ expect_content = stub_file_content
get(:show_file, params, sess)
assert_response :success
- assert_equal(expected_contents(params, read_token), @response.body,
+ assert_equal(expect_content, @response.body,
"failed to get a correct file from Keep using a reader token")
assert_not_equal(read_token, session[:arvados_api_token],
"using a reader token set the session's API token")
uuid: ua_collection['uuid'],
file: ua_collection['manifest_text'].match(/ \d+:\d+:(\S+)/)[1]
}, session_for(:inactive)
- assert_nil(assigns(:required_user_agreements),
+ assert_nil(assigns(:unsigned_user_agreements),
"Did not skip check_user_agreements filter " +
"when showing the user agreement.")
assert_response :success
end
+
+ test "requesting nonexistent Collection returns 404" do
+ show_collection({uuid: NONEXISTENT_COLLECTION, id: NONEXISTENT_COLLECTION},
+ :active, 404)
+ end
end