+# Copyright (C) The Arvados Authors. All rights reserved.
+#
+# SPDX-License-Identifier: AGPL-3.0
+
require 'integration_helper'
-require 'selenium-webdriver'
-require 'headless'
class PipelineInstancesTest < ActionDispatch::IntegrationTest
setup do
- # Selecting collections requiresLocalStorage
- headless = Headless.new
- headless.start
- Capybara.current_driver = :selenium
+ need_javascript
end
- test 'Create and run a pipeline' do
- visit page_with_token('active_trustedclient')
-
- visit '/pipeline_templates'
- within('tr', text: 'Two Part Pipeline Template') do
- find('a,button', text: 'Run').click
- end
-
- # project chooser
- within('.modal-dialog') do
- find('.selectable', text: 'A Project').click
- find('button', text: 'Choose').click
- end
-
- # This pipeline needs input. So, Run should be disabled
- page.assert_selector 'a.disabled,button.disabled', text: 'Run'
-
- instance_page = current_path
-
- # Go over to the collections page and select something
- visit '/collections'
- within('tr', text: 'GNU_General_Public_License') do
- find('input[type=checkbox]').click
- end
- find('#persistent-selection-count').click
-
- # Add this collection to the project
- visit '/projects'
- find("#projects-menu").click
- find('.dropdown-menu a,button', text: 'A Project').click
- find('.btn', text: 'Add data').click
- within('.modal-dialog') do
- wait_for_ajax
- first('span', text: 'foo_tag').click
- find('.btn', text: 'Add').click
- end
- using_wait_time(Capybara.default_wait_time * 3) do
- wait_for_ajax
- end
-
- click_link 'Jobs and pipelines'
- find('tr[data-kind="arvados#pipelineInstance"]', text: '(none)').
- find('a', text: 'Show').
- click
-
- assert find('p', text: 'Provide a value')
-
- find('div.form-group', text: 'Foo/bar pair').
- find('.btn', text: 'Choose').
- click
-
- within('.modal-dialog') do
- assert(has_text?("Foo/bar pair"),
- "pipeline input picker missing name of input")
- wait_for_ajax
- first('span', text: 'foo_tag').click
- find('button', text: 'OK').click
- end
- wait_for_ajax
-
- # "Run" button is now enabled
- page.assert_no_selector 'a.disabled,button.disabled', text: 'Run'
-
- first('a,button', text: 'Run').click
-
- # Pipeline is running. We have a "Pause" button instead now.
- page.assert_selector 'a,button', text: 'Pause'
- find('a,button', text: 'Pause').click
-
- # Pipeline is stopped. It should now be in paused state and Runnable again.
- assert page.has_text? 'Paused'
- page.assert_no_selector 'a.disabled,button.disabled', text: 'Resume'
- page.assert_selector 'a,button', text: 'Re-run with latest'
- page.assert_selector 'a,button', text: 'Re-run options'
-
- # Since it is test env, no jobs are created to run. So, graph not visible
- assert_not page.has_text? 'Graph'
- end
-
- # Create a pipeline instance from within a project and run
- test 'Create pipeline inside a project and run' do
- visit page_with_token('active_trustedclient')
-
- # Go over to the collections page and select something
- visit '/collections'
- within('tr', text: 'GNU_General_Public_License') do
- find('input[type=checkbox]').click
- end
- find('#persistent-selection-count').click
-
- # Add this collection to the project using collections menu from top nav
- visit '/projects'
- find("#projects-menu").click
- find('.dropdown-menu a,button', text: 'A Project').click
- find('.btn', text: 'Add data').click
- within('.modal-dialog') do
- wait_for_ajax
- first('span', text: 'foo_tag').click
- find('.btn', text: 'Add').click
- end
- using_wait_time(Capybara.default_wait_time * 3) do
- wait_for_ajax
- end
-
- create_and_run_pipeline_in_aproject true
- end
-
- # Create a pipeline instance from within a project and run
- test 'Run a pipeline from dashboard' do
- visit page_with_token('active_trustedclient')
- create_and_run_pipeline_in_aproject false
+ def parse_browser_timestamp t
+ # Timestamps are displayed in the browser's time zone (which can
+ # differ from ours) and they come from toLocaleTimeString (which
+ # means they don't necessarily tell us which time zone they're
+ # using). In order to make sense of them, we need to ask the
+ # browser to parse them and generate a timestamp that can be
+ # parsed reliably.
+ #
+ # Note: Even with all this help, phantomjs seem to behave badly
+ # when parsing timestamps on the other side of a DST transition.
+ # See skipped tests below.
+
+ # In some locales (e.g., en_CA.UTF-8) Firefox can't parse what its
+ # own toLocaleString() puts out.
+ t.sub!(/(\d\d\d\d)-(\d\d)-(\d\d)/, '\2/\3/\1')
+
+ if /(\d+:\d+ [AP]M) (\d+\/\d+\/\d+)/ =~ t
+ # Currently dates.js renders timestamps as
+ # '{t.toLocaleTimeString()} {t.toLocaleDateString()}' which even
+ # en_US browsers can't make sense of. First we need to flip it
+ # around so it looks like what toLocaleString() would have made.
+ t = $~[2] + ', ' + $~[1]
+ end
+
+ utc = page.evaluate_script("new Date('#{t}').toUTCString()")
+ DateTime.parse(utc).to_time
end
test 'view pipeline with job and see graph' do
- visit page_with_token('active_trustedclient')
-
- visit '/pipeline_instances'
+ visit page_with_token('active_trustedclient', '/pipeline_instances')
assert page.has_text? 'pipeline_with_job'
find('a', text: 'pipeline_with_job').click
# since the pipeline component has a job, expect to see the graph
assert page.has_text? 'Graph'
click_link 'Graph'
- assert page.has_text? 'script_version'
- end
-
- test 'pipeline description' do
- visit page_with_token('active_trustedclient')
-
- visit '/pipeline_instances'
- assert page.has_text? 'pipeline_with_job'
-
- find('a', text: 'pipeline_with_job').click
-
- within('.arv-description-as-subtitle') do
- find('.fa-pencil').click
- find('.editable-input textarea').set('*Textile description for pipeline instance*')
- find('.editable-submit').click
- end
- wait_for_ajax
-
- # verify description
- assert page.has_no_text? '*Textile description for pipeline instance*'
- assert page.has_text? 'Textile description for pipeline instance'
+ page.assert_selector "#provenance_graph"
end
test "JSON popup available for strange components" do
"components JSON not found")
end
- PROJECT_WITH_SEARCH_COLLECTION = "A Subproject"
- def check_parameter_search(proj_name)
- template = api_fixture("pipeline_templates")["parameter_with_search"]
- search_text = template["components"]["with-search"]["script_parameters"]["input"]["search_for"]
- visit page_with_token("active", "/pipeline_templates/#{template['uuid']}")
+ def create_pipeline_from(template_name, project_name="Home")
+ # Visit the named pipeline template and create a pipeline instance from it.
+ # The instance will be created under the named project.
+ template_uuid = api_fixture("pipeline_templates", template_name, "uuid")
+ visit page_with_token("active", "/pipeline_templates/#{template_uuid}")
click_on "Run this pipeline"
- within(".modal-dialog") do # Set project for the new pipeline instance
- find(".selectable", text: proj_name).click
+ within(".modal-dialog") do # FIXME: source of 3 test errors
+ # Set project for the new pipeline instance
+ find(".selectable", text: project_name).click
click_on "Choose"
end
- assert(has_text?("This pipeline was created from the template"), "did not land on pipeline instance page")
- first("a.btn,button", text: "Choose").click
- within(".modal-body") do
- if (proj_name != PROJECT_WITH_SEARCH_COLLECTION)
- # Switch finder modal to Subproject to find the Collection.
- click_on proj_name
- click_on PROJECT_WITH_SEARCH_COLLECTION
- end
- assert_equal(search_text, first("input").value,
- "parameter search not preseeded")
- assert(has_text?(api_fixture("collections")["baz_collection_name_in_asubproject"]["name"]),
- "baz Collection not in preseeded search results")
- end
- end
-
- test "Workbench respects search_for parameter in templates" do
- check_parameter_search(PROJECT_WITH_SEARCH_COLLECTION)
- end
-
- test "Workbench preserves search_for parameter after project switch" do
- check_parameter_search("A Project")
+ assert(has_text?("This pipeline was created from the template"),
+ "did not land on pipeline instance page")
end
[
- ['active', false, false, false],
- ['active', false, false, true],
- ['active', true, false, false],
- ['active', true, true, false],
- ['active', true, false, true],
- ['active', true, true, true],
- ['project_viewer', false, false, true],
- ['project_viewer', true, false, true],
- ['project_viewer', true, true, true],
- ].each do |user, with_options, choose_options, in_aproject|
- test "Rerun pipeline instance as #{user} using options #{with_options} #{choose_options} in #{in_aproject}" do
- visit page_with_token('active')
-
- if in_aproject
- find("#projects-menu").click
- find('.dropdown-menu a,button', text: 'A Project').click
+ ['user1_with_load', 'zzzzz-d1hrv-10pipelines0001', 0], # run time 0 minutes
+ ['user1_with_load', 'zzzzz-d1hrv-10pipelines0010', 17*60*60 + 51*60], # run time 17 hours and 51 minutes
+ ['active', 'zzzzz-d1hrv-runningpipeline', nil], # state = running
+ ].each do |user, uuid, run_time|
+ test "pipeline start and finish time display for #{uuid}" do
+ need_selenium 'to parse timestamps correctly across DST boundaries'
+ visit page_with_token(user, "/pipeline_instances/#{uuid}")
+
+ regexp = "This pipeline started at (.+?)\\. "
+ if run_time
+ regexp += "It failed after (.+?) at (.+?)\\. Check the Log"
+ else
+ regexp += "It has been active for \\d"
end
+ assert_match /#{regexp}/, page.text
- create_and_run_pipeline_in_aproject in_aproject
- instance_path = current_path
+ return if !run_time
- # Pause the pipeline
- find('a,button', text: 'Pause').click
- assert page.has_text? 'Paused'
- page.assert_no_selector 'a.disabled,button.disabled', text: 'Resume'
- page.assert_selector 'a,button', text: 'Re-run with latest'
- page.assert_selector 'a,button', text: 'Re-run options'
+ # match again to capture (.*)
+ _, started, duration, finished = *(/#{regexp}/.match(page.text))
+ assert_equal(
+ run_time,
+ parse_browser_timestamp(finished) - parse_browser_timestamp(started),
+ "expected: #{run_time}, got: started #{started}, finished #{finished}, duration #{duration}")
+ end
+ end
- # Pipeline can be re-run now. Access it as the specified user, and re-run
- if user == 'project_viewer'
- visit page_with_token(user, instance_path)
- assert page.has_text? 'A Project'
- page.assert_no_selector 'a.disabled,button.disabled', text: 'Resume'
- page.assert_selector 'a,button', text: 'Re-run with latest'
- page.assert_selector 'a,button', text: 'Re-run options'
+ [
+ ['fuse', nil, 2, 20], # has 2 as of 11-07-2014
+ ['user1_with_load', '000025pipelines', 25, 25], # owned_by the project zzzzz-j7d0g-000025pipelines, two pages
+ ['admin', 'pipeline_20', 1, 1],
+ ['active', 'no such match', 0, 0],
+ ].each do |user, search_filter, expected_min, expected_max|
+ test "scroll pipeline instances page for #{user} with search filter #{search_filter}
+ and expect #{expected_min} <= found_items <= #{expected_max}" do
+ visit page_with_token(user, "/pipeline_instances")
+
+ if search_filter
+ find('.recent-pipeline-instances-filterable-control').set(search_filter)
+ # Wait for 250ms debounce timer (see filterable.js)
+ sleep 0.350
+ wait_for_ajax
end
- # Now re-run the pipeline
- if with_options
- find('a,button', text: 'Re-run options').click
- within('.modal-dialog') do
- page.assert_selector 'a,button', text: 'Copy and edit inputs'
- page.assert_selector 'a,button', text: 'Run now'
- if choose_options
- find('button', text: 'Copy and edit inputs').click
- else
- find('button', text: 'Run now').click
+ page_scrolls = expected_max/20 + 2 # scroll num_pages+2 times to test scrolling is disabled when it should be
+ within('.arv-recent-pipeline-instances') do
+ (0..page_scrolls).each do |i|
+ page.driver.scroll_to 0, 999000
+ begin
+ wait_for_ajax
+ rescue
end
end
- else
- find('a,button', text: 'Re-run with latest').click
end
- # Verify that the newly created instance is created in the right project.
- # In case of project_viewer user, since the use cannot write to the project,
- # the pipeline should have been created in the user's Home project.
- rerun_instance_path = current_path
- assert_not_equal instance_path, rerun_instance_path, 'Rerun instance path expected to be different'
- assert page.has_text? 'Home'
- if in_aproject && (user != 'project_viewer')
- assert page.has_text? 'A Project'
+ # Verify that expected number of pipeline instances are found
+ found_items = page.all('tr[data-kind="arvados#pipelineInstance"]')
+ found_count = found_items.count
+ if expected_min == expected_max
+ assert_equal(true, found_count == expected_min,
+ "Not found expected number of items. Expected #{expected_min} and found #{found_count}")
+ assert page.has_no_text? 'request failed'
else
- assert page.has_no_text? 'A Project'
+ assert_equal(true, found_count>=expected_min,
+ "Found too few items. Expected at least #{expected_min} and found #{found_count}")
+ assert_equal(true, found_count<=expected_max,
+ "Found too many items. Expected at most #{expected_max} and found #{found_count}")
end
end
end
- # Create and run a pipeline for 'Two Part Pipeline Template' in 'A Project'
- def create_and_run_pipeline_in_aproject in_aproject
- # create a pipeline instance
- find('.btn', text: 'Run a pipeline').click
- within('.modal-dialog') do
- find('.selectable', text: 'Two Part Pipeline Template').click
- find('.btn', text: 'Next: choose inputs').click
- end
-
- assert find('p', text: 'Provide a value')
+ test 'render job run time when job record is inaccessible' do
+ pi = api_fixture('pipeline_instances', 'has_component_with_completed_jobs')
+ visit page_with_token 'active', '/pipeline_instances/' + pi['uuid']
+ assert_text 'Queued for '
+ end
- find('div.form-group', text: 'Foo/bar pair').
- find('.btn', text: 'Choose').
- click
+ test "job logs linked for running pipeline" do
+ pi = api_fixture("pipeline_instances", "running_pipeline_with_complete_job")
+ visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}"))
+ find(:xpath, "//a[@href='#Log']").click
+ within "#Log" do
+ assert_text "Log for previous"
+ log_link = find("a", text: "Log for previous")
+ assert_includes(log_link[:href],
+ "/jobs/#{pi["components"]["previous"]["job"]["uuid"]}#Log")
+ assert_selector "#event_log_div"
+ end
+ end
- within('.modal-dialog') do
- if in_aproject
- assert_selector 'button.dropdown-toggle', text: 'A Project'
- wait_for_ajax
- else
- assert_selector 'button.dropdown-toggle', text: 'Home'
- wait_for_ajax
- click_button "Home"
- click_link "A Project"
- wait_for_ajax
+ test "job logs linked for complete pipeline" do
+ pi = api_fixture("pipeline_instances", "complete_pipeline_with_two_jobs")
+ visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}"))
+ find(:xpath, "//a[@href='#Log']").click
+ within "#Log" do
+ assert_text "Log for previous"
+ pi["components"].each do |cname, cspec|
+ log_link = find("a", text: "Log for #{cname}")
+ assert_includes(log_link[:href], "/jobs/#{cspec["job"]["uuid"]}#Log")
end
- first('span', text: 'foo_tag').click
- find('button', text: 'OK').click
+ assert_no_selector "#event_log_div"
end
- wait_for_ajax
-
- # "Run" button present and enabled
- page.assert_no_selector 'a.disabled,button.disabled', text: 'Run'
- first('a,button', text: 'Run').click
-
- # Pipeline is running. We have a "Pause" button instead now.
- page.assert_no_selector 'a,button', text: 'Run'
- page.assert_no_selector 'a.disabled,button.disabled', text: 'Resume'
- page.assert_selector 'a,button', text: 'Pause'
-
- # Since it is test env, no jobs are created to run. So, graph not visible
- assert_not page.has_text? 'Graph'
end
- [
- [0, 0], # run time 0 minutes
- [9, 17*60*60 + 51*60], # run time 17 hours and 51 minutes
- ].each do |index, run_time|
- test "pipeline start and finish time display #{index}" do
- visit page_with_token("user1_with_load", "/pipeline_instances/zzzzz-d1hrv-10pipelines0#{index.to_s.rjust(3, '0')}")
-
- assert page.has_text? 'This pipeline started at'
- page_text = page.text
-
- match = /This pipeline started at (.*)\. It failed after (.*) seconds at (.*)\. Check the Log/.match page_text
- assert_not_nil(match, 'Did not find text - This pipeline started at . . . ')
-
- start_at = match[1]
- finished_at = match[3]
- assert_not_nil(start_at, 'Did not find start_at time')
- assert_not_nil(finished_at, 'Did not find finished_at time')
-
- # start and finished time display is of the format '2:20 PM 10/20/2014'
- start_time = DateTime.strptime(start_at, '%H:%M %p %m/%d/%Y').to_time
- finished_time = DateTime.strptime(finished_at, '%H:%M %p %m/%d/%Y').to_time
- assert_equal(run_time, finished_time-start_time,
- "Time difference did not match for start_at #{start_at}, finished_at #{finished_at}, ran_for #{match[2]}")
+ test "job logs linked for failed pipeline" do
+ pi = api_fixture("pipeline_instances", "failed_pipeline_with_two_jobs")
+ visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}"))
+ find(:xpath, "//a[@href='#Log']").click
+ within "#Log" do
+ assert_text "Log for previous"
+ pi["components"].each do |cname, cspec|
+ log_link = find("a", text: "Log for #{cname}")
+ assert_includes(log_link[:href], "/jobs/#{cspec["job"]["uuid"]}#Log")
+ end
+ assert_no_selector "#event_log_div"
end
end
end