validates :command, :container_image, :output_path, :cwd, :presence => true
validate :validate_state_change
validate :validate_change
+ validate :validate_runtime_constraints
after_save :update_priority
before_create :set_requesting_container_uuid
api_accessible :user, extend: :common do |t|
t.add :command
+ t.add :container_count
t.add :container_count_max
t.add :container_image
t.add :container_uuid
%w(modified_by_client_uuid container_uuid requesting_container_uuid)
end
+ # Finalize the container request after the container has
+ # finished/cancelled.
def container_completed!
- # may implement retry logic here in the future.
- self.state = ContainerRequest::Final
- self.save!
+ update_attributes!(state: ContainerRequest::Final)
+ c = Container.find_by_uuid(container_uuid)
+ ['output', 'log'].each do |out_type|
+ pdh = c.send(out_type)
+ next if pdh.nil?
+ manifest = Collection.where(portable_data_hash: pdh).first.manifest_text
+ Collection.create!(owner_uuid: owner_uuid,
+ manifest_text: manifest,
+ portable_data_hash: pdh,
+ name: "Container #{out_type} for request #{uuid}",
+ properties: {
+ 'type' => out_type,
+ 'container_request' => uuid,
+ })
+ end
end
protected
self.runtime_constraints ||= {}
self.mounts ||= {}
self.cwd ||= "."
+ self.container_count_max ||= Rails.configuration.container_count_max
end
# Create a new container (or find an existing one) to satisfy this
# request.
def resolve
- # TODO: resolve container_image to a content address.
c_mounts = mounts_for_container
c_runtime_constraints = runtime_constraints_for_container
+ c_container_image = container_image_for_container
c = act_as_system_user do
- Container.create!(command: self.command,
- container_image: self.container_image,
- cwd: self.cwd,
- environment: self.environment,
- mounts: c_mounts,
- output_path: self.output_path,
- runtime_constraints: c_runtime_constraints)
+ c_attrs = {command: self.command,
+ cwd: self.cwd,
+ environment: self.environment,
+ output_path: self.output_path,
+ container_image: c_container_image,
+ mounts: c_mounts,
+ runtime_constraints: c_runtime_constraints}
+ reusable = Container.find_reusable(c_attrs)
+ if not reusable.nil?
+ reusable
+ else
+ Container.create!(c_attrs)
+ end
end
self.container_uuid = c.uuid
end
select(:portable_data_hash).
first
if !c
- raise ActiveRecord::RecordNotFound.new "cannot mount collection #{uuid.inspect}: not found"
+ raise ArvadosModel::UnresolvableContainerError.new "cannot mount collection #{uuid.inspect}: not found"
end
if mount['portable_data_hash'].nil?
# PDH not supplied by client
return c_mounts
end
+ # Return a container_image PDH suitable for a Container.
+ def container_image_for_container
+ coll = Collection.for_latest_docker_image(container_image)
+ if !coll
+ raise ArvadosModel::UnresolvableContainerError.new "docker image #{container_image.inspect} not found"
+ end
+ return coll.portable_data_hash
+ end
+
def set_container
if (container_uuid_changed? and
not current_user.andand.is_admin and
if state_changed? and state == Committed and container_uuid.nil?
resolve
end
+ if self.container_uuid != self.container_uuid_was
+ if self.container_count_changed?
+ errors.add :container_count, "cannot be updated directly."
+ return false
+ else
+ self.container_count += 1
+ end
+ end
+ end
+
+ def validate_runtime_constraints
+ case self.state
+ when Committed
+ ['vcpus', 'ram'].each do |k|
+ if not (runtime_constraints.include? k and
+ runtime_constraints[k].is_a? Integer and
+ runtime_constraints[k] > 0)
+ errors.add :runtime_constraints, "#{k} must be a positive integer"
+ end
+ end
+ end
end
def validate_change
end
# Can update priority, container count, name and description
- permitted.push :priority, :container_count_max, :container_uuid, :name, :description
+ permitted.push :priority, :container_count, :container_count_max, :container_uuid, :name, :description
if self.state_changed?
# Allow create-and-commit in a single operation.
end
def set_requesting_container_uuid
- return true if self.requesting_container_uuid # already set
+ return !new_record? if self.requesting_container_uuid # already set
token_uuid = current_api_client_authorization.andand.uuid
container = Container.where('auth_uuid=?', token_uuid).order('created_at desc').first