package main
import (
- "crypto/tls"
+ "bytes"
+ "errors"
"git.curoverse.com/arvados.git/sdk/go/arvadosclient"
"git.curoverse.com/arvados.git/sdk/go/arvadostest"
"git.curoverse.com/arvados.git/sdk/go/keepclient"
+ "io"
"net/http"
"os"
+ "strings"
"testing"
)
-type PullWorkIntegrationTestData struct {
- Name string
- Locator string
- Content string
-}
-
-func TestPullWorkerIntegration_GetLocator(t *testing.T) {
- arvadostest.StartAPI()
- arvadostest.StartKeep()
+var keepClient *keepclient.KeepClient
- testData := PullWorkIntegrationTestData{
- Name: "TestPullWorkerIntegration_GetLocator",
- Locator: "5d41402abc4b2a76b9719d911017c592",
- Content: "hello",
- }
-
- performPullWorkerIntegrationTest(testData, t)
+type PullWorkIntegrationTestData struct {
+ Name string
+ Locator string
+ Content string
+ GetError string
}
-func performPullWorkerIntegrationTest(testData PullWorkIntegrationTestData, t *testing.T) {
+func SetupPullWorkerIntegrationTest(t *testing.T, testData PullWorkIntegrationTestData, wantData bool) PullRequest {
os.Setenv("ARVADOS_API_HOST_INSECURE", "true")
- PermissionSecret = []byte("abc123")
+ // start api and keep servers
+ arvadostest.StartAPI()
+ arvadostest.StartKeep(2, false)
+ // make arvadosclient
arv, err := arvadosclient.MakeArvadosClient()
if err != nil {
t.Error("Error creating arv")
}
- client := &http.Client{Transport: &http.Transport{
- TLSClientConfig: &tls.Config{InsecureSkipVerify: true}}}
-
- keepClient := keepclient.KeepClient{
- Arvados: &arv,
- Want_replicas: 2,
- Using_proxy: true,
- Client: client,
+ // keep client
+ keepClient = &keepclient.KeepClient{
+ Arvados: arv,
+ Want_replicas: 1,
+ Client: &http.Client{},
}
- random_token := GenerateRandomApiToken()
- keepClient.Arvados.ApiToken = random_token
-
- if err != nil {
- t.Error("Error creating keepclient")
+ // discover keep services
+ var servers []string
+ if err := keepClient.DiscoverKeepServers(); err != nil {
+ t.Error("Error discovering keep services")
+ }
+ for _, host := range keepClient.LocalRoots() {
+ servers = append(servers, host)
}
- pullq = NewWorkQueue()
- go RunPullWorker(pullq, keepClient)
+ // Put content if the test needs it
+ if wantData {
+ locator, _, err := keepClient.PutB([]byte(testData.Content))
+ if err != nil {
+ t.Errorf("Error putting test data in setup for %s %s %v", testData.Content, locator, err)
+ }
+ if locator == "" {
+ t.Errorf("No locator found after putting test data")
+ }
+ }
- servers := make([]string, 1)
- servers[0] = "https://" + os.Getenv("ARVADOS_API_HOST") + "/arvados/v1/keep_services"
+ // Create pullRequest for the test
pullRequest := PullRequest{
Locator: testData.Locator,
Servers: servers,
}
+ return pullRequest
+}
+
+// Do a get on a block that is not existing in any of the keep servers.
+// Expect "block not found" error.
+func TestPullWorkerIntegration_GetNonExistingLocator(t *testing.T) {
+ testData := PullWorkIntegrationTestData{
+ Name: "TestPullWorkerIntegration_GetLocator",
+ Locator: "5d41402abc4b2a76b9719d911017c592",
+ Content: "hello",
+ GetError: "Block not found",
+ }
+
+ pullRequest := SetupPullWorkerIntegrationTest(t, testData, false)
+ defer arvadostest.StopAPI()
+ defer arvadostest.StopKeep(2)
- PullItemAndProcess(pullRequest, random_token, keepClient)
+ performPullWorkerIntegrationTest(testData, pullRequest, t)
+}
+
+// Do a get on a block that exists on one of the keep servers.
+// The setup method will create this block before doing the get.
+func TestPullWorkerIntegration_GetExistingLocator(t *testing.T) {
+ testData := PullWorkIntegrationTestData{
+ Name: "TestPullWorkerIntegration_GetLocator",
+ Locator: "5d41402abc4b2a76b9719d911017c592",
+ Content: "hello",
+ GetError: "",
+ }
+
+ pullRequest := SetupPullWorkerIntegrationTest(t, testData, true)
+ defer arvadostest.StopAPI()
+ defer arvadostest.StopKeep(2)
+
+ performPullWorkerIntegrationTest(testData, pullRequest, t)
+}
+
+// Perform the test.
+// The test directly invokes the "PullItemAndProcess" rather than
+// putting an item on the pullq so that the errors can be verified.
+func performPullWorkerIntegrationTest(testData PullWorkIntegrationTestData, pullRequest PullRequest, t *testing.T) {
// Override PutContent to mock PutBlock functionality
+ defer func(orig func([]byte, string) error) { PutContent = orig }(PutContent)
PutContent = func(content []byte, locator string) (err error) {
- // do nothing
+ if string(content) != testData.Content {
+ t.Errorf("PutContent invoked with unexpected data. Expected: %s; Found: %s", testData.Content, content)
+ }
return
}
- pullq.Close()
- pullq = nil
+ // Override GetContent to mock keepclient Get functionality
+ defer func(orig func(string, *keepclient.KeepClient) (io.ReadCloser, int64, string, error)) {
+ GetContent = orig
+ }(GetContent)
+ GetContent = func(signedLocator string, keepClient *keepclient.KeepClient) (
+ reader io.ReadCloser, contentLength int64, url string, err error) {
+ if testData.GetError != "" {
+ return nil, 0, "", errors.New(testData.GetError)
+ }
+ rdr := &ClosingBuffer{bytes.NewBufferString(testData.Content)}
+ return rdr, int64(len(testData.Content)), "", nil
+ }
+
+ keepClient.Arvados.ApiToken = GenerateRandomAPIToken()
+ err := PullItemAndProcess(pullRequest, keepClient.Arvados.ApiToken, keepClient)
+
+ if len(testData.GetError) > 0 {
+ if (err == nil) || (!strings.Contains(err.Error(), testData.GetError)) {
+ t.Errorf("Got error %v, expected %v", err, testData.GetError)
+ }
+ } else {
+ if err != nil {
+ t.Errorf("Got error %v, expected nil", err)
+ }
+ }
}
projects / arvados.git / blobdiff