Fix progress bars on pipeline_instances#show

[arvados.git] / apps / workbench / app / helpers / pipeline_instances_helper.rb

diff --git a/apps/workbench/app/helpers/pipeline_instances_helper.rb b/apps/workbench/app/helpers/pipeline_instances_helper.rb
index c792db8512e05e4c4f9e588827079040671e6cb8..348004620e6747f3466fb33d6e1a5a089477af09 100644 (file)
--- a/apps/workbench/app/helpers/pipeline_instances_helper.rb
+++ b/apps/workbench/app/helpers/pipeline_instances_helper.rb
@@ -1,18 +1,63 @@
 module PipelineInstancesHelper
-  def pipeline_jobs
-    if @object.components[:steps].is_a? Array
-      pipeline_jobs_oldschool
-    elsif @object.components.is_a? Hash
-      pipeline_jobs_newschool
+  def pipeline_summary object=nil
+    object ||= @object
+    ret = {todo:0, running:0, queued:0, done:0, failed:0, total:0}
+    object.components.values.each do |c|
+      ret[:total] += 1
+      case
+      when !c[:job]
+        ret[:todo] += 1
+      when c[:job][:success]
+        ret[:done] += 1
+      when c[:job][:failed]
+        ret[:failed] += 1
+      when c[:job][:finished_at]
+        ret[:running] += 1      # XXX finished but !success and !failed??
+      when c[:job][:started_at]
+        ret[:running] += 1
+      else
+        ret[:queued] += 1
+      end
+    end
+    ret.merge! Hash[ret.collect do |k,v|
+                      [('percent_' + k.to_s).to_sym,
+                       ret[:total]<1 ? 0 : (100.0*v/ret[:total]).floor]
+                    end]
+    ret
+  end
+
+  def pipeline_jobs object=nil
+    object ||= @object
+    if object.components[:steps].is_a? Array
+      pipeline_jobs_oldschool object
+    elsif object.components.is_a? Hash
+      pipeline_jobs_newschool object
+    end
+  end
+
+  def render_pipeline_jobs
+    pipeline_jobs.collect do |pj|
+      render_pipeline_job pj
+    end
+  end
+
+  def render_pipeline_job pj
+    if pj[:percent_done]
+      pj[:progress_bar] = raw("<div class=\"progress\" style=\"width:100px\"><span class=\"progress-bar progress-bar-success\" style=\"width:#{pj[:percent_done]}%\"></span><span class=\"progress-bar\" style=\"width:#{pj[:percent_running]}%\"></span></div>")
+    elsif pj[:progress]
+      raw("<div class=\"progress\" style=\"width:100px\"><span class=\"progress-bar\" style=\"width:#{pj[:progress]*100}%\"></span></div>")
     end
+    pj[:output_link] = link_to_if_arvados_object pj[:output]
+    pj[:job_link] = link_to_if_arvados_object pj[:job][:uuid]
+    pj
   end
 
   protected
 
-  def pipeline_jobs_newschool
+  def pipeline_jobs_newschool object
     ret = []
     i = -1
-    @object.components.each do |cname, c|
+    object.components.each do |cname, c|
       i += 1
       pj = {index: i, name: cname}
       pj[:job] = c[:job].is_a?(Hash) ? c[:job] : {}
@@ -43,35 +88,34 @@ module PipelineInstancesHelper
           pj[:progress] = 0.0
         end
       end
-      if pj[:job]
-        if pj[:job][:success]
-          pj[:result] = 'complete'
-          pj[:complete] = true
-          pj[:progress] = 1.0
-        elsif pj[:job][:finished_at]
-          pj[:result] = 'failed'
-          pj[:failed] = true
-        elsif pj[:job][:started_at]
-          pj[:result] = 'running'
-        else
-          pj[:result] = 'queued'
-        end
+      if pj[:job][:success]
+        pj[:result] = 'complete'
+        pj[:complete] = true
+        pj[:progress] = 1.0
+      elsif pj[:job][:finished_at]
+        pj[:result] = 'failed'
+        pj[:failed] = true
+      elsif pj[:job][:started_at]
+        pj[:result] = 'running'
+      elsif pj[:job][:uuid]
+        pj[:result] = 'queued'
+      else
+        pj[:result] = 'none'
       end
       pj[:job_id] = pj[:job][:uuid]
-      pj[:job_link] = link_to_if_arvados_object pj[:job][:uuid]
-      pj[:script_version] = pj[:job][:script_version]
+      pj[:script] = pj[:job][:script] || c[:script]
+      pj[:script_parameters] = pj[:job][:script_parameters] || c[:script_parameters]
+      pj[:script_version] = pj[:job][:script_version] || c[:script_version]
       pj[:output] = pj[:job][:output]
       pj[:finished_at] = (Time.parse(pj[:job][:finished_at]) rescue nil)
-      pj[:progress_bar] = raw("<div class=\"progress\" style=\"width:100px\"><div class=\"bar bar-success\" style=\"width:#{pj[:percent_done]}%\"></div><div class=\"bar\" style=\"width:#{pj[:percent_running]}%\"></div></div>")
-      pj[:output_link] = link_to_if_arvados_object pj[:output]
       ret << pj
     end
     ret
   end
 
-  def pipeline_jobs_oldschool
+  def pipeline_jobs_oldschool object
     ret = []
-    @object.components[:steps].each_with_index do |step, i|
+    object.components[:steps].each_with_index do |step, i|
       pj = {index: i, name: step[:name]}
       if step[:complete] and step[:complete] != 0
         if step[:output_data_locator]
@@ -112,8 +156,6 @@ module PipelineInstancesHelper
       pj[:script_version] = (step[:warehousejob][:revision] rescue nil)
       pj[:output] = step[:output_data_locator]
       pj[:finished_at] = (Time.parse(step[:warehousejob][:finishtime]) rescue nil)
-      pj[:progress_bar] = raw("<div class=\"progress\" style=\"width:100px\"><div class=\"bar\" style=\"width:#{pj[:progress]*100}%\"></div></div>")
-      pj[:output_link] = link_to_if_arvados_object pj[:output]
       ret << pj
     end
     ret