post :setup, {
repo_name: repo_name,
- vm_uuid: 'no_such_vm',
+ openid_prefix: 'https://www.google.com/accounts/o8/id',
user: {
uuid: "this_is_agreeable",
first_name: "in_create_test_first_name",
nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
end
- test "create user with bogus uuid, vm and repo as input" do
+ test "setup user with bogus uuid and expect error" do
authorize_with :admin
post :setup, {
- uuid: 'not_an_existing_uuid_and_not_email_format',
+ uuid: 'bogus_uuid',
repo_name: 'test_repo',
- vm_uuid: 'no_such_vm'
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
}
response_body = JSON.parse(@response.body)
response_errors = response_body['errors']
assert (response_errors.first.include? 'Path not found'), 'Expected 404'
end
- test "create user with existing uuid, vm and repo and verify links" do
+ test "setup user with bogus uuid in user and expect error" do
+ authorize_with :admin
+
+ post :setup, {
+ user: {uuid: 'bogus_uuid'},
+ repo_name: 'test_repo',
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+ response_body = JSON.parse(@response.body)
+ response_errors = response_body['errors']
+ assert_not_nil response_errors, 'Expected error in response'
+ assert (response_errors.first.include? 'RuntimeError: No email found'),
+ 'Expected RuntimeError'
+ end
+
+ test "setup user with no uuid and user, expect error" do
+ authorize_with :admin
+
+ post :setup, {
+ #uuid: 'not_an_existing_uuid_and_not_email_format',
+ repo_name: 'test_repo',
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+ response_body = JSON.parse(@response.body)
+ response_errors = response_body['errors']
+ assert_not_nil response_errors, 'Expected error in response'
+ assert (response_errors.first.include? 'Required uuid or email'),
+ 'Expected ArgumentError'
+ end
+
+ test "setup user with no uuid and email, expect error" do
+ authorize_with :admin
+
+ post :setup, {
+ user: {},
+ repo_name: 'test_repo',
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+ response_body = JSON.parse(@response.body)
+ response_errors = response_body['errors']
+ assert_not_nil response_errors, 'Expected error in response'
+ assert (response_errors.first.include? '<RuntimeError: No email found'),
+ 'Expected RuntimeError'
+ end
+
+ test "invoke setup with existing uuid, vm and repo and verify links" do
+ authorize_with :inactive
+ get :current
+ assert_response :success
+ inactive_user = JSON.parse(@response.body)
+
+ authorize_with :admin
+
+ post :setup, {
+ uuid: inactive_user['uuid'],
+ repo_name: 'test_repo',
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ resp_obj = response_items['user']
+
+ assert_not_nil resp_obj['uuid'], 'expected uuid for the new user'
+ assert_equal inactive_user['uuid'], resp_obj['uuid']
+ assert_equal inactive_user['email'], resp_obj['email'],
+ 'expecting inactive user email'
+
+ # expect repo and vm links
+ verify_link response_items, 'repo_perm', true, 'permission', 'can_write',
+ 'test_repo', resp_obj['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'vm_login_perm', true, 'permission', 'can_login',
+ @vm_uuid, resp_obj['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+ end
+
+ test "invoke setup with existing uuid in user, verify response" do
authorize_with :inactive
get :current
assert_response :success
post :setup, {
user: {uuid: inactive_user['uuid']},
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ resp_obj = response_items['user']
+
+ assert_not_nil resp_obj['uuid'], 'expected uuid for the new user'
+ assert_equal inactive_user['uuid'], resp_obj['uuid']
+ assert_equal inactive_user['email'], resp_obj['email'],
+ 'expecting inactive user email'
+ end
+
+ test "invoke setup with existing uuid but different email, expect original email" do
+ authorize_with :inactive
+ get :current
+ assert_response :success
+ inactive_user = JSON.parse(@response.body)
+
+ authorize_with :admin
+
+ post :setup, {
+ uuid: inactive_user['uuid'],
+ user: {email: 'junk_email'},
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ resp_obj = response_items['user']
+
+ assert_not_nil resp_obj['uuid'], 'expected uuid for the new user'
+ assert_equal inactive_user['uuid'], resp_obj['uuid']
+ assert_equal inactive_user['email'], resp_obj['email'],
+ 'expecting inactive user email'
+ end
+
+ test "setup user with valid email and repo as input" do
+ authorize_with :admin
+
+ post :setup, {
repo_name: 'test_repo',
- vm_uuid: @vm_uuid
+ user: {email: 'abc@xyz.com'},
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
}
assert_response :success
response_object = JSON.parse(@response.body)['items']['user']
assert_not_nil response_object['uuid'], 'expected uuid for the new user'
- assert_equal inactive_user['uuid'], response_object['uuid']
- assert_equal inactive_user['email'], response_object['email'],
- 'expecting inactive user email'
+ assert_equal response_object['email'], 'abc@xyz.com', 'expected given email'
- # since it is an existing user, expect only 2 new links: repo and vm
- verify_num_links @all_links_at_start, 2
+ # three extra links; login link, group link and repo link
+ verify_num_links @all_links_at_start, 3
end
- test "create user with valid email, vm and repo as input" do
+ test "setup user with fake vm and expect error" do
authorize_with :admin
post :setup, {
repo_name: 'test_repo',
vm_uuid: 'no_such_vm',
+ user: {email: 'abc@xyz.com'},
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
+ }
+
+ response_body = JSON.parse(@response.body)
+ response_errors = response_body['errors']
+ assert_not_nil response_errors, 'Expected error in response'
+ assert (response_errors.first.include? "No vm found for no_such_vm"),
+ 'Expected RuntimeError: No vm found for no_such_vm'
+ end
+
+ test "setup user with valid email, repo and real vm as input" do
+ authorize_with :admin
+
+ post :setup, {
+ repo_name: 'test_repo',
+ openid_prefix: 'https://www.google.com/accounts/o8/id',
+ vm_uuid: @vm_uuid,
user: {email: 'abc@xyz.com'}
}
assert_equal response_object['email'], 'abc@xyz.com', 'expected given email'
# three extra links; login link, group link and repo link
- verify_num_links @all_links_at_start, 3
+ verify_num_links @all_links_at_start, 4
end
- test "create user with valid email, no vm and repo as input" do
+ test "setup user with valid email, no vm and repo as input" do
authorize_with :admin
post :setup, {
- user: {email: 'abc@xyz.com'}
+ user: {email: 'abc@xyz.com'},
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
}
assert_response :success
verify_num_links @all_links_at_start, 2
end
- test "create user with email, first name, repo name and vm uuid" do
+ test "setup user with email, first name, repo name and vm uuid" do
authorize_with :admin
post :setup, {
+ openid_prefix: 'https://www.google.com/accounts/o8/id',
repo_name: 'test_repo',
vm_uuid: @vm_uuid,
user: {
verify_num_links @all_links_at_start, 4
end
- test "create user twice with email and check two different objects created" do
+ test "setup user twice with email and check two different objects created" do
authorize_with :admin
post :setup, {
+ openid_prefix: 'https://www.google.com/accounts/o8/id',
repo_name: 'test_repo',
user: {
email: 'abc@xyz.com'
verify_num_links @all_links_at_start, 3 # openid, group, and repo. no vm
# create again
- post :setup, user: {
- email: 'abc@xyz.com'
+ post :setup, {
+ user: {email: 'abc@xyz.com'},
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
}
assert_response :success
verify_num_links @all_links_at_start, 4
end
- test "create user with openid prefix" do
+ test "setup user with openid prefix" do
authorize_with :admin
post :setup, {
repo_name: 'test_repo',
- vm_uuid: 'no_such_vm',
openid_prefix: 'http://www.xyz.com/account',
user: {
first_name: "in_create_test_first_name",
verify_link response_items, 'group_perm', true, 'permission', 'can_read',
'All users', created['uuid'], 'arvados#group', true, 'Group'
- verify_link response_items, 'vm_login_perm', false, 'permission', 'can_read',
+ verify_link response_items, 'vm_login_perm', false, 'permission', 'can_login',
nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
end
- test "create user with user, vm and repo and verify links" do
+ test "invoke setup with no openid prefix, expect error" do
+ authorize_with :admin
+
+ post :setup, {
+ repo_name: 'test_repo',
+ user: {
+ first_name: "in_create_test_first_name",
+ last_name: "test_last_name",
+ email: "test@abc.com"
+ }
+ }
+
+ response_body = JSON.parse(@response.body)
+ response_errors = response_body['errors']
+ assert_not_nil response_errors, 'Expected error in response'
+ assert (response_errors.first.include? 'openid_prefix parameter is missing'),
+ 'Expected ArgumentError'
+ end
+
+ test "setup user with user, vm and repo and verify links" do
authorize_with :admin
post :setup, {
last_name: "test_last_name",
email: "test@abc.com"
},
+ vm_uuid: @vm_uuid,
repo_name: 'test_repo',
- vm_uuid: @vm_uuid
+ openid_prefix: 'https://www.google.com/accounts/o8/id'
}
assert_response :success
@vm_uuid, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
end
- test "try to create user as non admin user" do
+ test "create user as non admin user and expect error" do
authorize_with :active
post :create, {
'Expected PermissionDeniedError'
end
- test "try to setup user as non admin user" do
+ test "setup user as non admin user and expect error" do
authorize_with :active
post :setup, {
+ openid_prefix: 'https://www.google.com/accounts/o8/id',
user: {email: 'abc@xyz.com'}
}
'Expected PermissionDeniedError'
end
+ test "setup user in multiple steps and verify response" do
+ authorize_with :admin
+
+ post :setup, {
+ openid_prefix: 'http://www.xyz.com/account',
+ user: {
+ email: "test@abc.com"
+ }
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ created = response_items['user']
+
+ assert_not_nil created['uuid'], 'expected uuid for new user'
+ assert_not_nil created['email'], 'expected non-nil email'
+ assert_equal created['email'], 'test@abc.com', 'expected input email'
+
+ # verify links; 2 new links: oid_login_perm, and 'All users' group.
+ verify_num_links @all_links_at_start, 2
+
+ verify_link response_items, 'oid_login_perm', true, 'permission', 'can_login',
+ created['uuid'], created['email'], 'arvados#user', false, 'User'
+
+ verify_link response_items, 'group_perm', true, 'permission', 'can_read',
+ 'All users', created['uuid'], 'arvados#group', true, 'Group'
+
+ verify_link response_items, 'repo_perm', false, 'permission', 'can_write',
+ 'test_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'vm_login_perm', false, 'permission', 'can_login',
+ nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+
+ # invoke setup with a repository
+ post :setup, {
+ openid_prefix: 'http://www.xyz.com/account',
+ repo_name: 'new_repo',
+ uuid: created['uuid']
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ created = response_items['user']
+
+ assert_equal 'test@abc.com', created['email'], 'expected input email'
+
+ # verify links
+ verify_link response_items, 'oid_login_perm', true, 'permission', 'can_login',
+ created['uuid'], created['email'], 'arvados#user', false, 'User'
+
+ verify_link response_items, 'group_perm', true, 'permission', 'can_read',
+ 'All users', created['uuid'], 'arvados#group', true, 'Group'
+
+ verify_link response_items, 'repo_perm', true, 'permission', 'can_write',
+ 'new_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'vm_login_perm', false, 'permission', 'can_login',
+ nil, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+
+ # invoke setup with a vm_uuid
+ post :setup, {
+ vm_uuid: @vm_uuid,
+ openid_prefix: 'http://www.xyz.com/account',
+ user: {
+ email: 'junk_email'
+ },
+ uuid: created['uuid']
+ }
+
+ assert_response :success
+
+ response_items = JSON.parse(@response.body)['items']
+ created = response_items['user']
+
+ assert_equal created['email'], 'test@abc.com', 'expected original email'
+
+ # verify links
+ verify_link response_items, 'oid_login_perm', true, 'permission', 'can_login',
+ created['uuid'], created['email'], 'arvados#user', false, 'User'
+
+ verify_link response_items, 'group_perm', true, 'permission', 'can_read',
+ 'All users', created['uuid'], 'arvados#group', true, 'Group'
+
+ # since no repo name in input, we won't get any; even though user has one
+ verify_link response_items, 'repo_perm', false, 'permission', 'can_write',
+ 'new_repo', created['uuid'], 'arvados#repository', true, 'Repository'
+
+ verify_link response_items, 'vm_login_perm', true, 'permission', 'can_login',
+ @vm_uuid, created['uuid'], 'arvados#virtualMachine', false, 'VirtualMachine'
+ end
+
def verify_num_links (original_links, expected_additional_links)
links_now = Link.all
assert_equal original_links.size+expected_additional_links, Link.all.size,
def verify_link(response_items, link_object_name, expect_link, link_class,
link_name, head_uuid, tail_uuid, head_kind, fetch_object, class_name)
-
link = response_items[link_object_name]
if !expect_link
- assert_nil link
+ assert_nil link, "Expected no link for #{link_object_name}"
return
end
- assert_not_nil link
+ assert_not_nil link, "Expected link for #{link_object_name}"
if fetch_object
object = Object.const_get(class_name).where(name: head_uuid)
assert [] != object, "expected #{class_name} with name #{head_uuid}"
head_uuid = object.first[:uuid]
end
-
assert_equal link['link_class'], link_class,
"did not find expected link_class for #{link_object_name}"