projects
/
arvados.git
/ blobdiff
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
7478: Preemptable instances scheduling parameter on API server
[arvados.git]
/
services
/
api
/
app
/
controllers
/
user_sessions_controller.rb
diff --git
a/services/api/app/controllers/user_sessions_controller.rb
b/services/api/app/controllers/user_sessions_controller.rb
index 256a67bcbb55aa426e405312fd3908e9dc1177dd..20633153e758c70f5b91d0b66466a06e6393b2da 100644
(file)
--- a/
services/api/app/controllers/user_sessions_controller.rb
+++ b/
services/api/app/controllers/user_sessions_controller.rb
@@
-1,3
+1,7
@@
+# Copyright (C) The Arvados Authors. All rights reserved.
+#
+# SPDX-License-Identifier: AGPL-3.0
+
class UserSessionsController < ApplicationController
before_filter :require_auth_scope, :only => [ :destroy ]
class UserSessionsController < ApplicationController
before_filter :require_auth_scope, :only => [ :destroy ]
@@
-15,12
+19,16
@@
class UserSessionsController < ApplicationController
unless identity_url_ok
# Whoa. This should never happen.
logger.error "UserSessionsController.create: omniauth object missing/invalid"
unless identity_url_ok
# Whoa. This should never happen.
logger.error "UserSessionsController.create: omniauth object missing/invalid"
- logger.error "omniauth
.pretty_inspect():\n\n#{omniauth.pretty_inspect()}"
+ logger.error "omniauth
: "+omniauth.pretty_inspect
return redirect_to login_failure_url
end
return redirect_to login_failure_url
end
- user = User.find_by_identity_url(omniauth['info']['identity_url'])
+ # Only local users can create sessions, hence uuid_like_pattern
+ # here.
+ user = User.unscoped.where('identity_url = ? and uuid like ?',
+ omniauth['info']['identity_url'],
+ User.uuid_like_pattern).first
if not user
# Check for permission to log in to an existing User record with
# a different identity_url
if not user
# Check for permission to log in to an existing User record with
# a different identity_url
@@
-37,6
+45,7
@@
class UserSessionsController < ApplicationController
end
end
end
end
end
end
+
if not user
# New user registration
user = User.new(:email => omniauth['info']['email'],
if not user
# New user registration
user = User.new(:email => omniauth['info']['email'],
@@
-45,6
+54,9
@@
class UserSessionsController < ApplicationController
:identity_url => omniauth['info']['identity_url'],
:is_active => Rails.configuration.new_users_are_active,
:owner_uuid => system_user_uuid)
:identity_url => omniauth['info']['identity_url'],
:is_active => Rails.configuration.new_users_are_active,
:owner_uuid => system_user_uuid)
+ if omniauth['info']['username']
+ user.set_initial_username(requested: omniauth['info']['username'])
+ end
act_as_system_user do
user.save or raise Exception.new(user.errors.messages)
end
act_as_system_user do
user.save or raise Exception.new(user.errors.messages)
end
@@
-56,6
+68,13
@@
class UserSessionsController < ApplicationController
# First login to a pre-activated account
user.identity_url = omniauth['info']['identity_url']
end
# First login to a pre-activated account
user.identity_url = omniauth['info']['identity_url']
end
+
+ while (uuid = user.redirect_to_user_uuid)
+ user = User.where(uuid: uuid).first
+ if !user
+ raise Exception.new("identity_url #{omniauth['info']['identity_url']} redirects to nonexistent uuid #{uuid}")
+ end
+ end
end
# For the benefit of functional and integration tests:
end
# For the benefit of functional and integration tests:
@@
-93,7
+112,7
@@
class UserSessionsController < ApplicationController
flash[:notice] = 'You have logged off'
return_to = params[:return_to] || root_url
flash[:notice] = 'You have logged off'
return_to = params[:return_to] || root_url
- redirect_to "#{
CUSTOM_PROVIDER_URL
}/users/sign_out?redirect_uri=#{CGI.escape return_to}"
+ redirect_to "#{
Rails.configuration.sso_provider_url
}/users/sign_out?redirect_uri=#{CGI.escape return_to}"
end
# login - Just bounce to /auth/joshid. The only purpose of this function is
end
# login - Just bounce to /auth/joshid. The only purpose of this function is
@@
-124,7
+143,8
@@
class UserSessionsController < ApplicationController
# Stub: automatically register all new API clients
api_client_url_prefix = callback_url.match(%r{^.*?://[^/]+})[0] + '/'
act_as_system_user do
# Stub: automatically register all new API clients
api_client_url_prefix = callback_url.match(%r{^.*?://[^/]+})[0] + '/'
act_as_system_user do
- @api_client = ApiClient.find_or_create_by_url_prefix api_client_url_prefix
+ @api_client = ApiClient.
+ find_or_create_by(url_prefix: api_client_url_prefix)
end
api_client_auth = ApiClientAuthorization.
end
api_client_auth = ApiClientAuthorization.