assert_not_includes group_uuids, groups(:aproject).uuid
assert_not_includes group_uuids, groups(:asubproject).uuid
assert_includes group_uuids, groups(:private).uuid
+ assert_includes group_uuids, groups(:group_with_no_class).uuid
end
test "get list of groups with bogus group_class" do
get :contents, {
id: groups(:aproject).uuid,
format: :json,
- include_linked: true,
}
check_project_contents_response
end
get :contents, {
id: groups(:aproject).uuid,
format: :json,
- include_linked: true,
}
check_project_contents_response
end
assert_includes ids, collections(:baz_file_in_asubproject).uuid
end
- test "user with project read permission can sort project collections ascending, ignoring case" do
- authorize_with :project_viewer
- get :contents, {
- id: groups(:asubproject).uuid,
- format: :json,
- filters: [['uuid', 'is_a', "arvados#collection"]],
- order: 'collections.name asc'
- }
- sorted_entries = json_response['items'].collect { |item| item["name"].downcase }
- previous = nil
- sorted_entries.each do |entry|
- assert_operator( previous, :<=, entry) if previous
- previous = entry
- end
- end
-
- test "user with project read permission can sort project collections descending, ignoring case" do
- authorize_with :project_viewer
- get :contents, {
- id: groups(:asubproject).uuid,
- format: :json,
- filters: [['uuid', 'is_a', "arvados#collection"]],
- order: 'collections.name desc'
- }
- sorted_entries = json_response['items'].collect { |item| item["name"].downcase }
- previous = nil
- sorted_entries.each do |entry|
- assert_operator( previous, :>=, entry) if previous
- previous = entry
+ [['asc', :<=],
+ ['desc', :>=]].each do |order, operator|
+ test "user with project read permission can sort project collections #{order}" do
+ authorize_with :project_viewer
+ get :contents, {
+ id: groups(:asubproject).uuid,
+ format: :json,
+ filters: [['uuid', 'is_a', "arvados#collection"]],
+ order: "collections.name #{order}"
+ }
+ sorted_names = json_response['items'].collect { |item| item["name"] }
+ # Here we avoid assuming too much about the database
+ # collation. Both "alice"<"Bob" and "alice">"Bob" can be
+ # correct. Hopefully it _is_ safe to assume that if "a" comes
+ # before "b" in the ascii alphabet, "aX">"bY" is never true for
+ # any strings X and Y.
+ reliably_sortable_names = sorted_names.select do |name|
+ name[0] >= 'a' and name[0] <= 'z'
+ end.uniq do |name|
+ name[0]
+ end
+ # Preserve order of sorted_names. But do not use &=. If
+ # sorted_names has out-of-order duplicates, we want to preserve
+ # them here, so we can detect them and fail the test below.
+ sorted_names.select! do |name|
+ reliably_sortable_names.include? name
+ end
+ actually_checked_anything = false
+ previous = nil
+ sorted_names.each do |entry|
+ if previous
+ assert_operator(previous, operator, entry,
+ "Entries sorted incorrectly.")
+ actually_checked_anything = true
+ end
+ previous = entry
+ end
+ assert actually_checked_anything, "Didn't even find two names to compare."
end
end
authorize_with :project_viewer
get :contents, {
format: :json,
- include_linked: false,
filters: [['uuid', 'is_a', 'arvados#specimen']]
}
assert_response :success
end
end
+ test "Collection contents don't include manifest_text" do
+ authorize_with :active
+ get :contents, {
+ id: groups(:aproject).uuid,
+ filters: [["uuid", "is_a", "arvados#collection"]],
+ format: :json,
+ }
+ assert_response :success
+ refute(json_response["items"].any? { |c| not c["portable_data_hash"] },
+ "response included an item without a portable data hash")
+ refute(json_response["items"].any? { |c| c.include?("manifest_text") },
+ "response included an item with a manifest text")
+ end
+
test 'get writable_by list for owned group' do
authorize_with :active
get :show, {