+# Copyright (C) The Arvados Authors. All rights reserved.
+#
+# SPDX-License-Identifier: AGPL-3.0
+
class Link < ArvadosModel
include HasUuid
include KindAndEtag
include CommonApiTemplate
- serialize :properties, Hash
+
+ # Posgresql JSONB columns should NOT be declared as serialized, Rails 5
+ # already know how to properly treat them.
+ attribute :properties, :jsonbHash, default: {}
+
+ validate :name_links_are_obsolete
before_create :permission_to_attach_to_objects
before_update :permission_to_attach_to_objects
- after_update :maybe_invalidate_permissions_cache
- after_create :maybe_invalidate_permissions_cache
- after_destroy :maybe_invalidate_permissions_cache
- attr_accessor :head_kind, :tail_kind
- validate :name_link_has_valid_name
- validate :name_link_owner_is_tail
+ after_update :call_update_permissions
+ after_create :call_update_permissions
+ before_destroy :clear_permissions
+ after_destroy :check_permissions
api_accessible :user, extend: :common do |t|
t.add :tail_uuid
t.add :properties
end
- def properties
- @properties ||= Hash.new
- super
- end
-
def head_kind
if k = ArvadosModel::resource_class_for_uuid(head_uuid)
k.kind
# Administrators can grant permissions
return true if current_user.is_admin
- # All users can grant permissions on objects they own or can manage
head_obj = ArvadosModel.find_by_uuid(head_uuid)
+
+ # No permission links can be pointed to past collection versions
+ return false if head_obj.is_a?(Collection) && head_obj.current_version_uuid != head_uuid
+
+ # All users can grant permissions on objects they own or can manage
return true if current_user.can?(manage: head_obj)
# Default = deny.
false
end
- def maybe_invalidate_permissions_cache
+ PERM_LEVEL = {
+ 'can_read' => 1,
+ 'can_login' => 1,
+ 'can_write' => 2,
+ 'can_manage' => 3,
+ }
+
+ def call_update_permissions
if self.link_class == 'permission'
- # Clearing the entire permissions cache can generate many
- # unnecessary queries if many active users are not affected by
- # this change. In such cases it would be better to search cached
- # permissions for head_uuid and tail_uuid, and invalidate the
- # cache for only those users. (This would require a browseable
- # cache.)
- User.invalidate_permissions_cache
+ update_permissions tail_uuid, head_uuid, PERM_LEVEL[name], self.uuid
end
end
- def name_link_has_valid_name
- if link_class == 'name'
- unless name.is_a? String and !name.empty?
- errors.add('name', 'must be a non-empty string')
- end
- else
- true
+ def clear_permissions
+ if self.link_class == 'permission'
+ update_permissions tail_uuid, head_uuid, REVOKE_PERM, self.uuid
+ end
+ end
+
+ def check_permissions
+ if self.link_class == 'permission'
+ check_permissions_against_full_refresh
end
end
- def name_link_owner_is_tail
+ def name_links_are_obsolete
if link_class == 'name'
- self.owner_uuid = tail_uuid
- ensure_owner_uuid_is_permitted
+ errors.add('name', 'Name links are obsolete')
+ false
+ else
+ true
end
end
# A user is permitted to create, update or modify a permission link
- # if and only if they have "manage" permission on the destination
- # object.
+ # if and only if they have "manage" permission on the object
+ # indicated by the permission link's head_uuid.
+ #
# All other links are treated as regular ArvadosModel objects.
#
def ensure_owner_uuid_is_permitted
super
end
end
-
- # A user can give all other users permissions on folders.
- def skip_uuid_read_permission_check
- skipped_attrs = super
- if link_class == "permission" and
- (ArvadosModel.resource_class_for_uuid(head_uuid) == Group) and
- (ArvadosModel.resource_class_for_uuid(tail_uuid) == User)
- skipped_attrs << "tail_uuid"
- end
- skipped_attrs
- end
end
projects / arvados.git / blobdiff