Merge branch '16622-dav-s3-dialog' refs #16622

[arvados.git] / src / views-components / webdav-s3-dialog / webdav-s3-dialog.tsx

diff --git a/src/views-components/webdav-s3-dialog/webdav-s3-dialog.tsx b/src/views-components/webdav-s3-dialog/webdav-s3-dialog.tsx
index cd3888483dbaba088fa9bb1d296be2b634d18b21..018a0ef096b550191a953f545460d25b4f275d6d 100644 (file)
--- a/src/views-components/webdav-s3-dialog/webdav-s3-dialog.tsx
+++ b/src/views-components/webdav-s3-dialog/webdav-s3-dialog.tsx
@@ -10,7 +10,7 @@ import { WithDialogProps } from '~/store/dialog/with-dialog';
 import { compose } from 'redux';
 import { DetailsAttribute } from "~/components/details-attribute/details-attribute";
 
-type CssRules = 'details';
+export type CssRules = 'details';
 
 const styles: StyleRulesCallback<CssRules> = theme => ({
     details: {
@@ -57,18 +57,19 @@ export const WebDavS3InfoDialog = compose(
         } else {
             winDav = new URL(props.data.downloadUrl);
             cyberDav = new URL(props.data.downloadUrl);
-            winDav.pathname = `/by_id/${props.data.uuid}/`;
-            cyberDav.pathname = `/by_id/${props.data.uuid}/`;
+            winDav.pathname = `/by_id/${props.data.uuid}`;
+            cyberDav.pathname = `/by_id/${props.data.uuid}`;
         }
 
-        cyberDav.protocol = { "http:": "dav:", "https:": "davs:" }[cyberDav.protocol];
+        cyberDav.username = props.data.username;
+        const cyberDavStr = "dav" + cyberDav.toString().slice(4);
 
         const s3endpoint = new URL(props.data.collectionsUrl.replace(/\/\*(--[^.]+)?\./, "/"));
 
         const sp = props.data.token.split("/");
         let tokenUuid;
         let tokenSecret;
-        if (sp.length === 3 && sp[0] === "v2" && props.data.homeCluster === props.data.localCluster) {
+        if (sp.length === 3 && sp[0] === "v2" && sp[1].slice(0, 5) === props.data.localCluster) {
             tokenUuid = sp[1];
             tokenSecret = sp[2];
         } else {
@@ -76,26 +77,33 @@ export const WebDavS3InfoDialog = compose(
             tokenSecret = tokenUuid;
         }
 
+        const supportsWebdav = (props.data.uuid.indexOf("-4zz18-") === 5);
+
+        let activeTab = props.data.activeTab;
+        if (!supportsWebdav) {
+            activeTab = 2;
+        }
+
         return <Dialog
             open={props.open}
             maxWidth="md"
             onClose={props.closeDialog}
             style={{ alignSelf: 'stretch' }}>
             <CardHeader
-                title={`WebDAV and S3`} />
+                title={`Open as Network Folder or S3 Bucket`} />
             <div className={props.classes.details} >
-                <Tabs value={props.data.activeTab} onChange={props.data.setActiveTab}>
-                    <Tab key="cyberduck" label="Cyberduck/Mountain Duck or Gnome Files" />
-                    <Tab key="windows" label="Windows or MacOS" />
-                    <Tab key="s3" label="Using an S3 client" />
+                <Tabs value={activeTab} onChange={props.data.setActiveTab}>
+                    {supportsWebdav && <Tab value={0} key="cyberduck" label="Cyberduck/Mountain Duck or Gnome Files" />}
+                    {supportsWebdav && <Tab value={1} key="windows" label="Windows or MacOS" />}
+                    <Tab value={2} key="s3" label="S3 bucket" />
                 </Tabs>
 
-                <TabPanel index={1} value={props.data.activeTab}>
+                <TabPanel index={1} value={activeTab}>
                     <h2>Settings</h2>
 
                     <DetailsAttribute
                         label='Internet address'
-                        value={winDav.toString()}
+                        value={<a href={winDav.toString()} target="_blank">{winDav.toString()}</a>}
                         copyValue={winDav.toString()} />
 
                     <DetailsAttribute
@@ -122,11 +130,11 @@ export const WebDavS3InfoDialog = compose(
                     </ol>
                 </TabPanel>
 
-                <TabPanel index={0} value={props.data.activeTab}>
+                <TabPanel index={0} value={activeTab}>
                     <DetailsAttribute
                         label='Server'
-                        value={<a href={cyberDav.toString()}>{cyberDav.toString()}</a>}
-                        copyValue={cyberDav.toString()} />
+                        value={<a href={cyberDavStr} target="_blank">{cyberDavStr}</a>}
+                        copyValue={cyberDavStr} />
 
                     <DetailsAttribute
                         label='Username'
@@ -147,7 +155,7 @@ export const WebDavS3InfoDialog = compose(
 
                 </TabPanel>
 
-                <TabPanel index={2} value={props.data.activeTab}>
+                <TabPanel index={2} value={activeTab}>
                     <DetailsAttribute
                         label='Endpoint'
                         value={s3endpoint.host}