8186: Add comment/warning about EBS volume size limit.

[arvados.git] / services / nodemanager / arvnodeman / computenode / driver / ec2.py

diff --git a/services/nodemanager/arvnodeman/computenode/driver/ec2.py b/services/nodemanager/arvnodeman/computenode/driver/ec2.py
index 9670c9c62b5f9ec3ab46b754a7b0cb32ab70cc74..d6b877c27cdef137b469b7a06027712c3ac8986c 100644 (file)
--- a/services/nodemanager/arvnodeman/computenode/driver/ec2.py
+++ b/services/nodemanager/arvnodeman/computenode/driver/ec2.py
@@ -73,9 +73,10 @@ class ComputeNodeDriver(BaseComputeNodeDriver):
         scratch = int(size.scratch / 1000) + 1
         if scratch > size.disk:
             volsize = scratch - size.disk
-            if volsize < 1:
-                volsize = 1
             if volsize > 16384:
+                # Must be 1-16384 for General Purpose SSD (gp2) devices
+                # https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_EbsBlockDevice.html
+                self._logger.warning("Requested EBS volume size %d is too large, capping size request to 16384 GB", volsize)
                 volsize = 16384
             kw["ex_blockdevicemappings"] = [{
                 "DeviceName": "/dev/xvdt",