sdk/python/tests/test_keep_client.py

   1 import hashlib
   2 import mock
   3 import os
   4 import pycurl
   5 import random
   6 import re
   7 import socket
   8 import threading
   9 import time
  10 import unittest
  11 import urlparse
  12
  13 import arvados
  14 import arvados.retry
  15 import arvados_testutil as tutil
  16 import keepstub
  17 import run_test_server
  18
  19 class KeepTestCase(run_test_server.TestCaseWithServers):
  20     MAIN_SERVER = {}
  21     KEEP_SERVER = {}
  22
  23     @classmethod
  24     def setUpClass(cls):
  25         super(KeepTestCase, cls).setUpClass()
  26         run_test_server.authorize_with("admin")
  27         cls.api_client = arvados.api('v1')
  28         cls.keep_client = arvados.KeepClient(api_client=cls.api_client,
  29                                              proxy='', local_store='')
  30
  31     def test_KeepBasicRWTest(self):
  32         foo_locator = self.keep_client.put('foo')
  33         self.assertRegexpMatches(
  34             foo_locator,
  35             '^acbd18db4cc2f85cedef654fccc4a4d8\+3',
  36             'wrong md5 hash from Keep.put("foo"): ' + foo_locator)
  37         self.assertEqual(self.keep_client.get(foo_locator),
  38                          'foo',
  39                          'wrong content from Keep.get(md5("foo"))')
  40
  41     def test_KeepBinaryRWTest(self):
  42         blob_str = '\xff\xfe\xf7\x00\x01\x02'
  43         blob_locator = self.keep_client.put(blob_str)
  44         self.assertRegexpMatches(
  45             blob_locator,
  46             '^7fc7c53b45e53926ba52821140fef396\+6',
  47             ('wrong locator from Keep.put(<binarydata>):' + blob_locator))
  48         self.assertEqual(self.keep_client.get(blob_locator),
  49                          blob_str,
  50                          'wrong content from Keep.get(md5(<binarydata>))')
  51
  52     def test_KeepLongBinaryRWTest(self):
  53         blob_str = '\xff\xfe\xfd\xfc\x00\x01\x02\x03'
  54         for i in range(0,23):
  55             blob_str = blob_str + blob_str
  56         blob_locator = self.keep_client.put(blob_str)
  57         self.assertRegexpMatches(
  58             blob_locator,
  59             '^84d90fc0d8175dd5dcfab04b999bc956\+67108864',
  60             ('wrong locator from Keep.put(<binarydata>): ' + blob_locator))
  61         self.assertEqual(self.keep_client.get(blob_locator),
  62                          blob_str,
  63                          'wrong content from Keep.get(md5(<binarydata>))')
  64
  65     def test_KeepSingleCopyRWTest(self):
  66         blob_str = '\xff\xfe\xfd\xfc\x00\x01\x02\x03'
  67         blob_locator = self.keep_client.put(blob_str, copies=1)
  68         self.assertRegexpMatches(
  69             blob_locator,
  70             '^c902006bc98a3eb4a3663b65ab4a6fab\+8',
  71             ('wrong locator from Keep.put(<binarydata>): ' + blob_locator))
  72         self.assertEqual(self.keep_client.get(blob_locator),
  73                          blob_str,
  74                          'wrong content from Keep.get(md5(<binarydata>))')
  75
  76     def test_KeepEmptyCollectionTest(self):
  77         blob_locator = self.keep_client.put('', copies=1)
  78         self.assertRegexpMatches(
  79             blob_locator,
  80             '^d41d8cd98f00b204e9800998ecf8427e\+0',
  81             ('wrong locator from Keep.put(""): ' + blob_locator))
  82
  83     def test_unicode_must_be_ascii(self):
  84         # If unicode type, must only consist of valid ASCII
  85         foo_locator = self.keep_client.put(u'foo')
  86         self.assertRegexpMatches(
  87             foo_locator,
  88             '^acbd18db4cc2f85cedef654fccc4a4d8\+3',
  89             'wrong md5 hash from Keep.put("foo"): ' + foo_locator)
  90
  91         with self.assertRaises(UnicodeEncodeError):
  92             # Error if it is not ASCII
  93             self.keep_client.put(u'\xe2')
  94
  95         with self.assertRaises(arvados.errors.ArgumentError):
  96             # Must be a string type
  97             self.keep_client.put({})
  98
  99 class KeepPermissionTestCase(run_test_server.TestCaseWithServers):
 100     MAIN_SERVER = {}
 101     KEEP_SERVER = {'blob_signing_key': 'abcdefghijk0123456789',
 102                    'enforce_permissions': True}
 103
 104     def test_KeepBasicRWTest(self):
 105         run_test_server.authorize_with('active')
 106         keep_client = arvados.KeepClient()
 107         foo_locator = keep_client.put('foo')
 108         self.assertRegexpMatches(
 109             foo_locator,
 110             r'^acbd18db4cc2f85cedef654fccc4a4d8\+3\+A[a-f0-9]+@[a-f0-9]+$',
 111             'invalid locator from Keep.put("foo"): ' + foo_locator)
 112         self.assertEqual(keep_client.get(foo_locator),
 113                          'foo',
 114                          'wrong content from Keep.get(md5("foo"))')
 115
 116         # GET with an unsigned locator => NotFound
 117         bar_locator = keep_client.put('bar')
 118         unsigned_bar_locator = "37b51d194a7513e45b56f6524f2d51f2+3"
 119         self.assertRegexpMatches(
 120             bar_locator,
 121             r'^37b51d194a7513e45b56f6524f2d51f2\+3\+A[a-f0-9]+@[a-f0-9]+$',
 122             'invalid locator from Keep.put("bar"): ' + bar_locator)
 123         self.assertRaises(arvados.errors.NotFoundError,
 124                           keep_client.get,
 125                           unsigned_bar_locator)
 126
 127         # GET from a different user => NotFound
 128         run_test_server.authorize_with('spectator')
 129         self.assertRaises(arvados.errors.NotFoundError,
 130                           arvados.Keep.get,
 131                           bar_locator)
 132
 133         # Unauthenticated GET for a signed locator => NotFound
 134         # Unauthenticated GET for an unsigned locator => NotFound
 135         keep_client.api_token = ''
 136         self.assertRaises(arvados.errors.NotFoundError,
 137                           keep_client.get,
 138                           bar_locator)
 139         self.assertRaises(arvados.errors.NotFoundError,
 140                           keep_client.get,
 141                           unsigned_bar_locator)
 142
 143
 144 # KeepOptionalPermission: starts Keep with --permission-key-file
 145 # but not --enforce-permissions (i.e. generate signatures on PUT
 146 # requests, but do not require them for GET requests)
 147 #
 148 # All of these requests should succeed when permissions are optional:
 149 # * authenticated request, signed locator
 150 # * authenticated request, unsigned locator
 151 # * unauthenticated request, signed locator
 152 # * unauthenticated request, unsigned locator
 153 class KeepOptionalPermission(run_test_server.TestCaseWithServers):
 154     MAIN_SERVER = {}
 155     KEEP_SERVER = {'blob_signing_key': 'abcdefghijk0123456789',
 156                    'enforce_permissions': False}
 157
 158     @classmethod
 159     def setUpClass(cls):
 160         super(KeepOptionalPermission, cls).setUpClass()
 161         run_test_server.authorize_with("admin")
 162         cls.api_client = arvados.api('v1')
 163
 164     def setUp(self):
 165         super(KeepOptionalPermission, self).setUp()
 166         self.keep_client = arvados.KeepClient(api_client=self.api_client,
 167                                               proxy='', local_store='')
 168
 169     def _put_foo_and_check(self):
 170         signed_locator = self.keep_client.put('foo')
 171         self.assertRegexpMatches(
 172             signed_locator,
 173             r'^acbd18db4cc2f85cedef654fccc4a4d8\+3\+A[a-f0-9]+@[a-f0-9]+$',
 174             'invalid locator from Keep.put("foo"): ' + signed_locator)
 175         return signed_locator
 176
 177     def test_KeepAuthenticatedSignedTest(self):
 178         signed_locator = self._put_foo_and_check()
 179         self.assertEqual(self.keep_client.get(signed_locator),
 180                          'foo',
 181                          'wrong content from Keep.get(md5("foo"))')
 182
 183     def test_KeepAuthenticatedUnsignedTest(self):
 184         signed_locator = self._put_foo_and_check()
 185         self.assertEqual(self.keep_client.get("acbd18db4cc2f85cedef654fccc4a4d8"),
 186                          'foo',
 187                          'wrong content from Keep.get(md5("foo"))')
 188
 189     def test_KeepUnauthenticatedSignedTest(self):
 190         # Check that signed GET requests work even when permissions
 191         # enforcement is off.
 192         signed_locator = self._put_foo_and_check()
 193         self.keep_client.api_token = ''
 194         self.assertEqual(self.keep_client.get(signed_locator),
 195                          'foo',
 196                          'wrong content from Keep.get(md5("foo"))')
 197
 198     def test_KeepUnauthenticatedUnsignedTest(self):
 199         # Since --enforce-permissions is not in effect, GET requests
 200         # need not be authenticated.
 201         signed_locator = self._put_foo_and_check()
 202         self.keep_client.api_token = ''
 203         self.assertEqual(self.keep_client.get("acbd18db4cc2f85cedef654fccc4a4d8"),
 204                          'foo',
 205                          'wrong content from Keep.get(md5("foo"))')
 206
 207
 208 class KeepProxyTestCase(run_test_server.TestCaseWithServers):
 209     MAIN_SERVER = {}
 210     KEEP_SERVER = {}
 211     KEEP_PROXY_SERVER = {}
 212
 213     @classmethod
 214     def setUpClass(cls):
 215         super(KeepProxyTestCase, cls).setUpClass()
 216         run_test_server.authorize_with('active')
 217         cls.api_client = arvados.api('v1')
 218
 219     def tearDown(self):
 220         arvados.config.settings().pop('ARVADOS_EXTERNAL_CLIENT', None)
 221         super(KeepProxyTestCase, self).tearDown()
 222
 223     def test_KeepProxyTest1(self):
 224         # Will use ARVADOS_KEEP_PROXY environment variable that is set by
 225         # setUpClass().
 226         keep_client = arvados.KeepClient(api_client=self.api_client,
 227                                          local_store='')
 228         baz_locator = keep_client.put('baz')
 229         self.assertRegexpMatches(
 230             baz_locator,
 231             '^73feffa4b7f6bb68e44cf984c85f6e88\+3',
 232             'wrong md5 hash from Keep.put("baz"): ' + baz_locator)
 233         self.assertEqual(keep_client.get(baz_locator),
 234                          'baz',
 235                          'wrong content from Keep.get(md5("baz"))')
 236         self.assertTrue(keep_client.using_proxy)
 237
 238     def test_KeepProxyTest2(self):
 239         # Don't instantiate the proxy directly, but set the X-External-Client
 240         # header.  The API server should direct us to the proxy.
 241         arvados.config.settings()['ARVADOS_EXTERNAL_CLIENT'] = 'true'
 242         keep_client = arvados.KeepClient(api_client=self.api_client,
 243                                          proxy='', local_store='')
 244         baz_locator = keep_client.put('baz2')
 245         self.assertRegexpMatches(
 246             baz_locator,
 247             '^91f372a266fe2bf2823cb8ec7fda31ce\+4',
 248             'wrong md5 hash from Keep.put("baz2"): ' + baz_locator)
 249         self.assertEqual(keep_client.get(baz_locator),
 250                          'baz2',
 251                          'wrong content from Keep.get(md5("baz2"))')
 252         self.assertTrue(keep_client.using_proxy)
 253
 254
 255 class KeepClientServiceTestCase(unittest.TestCase, tutil.ApiClientMock):
 256     def get_service_roots(self, api_client):
 257         keep_client = arvados.KeepClient(api_client=api_client)
 258         services = keep_client.weighted_service_roots(arvados.KeepLocator('0'*32))
 259         return [urlparse.urlparse(url) for url in sorted(services)]
 260
 261     def test_ssl_flag_respected_in_roots(self):
 262         for ssl_flag in [False, True]:
 263             services = self.get_service_roots(self.mock_keep_services(
 264                 service_ssl_flag=ssl_flag))
 265             self.assertEqual(
 266                 ('https' if ssl_flag else 'http'), services[0].scheme)
 267
 268     def test_correct_ports_with_ipv6_addresses(self):
 269         service = self.get_service_roots(self.mock_keep_services(
 270             service_type='proxy', service_host='100::1', service_port=10, count=1))[0]
 271         self.assertEqual('100::1', service.hostname)
 272         self.assertEqual(10, service.port)
 273
 274     # test_*_timeout verify that KeepClient instructs pycurl to use
 275     # the appropriate connection and read timeouts. They don't care
 276     # whether pycurl actually exhibits the expected timeout behavior
 277     # -- those tests are in the KeepClientTimeout test class.
 278
 279     def test_get_timeout(self):
 280         api_client = self.mock_keep_services(count=1)
 281         force_timeout = socket.timeout("timed out")
 282         with tutil.mock_keep_responses(force_timeout, 0) as mock:
 283             keep_client = arvados.KeepClient(api_client=api_client)
 284             with self.assertRaises(arvados.errors.KeepReadError):
 285                 keep_client.get('ffffffffffffffffffffffffffffffff')
 286             self.assertEqual(
 287                 mock.responses[0].getopt(pycurl.CONNECTTIMEOUT_MS),
 288                 int(arvados.KeepClient.DEFAULT_TIMEOUT[0]*1000))
 289             self.assertEqual(
 290                 mock.responses[0].getopt(pycurl.TIMEOUT_MS),
 291                 int(arvados.KeepClient.DEFAULT_TIMEOUT[1]*1000))
 292
 293     def test_put_timeout(self):
 294         api_client = self.mock_keep_services(count=1)
 295         force_timeout = socket.timeout("timed out")
 296         with tutil.mock_keep_responses(force_timeout, 0) as mock:
 297             keep_client = arvados.KeepClient(api_client=api_client)
 298             with self.assertRaises(arvados.errors.KeepWriteError):
 299                 keep_client.put('foo')
 300             self.assertEqual(
 301                 mock.responses[0].getopt(pycurl.CONNECTTIMEOUT_MS),
 302                 int(arvados.KeepClient.DEFAULT_TIMEOUT[0]*1000))
 303             self.assertEqual(
 304                 mock.responses[0].getopt(pycurl.TIMEOUT_MS),
 305                 int(arvados.KeepClient.DEFAULT_TIMEOUT[1]*1000))
 306
 307     def test_proxy_get_timeout(self):
 308         api_client = self.mock_keep_services(service_type='proxy', count=1)
 309         force_timeout = socket.timeout("timed out")
 310         with tutil.mock_keep_responses(force_timeout, 0) as mock:
 311             keep_client = arvados.KeepClient(api_client=api_client)
 312             with self.assertRaises(arvados.errors.KeepReadError):
 313                 keep_client.get('ffffffffffffffffffffffffffffffff')
 314             self.assertEqual(
 315                 mock.responses[0].getopt(pycurl.CONNECTTIMEOUT_MS),
 316                 int(arvados.KeepClient.DEFAULT_PROXY_TIMEOUT[0]*1000))
 317             self.assertEqual(
 318                 mock.responses[0].getopt(pycurl.TIMEOUT_MS),
 319                 int(arvados.KeepClient.DEFAULT_PROXY_TIMEOUT[1]*1000))
 320
 321     def test_proxy_put_timeout(self):
 322         api_client = self.mock_keep_services(service_type='proxy', count=1)
 323         force_timeout = socket.timeout("timed out")
 324         with tutil.mock_keep_responses(force_timeout, 0) as mock:
 325             keep_client = arvados.KeepClient(api_client=api_client)
 326             with self.assertRaises(arvados.errors.KeepWriteError):
 327                 keep_client.put('foo')
 328             self.assertEqual(
 329                 mock.responses[0].getopt(pycurl.CONNECTTIMEOUT_MS),
 330                 int(arvados.KeepClient.DEFAULT_PROXY_TIMEOUT[0]*1000))
 331             self.assertEqual(
 332                 mock.responses[0].getopt(pycurl.TIMEOUT_MS),
 333                 int(arvados.KeepClient.DEFAULT_PROXY_TIMEOUT[1]*1000))
 334
 335     def check_no_services_error(self, verb, exc_class):
 336         api_client = mock.MagicMock(name='api_client')
 337         api_client.keep_services().accessible().execute.side_effect = (
 338             arvados.errors.ApiError)
 339         keep_client = arvados.KeepClient(api_client=api_client)
 340         with self.assertRaises(exc_class) as err_check:
 341             getattr(keep_client, verb)('d41d8cd98f00b204e9800998ecf8427e+0')
 342         self.assertEqual(0, len(err_check.exception.request_errors()))
 343
 344     def test_get_error_with_no_services(self):
 345         self.check_no_services_error('get', arvados.errors.KeepReadError)
 346
 347     def test_put_error_with_no_services(self):
 348         self.check_no_services_error('put', arvados.errors.KeepWriteError)
 349
 350     def check_errors_from_last_retry(self, verb, exc_class):
 351         api_client = self.mock_keep_services(count=2)
 352         req_mock = tutil.mock_keep_responses(
 353             "retry error reporting test", 500, 500, 403, 403)
 354         with req_mock, tutil.skip_sleep, \
 355                 self.assertRaises(exc_class) as err_check:
 356             keep_client = arvados.KeepClient(api_client=api_client)
 357             getattr(keep_client, verb)('d41d8cd98f00b204e9800998ecf8427e+0',
 358                                        num_retries=3)
 359         self.assertEqual([403, 403], [
 360                 getattr(error, 'status_code', None)
 361                 for error in err_check.exception.request_errors().itervalues()])
 362
 363     def test_get_error_reflects_last_retry(self):
 364         self.check_errors_from_last_retry('get', arvados.errors.KeepReadError)
 365
 366     def test_put_error_reflects_last_retry(self):
 367         self.check_errors_from_last_retry('put', arvados.errors.KeepWriteError)
 368
 369     def test_put_error_does_not_include_successful_puts(self):
 370         data = 'partial failure test'
 371         data_loc = '{}+{}'.format(hashlib.md5(data).hexdigest(), len(data))
 372         api_client = self.mock_keep_services(count=3)
 373         with tutil.mock_keep_responses(data_loc, 200, 500, 500) as req_mock, \
 374                 self.assertRaises(arvados.errors.KeepWriteError) as exc_check:
 375             keep_client = arvados.KeepClient(api_client=api_client)
 376             keep_client.put(data)
 377         self.assertEqual(2, len(exc_check.exception.request_errors()))
 378
 379     def test_proxy_put_with_no_writable_services(self):
 380         data = 'test with no writable services'
 381         data_loc = '{}+{}'.format(hashlib.md5(data).hexdigest(), len(data))
 382         api_client = self.mock_keep_services(service_type='proxy', read_only=True, count=1)
 383         with tutil.mock_keep_responses(data_loc, 200, 500, 500) as req_mock, \
 384                 self.assertRaises(arvados.errors.KeepWriteError) as exc_check:
 385           keep_client = arvados.KeepClient(api_client=api_client)
 386           keep_client.put(data)
 387         self.assertEqual(True, ("no Keep services available" in str(exc_check.exception)))
 388         self.assertEqual(0, len(exc_check.exception.request_errors()))
 389
 390
 391 @tutil.skip_sleep
 392 class KeepClientRendezvousTestCase(unittest.TestCase, tutil.ApiClientMock):
 393
 394     def setUp(self):
 395         # expected_order[i] is the probe order for
 396         # hash=md5(sprintf("%064x",i)) where there are 16 services
 397         # with uuid sprintf("anything-%015x",j) with j in 0..15. E.g.,
 398         # the first probe for the block consisting of 64 "0"
 399         # characters is the service whose uuid is
 400         # "zzzzz-bi6l4-000000000000003", so expected_order[0][0]=='3'.
 401         self.services = 16
 402         self.expected_order = [
 403             list('3eab2d5fc9681074'),
 404             list('097dba52e648f1c3'),
 405             list('c5b4e023f8a7d691'),
 406             list('9d81c02e76a3bf54'),
 407             ]
 408         self.blocks = [
 409             "{:064x}".format(x)
 410             for x in range(len(self.expected_order))]
 411         self.hashes = [
 412             hashlib.md5(self.blocks[x]).hexdigest()
 413             for x in range(len(self.expected_order))]
 414         self.api_client = self.mock_keep_services(count=self.services)
 415         self.keep_client = arvados.KeepClient(api_client=self.api_client)
 416
 417     def test_weighted_service_roots_against_reference_set(self):
 418         # Confirm weighted_service_roots() returns the correct order
 419         for i, hash in enumerate(self.hashes):
 420             roots = self.keep_client.weighted_service_roots(arvados.KeepLocator(hash))
 421             got_order = [
 422                 re.search(r'//\[?keep0x([0-9a-f]+)', root).group(1)
 423                 for root in roots]
 424             self.assertEqual(self.expected_order[i], got_order)
 425
 426     def test_get_probe_order_against_reference_set(self):
 427         self._test_probe_order_against_reference_set(
 428             lambda i: self.keep_client.get(self.hashes[i], num_retries=1))
 429
 430     def test_put_probe_order_against_reference_set(self):
 431         # copies=1 prevents the test from being sensitive to races
 432         # between writer threads.
 433         self._test_probe_order_against_reference_set(
 434             lambda i: self.keep_client.put(self.blocks[i], num_retries=1, copies=1))
 435
 436     def _test_probe_order_against_reference_set(self, op):
 437         for i in range(len(self.blocks)):
 438             with tutil.mock_keep_responses('', *[500 for _ in range(self.services*2)]) as mock, \
 439                  self.assertRaises(arvados.errors.KeepRequestError):
 440                 op(i)
 441             got_order = [
 442                 re.search(r'//\[?keep0x([0-9a-f]+)', resp.getopt(pycurl.URL)).group(1)
 443                 for resp in mock.responses]
 444             self.assertEqual(self.expected_order[i]*2, got_order)
 445
 446     def test_put_probe_order_multiple_copies(self):
 447         for copies in range(2, 4):
 448             for i in range(len(self.blocks)):
 449                 with tutil.mock_keep_responses('', *[500 for _ in range(self.services*3)]) as mock, \
 450                      self.assertRaises(arvados.errors.KeepWriteError):
 451                     self.keep_client.put(self.blocks[i], num_retries=2, copies=copies)
 452                 got_order = [
 453                     re.search(r'//\[?keep0x([0-9a-f]+)', resp.getopt(pycurl.URL)).group(1)
 454                     for resp in mock.responses]
 455                 # With T threads racing to make requests, the position
 456                 # of a given server in the sequence of HTTP requests
 457                 # (got_order) cannot be more than T-1 positions
 458                 # earlier than that server's position in the reference
 459                 # probe sequence (expected_order).
 460                 #
 461                 # Loop invariant: we have accounted for +pos+ expected
 462                 # probes, either by seeing them in +got_order+ or by
 463                 # putting them in +pending+ in the hope of seeing them
 464                 # later. As long as +len(pending)<T+, we haven't
 465                 # started a request too early.
 466                 pending = []
 467                 for pos, expected in enumerate(self.expected_order[i]*3):
 468                     got = got_order[pos-len(pending)]
 469                     while got in pending:
 470                         del pending[pending.index(got)]
 471                         got = got_order[pos-len(pending)]
 472                     if got != expected:
 473                         pending.append(expected)
 474                         self.assertLess(
 475                             len(pending), copies,
 476                             "pending={}, with copies={}, got {}, expected {}".format(
 477                                 pending, copies, repr(got_order), repr(self.expected_order[i]*3)))
 478
 479     def test_probe_waste_adding_one_server(self):
 480         hashes = [
 481             hashlib.md5("{:064x}".format(x)).hexdigest() for x in range(100)]
 482         initial_services = 12
 483         self.api_client = self.mock_keep_services(count=initial_services)
 484         self.keep_client = arvados.KeepClient(api_client=self.api_client)
 485         probes_before = [
 486             self.keep_client.weighted_service_roots(arvados.KeepLocator(hash)) for hash in hashes]
 487         for added_services in range(1, 12):
 488             api_client = self.mock_keep_services(count=initial_services+added_services)
 489             keep_client = arvados.KeepClient(api_client=api_client)
 490             total_penalty = 0
 491             for hash_index in range(len(hashes)):
 492                 probe_after = keep_client.weighted_service_roots(
 493                     arvados.KeepLocator(hashes[hash_index]))
 494                 penalty = probe_after.index(probes_before[hash_index][0])
 495                 self.assertLessEqual(penalty, added_services)
 496                 total_penalty += penalty
 497             # Average penalty per block should not exceed
 498             # N(added)/N(orig) by more than 20%, and should get closer
 499             # to the ideal as we add data points.
 500             expect_penalty = (
 501                 added_services *
 502                 len(hashes) / initial_services)
 503             max_penalty = (
 504                 expect_penalty *
 505                 (120 - added_services)/100)
 506             min_penalty = (
 507                 expect_penalty * 8/10)
 508             self.assertTrue(
 509                 min_penalty <= total_penalty <= max_penalty,
 510                 "With {}+{} services, {} blocks, penalty {} but expected {}..{}".format(
 511                     initial_services,
 512                     added_services,
 513                     len(hashes),
 514                     total_penalty,
 515                     min_penalty,
 516                     max_penalty))
 517
 518     def check_64_zeros_error_order(self, verb, exc_class):
 519         data = '0' * 64
 520         if verb == 'get':
 521             data = hashlib.md5(data).hexdigest() + '+1234'
 522         # Arbitrary port number:
 523         aport = random.randint(1024,65535)
 524         api_client = self.mock_keep_services(service_port=aport, count=self.services)
 525         keep_client = arvados.KeepClient(api_client=api_client)
 526         with mock.patch('pycurl.Curl') as curl_mock, \
 527              self.assertRaises(exc_class) as err_check:
 528             curl_mock.return_value.side_effect = socket.timeout
 529             getattr(keep_client, verb)(data)
 530         urls = [urlparse.urlparse(url)
 531                 for url in err_check.exception.request_errors()]
 532         self.assertEqual([('keep0x' + c, aport) for c in '3eab2d5fc9681074'],
 533                          [(url.hostname, url.port) for url in urls])
 534
 535     def test_get_error_shows_probe_order(self):
 536         self.check_64_zeros_error_order('get', arvados.errors.KeepReadError)
 537
 538     def test_put_error_shows_probe_order(self):
 539         self.check_64_zeros_error_order('put', arvados.errors.KeepWriteError)
 540
 541
 542 class KeepClientTimeout(unittest.TestCase, tutil.ApiClientMock):
 543     DATA = 'x' * 2**10
 544
 545     class assertTakesBetween(unittest.TestCase):
 546         def __init__(self, tmin, tmax):
 547             self.tmin = tmin
 548             self.tmax = tmax
 549
 550         def __enter__(self):
 551             self.t0 = time.time()
 552
 553         def __exit__(self, *args, **kwargs):
 554             self.assertGreater(time.time() - self.t0, self.tmin)
 555             self.assertLess(time.time() - self.t0, self.tmax)
 556
 557     def setUp(self):
 558         sock = socket.socket()
 559         sock.bind(('0.0.0.0', 0))
 560         self.port = sock.getsockname()[1]
 561         sock.close()
 562         self.server = keepstub.Server(('0.0.0.0', self.port), keepstub.Handler)
 563         self.thread = threading.Thread(target=self.server.serve_forever)
 564         self.thread.daemon = True # Exit thread if main proc exits
 565         self.thread.start()
 566         self.api_client = self.mock_keep_services(
 567             count=1,
 568             service_host='localhost',
 569             service_port=self.port,
 570         )
 571
 572     def tearDown(self):
 573         self.server.shutdown()
 574
 575     def keepClient(self, timeouts=(0.1, 1.0)):
 576         return arvados.KeepClient(
 577             api_client=self.api_client,
 578             timeout=timeouts)
 579
 580     def test_timeout_slow_connect(self):
 581         # Can't simulate TCP delays with our own socket. Leave our
 582         # stub server running uselessly, and try to connect to an
 583         # unroutable IP address instead.
 584         self.api_client = self.mock_keep_services(
 585             count=1,
 586             service_host='240.0.0.0',
 587         )
 588         with self.assertTakesBetween(0.1, 0.5):
 589             with self.assertRaises(arvados.errors.KeepWriteError):
 590                 self.keepClient((0.1, 1)).put(self.DATA, copies=1, num_retries=0)
 591
 592     def test_timeout_slow_request(self):
 593         self.server.setdelays(request=0.2)
 594         self._test_200ms()
 595
 596     def test_timeout_slow_response(self):
 597         self.server.setdelays(response=0.2)
 598         self._test_200ms()
 599
 600     def test_timeout_slow_response_body(self):
 601         self.server.setdelays(response_body=0.2)
 602         self._test_200ms()
 603
 604     def _test_200ms(self):
 605         """Connect should be t<100ms, request should be 200ms <= t < 300ms"""
 606
 607         # Allow 100ms to connect, then 1s for response. Everything
 608         # should work, and everything should take at least 200ms to
 609         # return.
 610         kc = self.keepClient((.1, 1))
 611         with self.assertTakesBetween(.2, .3):
 612             loc = kc.put(self.DATA, copies=1, num_retries=0)
 613         with self.assertTakesBetween(.2, .3):
 614             self.assertEqual(self.DATA, kc.get(loc, num_retries=0))
 615
 616         # Allow 1s to connect, then 100ms for response. Nothing should
 617         # work, and everything should take at least 100ms to return.
 618         kc = self.keepClient((1, .1))
 619         with self.assertTakesBetween(.1, .2):
 620             with self.assertRaises(arvados.errors.KeepReadError):
 621                 kc.get(loc, num_retries=0)
 622         with self.assertTakesBetween(.1, .2):
 623             with self.assertRaises(arvados.errors.KeepWriteError):
 624                 kc.put(self.DATA, copies=1, num_retries=0)
 625
 626
 627 class KeepClientGatewayTestCase(unittest.TestCase, tutil.ApiClientMock):
 628     def mock_disks_and_gateways(self, disks=3, gateways=1):
 629         self.gateways = [{
 630                 'uuid': 'zzzzz-bi6l4-gateway{:08d}'.format(i),
 631                 'owner_uuid': 'zzzzz-tpzed-000000000000000',
 632                 'service_host': 'gatewayhost{}'.format(i),
 633                 'service_port': 12345,
 634                 'service_ssl_flag': True,
 635                 'service_type': 'gateway:test',
 636         } for i in range(gateways)]
 637         self.gateway_roots = [
 638             "https://{service_host}:{service_port}/".format(**gw)
 639             for gw in self.gateways]
 640         self.api_client = self.mock_keep_services(
 641             count=disks, additional_services=self.gateways)
 642         self.keepClient = arvados.KeepClient(api_client=self.api_client)
 643
 644     @mock.patch('pycurl.Curl')
 645     def test_get_with_gateway_hint_first(self, MockCurl):
 646         MockCurl.return_value = tutil.FakeCurl.make(
 647             code=200, body='foo', headers={'Content-Length': 3})
 648         self.mock_disks_and_gateways()
 649         locator = 'acbd18db4cc2f85cedef654fccc4a4d8+3+K@' + self.gateways[0]['uuid']
 650         self.assertEqual('foo', self.keepClient.get(locator))
 651         self.assertEqual(self.gateway_roots[0]+locator,
 652                          MockCurl.return_value.getopt(pycurl.URL))
 653
 654     @mock.patch('pycurl.Curl')
 655     def test_get_with_gateway_hints_in_order(self, MockCurl):
 656         gateways = 4
 657         disks = 3
 658         mocks = [
 659             tutil.FakeCurl.make(code=404, body='')
 660             for _ in range(gateways+disks)
 661         ]
 662         MockCurl.side_effect = tutil.queue_with(mocks)
 663         self.mock_disks_and_gateways(gateways=gateways, disks=disks)
 664         locator = '+'.join(['acbd18db4cc2f85cedef654fccc4a4d8+3'] +
 665                            ['K@'+gw['uuid'] for gw in self.gateways])
 666         with self.assertRaises(arvados.errors.NotFoundError):
 667             self.keepClient.get(locator)
 668         # Gateways are tried first, in the order given.
 669         for i, root in enumerate(self.gateway_roots):
 670             self.assertEqual(root+locator,
 671                              mocks[i].getopt(pycurl.URL))
 672         # Disk services are tried next.
 673         for i in range(gateways, gateways+disks):
 674             self.assertRegexpMatches(
 675                 mocks[i].getopt(pycurl.URL),
 676                 r'keep0x')
 677
 678     @mock.patch('pycurl.Curl')
 679     def test_get_with_remote_proxy_hint(self, MockCurl):
 680         MockCurl.return_value = tutil.FakeCurl.make(
 681             code=200, body='foo', headers={'Content-Length': 3})
 682         self.mock_disks_and_gateways()
 683         locator = 'acbd18db4cc2f85cedef654fccc4a4d8+3+K@xyzzy'
 684         self.assertEqual('foo', self.keepClient.get(locator))
 685         self.assertEqual('https://keep.xyzzy.arvadosapi.com/'+locator,
 686                          MockCurl.return_value.getopt(pycurl.URL))
 687
 688
 689 class KeepClientRetryTestMixin(object):
 690     # Testing with a local Keep store won't exercise the retry behavior.
 691     # Instead, our strategy is:
 692     # * Create a client with one proxy specified (pointed at a black
 693     #   hole), so there's no need to instantiate an API client, and
 694     #   all HTTP requests come from one place.
 695     # * Mock httplib's request method to provide simulated responses.
 696     # This lets us test the retry logic extensively without relying on any
 697     # supporting servers, and prevents side effects in case something hiccups.
 698     # To use this mixin, define DEFAULT_EXPECT, DEFAULT_EXCEPTION, and
 699     # run_method().
 700     #
 701     # Test classes must define TEST_PATCHER to a method that mocks
 702     # out appropriate methods in the client.
 703
 704     PROXY_ADDR = 'http://[%s]:65535/' % (tutil.TEST_HOST,)
 705     TEST_DATA = 'testdata'
 706     TEST_LOCATOR = 'ef654c40ab4f1747fc699915d4f70902+8'
 707
 708     def setUp(self):
 709         self.client_kwargs = {'proxy': self.PROXY_ADDR, 'local_store': ''}
 710
 711     def new_client(self, **caller_kwargs):
 712         kwargs = self.client_kwargs.copy()
 713         kwargs.update(caller_kwargs)
 714         return arvados.KeepClient(**kwargs)
 715
 716     def run_method(self, *args, **kwargs):
 717         raise NotImplementedError("test subclasses must define run_method")
 718
 719     def check_success(self, expected=None, *args, **kwargs):
 720         if expected is None:
 721             expected = self.DEFAULT_EXPECT
 722         self.assertEqual(expected, self.run_method(*args, **kwargs))
 723
 724     def check_exception(self, error_class=None, *args, **kwargs):
 725         if error_class is None:
 726             error_class = self.DEFAULT_EXCEPTION
 727         self.assertRaises(error_class, self.run_method, *args, **kwargs)
 728
 729     def test_immediate_success(self):
 730         with self.TEST_PATCHER(self.DEFAULT_EXPECT, 200):
 731             self.check_success()
 732
 733     def test_retry_then_success(self):
 734         with self.TEST_PATCHER(self.DEFAULT_EXPECT, 500, 200):
 735             self.check_success(num_retries=3)
 736
 737     def test_no_default_retry(self):
 738         with self.TEST_PATCHER(self.DEFAULT_EXPECT, 500, 200):
 739             self.check_exception()
 740
 741     def test_no_retry_after_permanent_error(self):
 742         with self.TEST_PATCHER(self.DEFAULT_EXPECT, 403, 200):
 743             self.check_exception(num_retries=3)
 744
 745     def test_error_after_retries_exhausted(self):
 746         with self.TEST_PATCHER(self.DEFAULT_EXPECT, 500, 500, 200):
 747             self.check_exception(num_retries=1)
 748
 749     def test_num_retries_instance_fallback(self):
 750         self.client_kwargs['num_retries'] = 3
 751         with self.TEST_PATCHER(self.DEFAULT_EXPECT, 500, 200):
 752             self.check_success()
 753
 754
 755 @tutil.skip_sleep
 756 class KeepClientRetryGetTestCase(KeepClientRetryTestMixin, unittest.TestCase):
 757     DEFAULT_EXPECT = KeepClientRetryTestMixin.TEST_DATA
 758     DEFAULT_EXCEPTION = arvados.errors.KeepReadError
 759     HINTED_LOCATOR = KeepClientRetryTestMixin.TEST_LOCATOR + '+K@xyzzy'
 760     TEST_PATCHER = staticmethod(tutil.mock_keep_responses)
 761
 762     def run_method(self, locator=KeepClientRetryTestMixin.TEST_LOCATOR,
 763                    *args, **kwargs):
 764         return self.new_client().get(locator, *args, **kwargs)
 765
 766     def test_specific_exception_when_not_found(self):
 767         with tutil.mock_keep_responses(self.DEFAULT_EXPECT, 404, 200):
 768             self.check_exception(arvados.errors.NotFoundError, num_retries=3)
 769
 770     def test_general_exception_with_mixed_errors(self):
 771         # get should raise a NotFoundError if no server returns the block,
 772         # and a high threshold of servers report that it's not found.
 773         # This test rigs up 50/50 disagreement between two servers, and
 774         # checks that it does not become a NotFoundError.
 775         client = self.new_client()
 776         with tutil.mock_keep_responses(self.DEFAULT_EXPECT, 404, 500):
 777             with self.assertRaises(arvados.errors.KeepReadError) as exc_check:
 778                 client.get(self.HINTED_LOCATOR)
 779             self.assertNotIsInstance(
 780                 exc_check.exception, arvados.errors.NotFoundError,
 781                 "mixed errors raised NotFoundError")
 782
 783     def test_hint_server_can_succeed_without_retries(self):
 784         with tutil.mock_keep_responses(self.DEFAULT_EXPECT, 404, 200, 500):
 785             self.check_success(locator=self.HINTED_LOCATOR)
 786
 787     def test_try_next_server_after_timeout(self):
 788         with tutil.mock_keep_responses(
 789                 (socket.timeout("timed out"), 200),
 790                 (self.DEFAULT_EXPECT, 200)):
 791             self.check_success(locator=self.HINTED_LOCATOR)
 792
 793     def test_retry_data_with_wrong_checksum(self):
 794         with tutil.mock_keep_responses(
 795                 ('baddata', 200),
 796                 (self.DEFAULT_EXPECT, 200)):
 797             self.check_success(locator=self.HINTED_LOCATOR)
 798
 799
 800 @tutil.skip_sleep
 801 class KeepClientRetryPutTestCase(KeepClientRetryTestMixin, unittest.TestCase):
 802     DEFAULT_EXPECT = KeepClientRetryTestMixin.TEST_LOCATOR
 803     DEFAULT_EXCEPTION = arvados.errors.KeepWriteError
 804     TEST_PATCHER = staticmethod(tutil.mock_keep_responses)
 805
 806     def run_method(self, data=KeepClientRetryTestMixin.TEST_DATA,
 807                    copies=1, *args, **kwargs):
 808         return self.new_client().put(data, copies, *args, **kwargs)
 809
 810     def test_do_not_send_multiple_copies_to_same_server(self):
 811         with tutil.mock_keep_responses(self.DEFAULT_EXPECT, 200):
 812             self.check_exception(copies=2, num_retries=3)