From f21bb210446c4230bef9e5e50b4a9e9b1293bd3b Mon Sep 17 00:00:00 2001 From: Ward Vandewege Date: Fri, 12 Mar 2021 10:01:04 -0500 Subject: [PATCH] 17119: update the Makefile and tools/run-integration-tests.sh to make the arvados source path configurable. Arvados-DCO-1.1-Signed-off-by: Ward Vandewege --- Makefile | 4 +++- tools/run-integration-tests.sh | 11 +++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 6da3ed10..de88cd35 100644 --- a/Makefile +++ b/Makefile @@ -19,6 +19,8 @@ ITERATION?=1 TARGETS?="centos7 debian8 debian10 ubuntu1404 ubuntu1604 ubuntu1804 ubuntu2004" +ARVADOS_DIRECTORY?=unset + DESCRIPTION=Arvados Workbench2 - Arvados is a free and open source platform for big data science. MAINTAINER=Arvados Package Maintainers @@ -65,7 +67,7 @@ unit-tests: yarn-install integration-tests: yarn-install yarn run cypress install - $(WORKSPACE)/tools/run-integration-tests.sh + $(WORKSPACE)/tools/run-integration-tests.sh -a $(ARVADOS_DIRECTORY) integration-tests-in-docker: workbench2-build-image docker run -ti -v$(PWD):$(PWD) -w$(PWD) workbench2-build make integration-tests diff --git a/tools/run-integration-tests.sh b/tools/run-integration-tests.sh index 140de3c8..fbc456bd 100755 --- a/tools/run-integration-tests.sh +++ b/tools/run-integration-tests.sh @@ -10,7 +10,7 @@ cleanup() { set +e +o pipefail kill ${arvboot_PID} ${consume_stdout_PID} ${wb2_PID} ${consume_wb2_stdout_PID} wait ${arvboot_PID} ${consume_stdout_PID} ${wb2_PID} ${consume_wb2_stdout_PID} || true - if [ "${CLEANUP_ARVADOS_DIR}" -eq "1" ]; then + if [ ${CLEANUP_ARVADOS_DIR} -eq 1 ]; then rm -rf ${ARVADOS_DIR} fi echo >&2 "done" @@ -36,9 +36,9 @@ usage() { # Allow self-signed certs on 'wait-on' export NODE_TLS_REJECT_UNAUTHORIZED=0 +ARVADOS_DIR="unset" CLEANUP_ARVADOS_DIR=0 CYPRESS_MODE="run" -ARVADOS_DIR=`mktemp -d` WB2_DIR=`pwd` while getopts "ia:w:" o; do @@ -61,6 +61,13 @@ while getopts "ia:w:" o; do done shift $((OPTIND-1)) +if [ "${ARVADOS_DIR}" = "unset" ]; then + echo "ARVADOS_DIR is unset, creating a temporary directory for new checkout" + ARVADOS_DIR=`mktemp -d` +fi + +echo "ARVADOS_DIR is ${ARVADOS_DIR}" + ARVADOS_LOG=${ARVADOS_DIR}/arvados.log ARVADOS_CONF=${WB2_DIR}/tools/arvados_config.yml -- 2.30.2