From e49d3131c26d3ae5f08025cf82c02d08a91f994d Mon Sep 17 00:00:00 2001 From: Lucas Di Pentima Date: Sat, 21 Dec 2019 17:15:49 -0300 Subject: [PATCH] 15019: Adds Status filtering to project panel. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima --- .../project-panel-middleware-service.ts | 33 +++++++++++++++++-- src/views/project-panel/project-panel.tsx | 5 +-- 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/src/store/project-panel/project-panel-middleware-service.ts b/src/store/project-panel/project-panel-middleware-service.ts index d4b2416e..b889f7cb 100644 --- a/src/store/project-panel/project-panel-middleware-service.ts +++ b/src/store/project-panel/project-panel-middleware-service.ts @@ -29,7 +29,7 @@ import { ListResults } from '~/services/common-service/common-service'; import { loadContainers } from '~/store/processes/processes-actions'; import { ResourceKind } from '~/models/resource'; import { getSortColumn } from "~/store/data-explorer/data-explorer-reducer"; -import { serializeResourceTypeFilters } from '~/store/resource-type-filters/resource-type-filters'; +import { serializeResourceTypeFilters, ProcessStatusFilter } from '~/store/resource-type-filters/resource-type-filters'; import { updatePublicFavorites } from '~/store/public-favorites/public-favorites-actions'; export class ProjectPanelMiddlewareService extends DataExplorerMiddlewareService { @@ -103,6 +103,10 @@ export const getParams = (dataExplorer: DataExplorer, isProjectTrashed: boolean) export const getFilters = (dataExplorer: DataExplorer) => { const columns = dataExplorer.columns as DataColumns; const typeFilters = serializeResourceTypeFilters(getDataExplorerColumnFilters(columns, ProjectPanelColumnNames.TYPE)); + const statusColumnFilters = getDataExplorerColumnFilters(columns, 'Status'); + const activeStatusFilter = Object.keys(statusColumnFilters).find( + filterName => statusColumnFilters[filterName].selected + ); // TODO: Extract group contents name filter const nameFilters = new FilterBuilder() @@ -111,12 +115,35 @@ export const getFilters = (dataExplorer: DataExplorer) => { .addILike("name", dataExplorer.searchValue, GroupContentsResourcePrefix.PROJECT) .getFilters(); + // Filter by container status + const fb = new FilterBuilder(); + switch (activeStatusFilter) { + case ProcessStatusFilter.COMPLETED: { + fb.addEqual('container.state', 'Complete', GroupContentsResourcePrefix.PROCESS); + fb.addEqual('container.exit_code', '0', GroupContentsResourcePrefix.PROCESS); + break; + } + case ProcessStatusFilter.FAILED: { + fb.addEqual('container.state', 'Complete', GroupContentsResourcePrefix.PROCESS); + fb.addDistinct('container.exit_code', '0', GroupContentsResourcePrefix.PROCESS); + break; + } + case ProcessStatusFilter.CANCELLED: + case ProcessStatusFilter.FAILED: + case ProcessStatusFilter.LOCKED: + case ProcessStatusFilter.QUEUED: + case ProcessStatusFilter.RUNNING: { + fb.addEqual('container.state', activeStatusFilter, GroupContentsResourcePrefix.PROCESS); + break; + } + } + const statusFilters = fb.getFilters(); + return joinFilters( + statusFilters, typeFilters, nameFilters, ); - // TODO: Restore process status filters - // const statusFilters = getDataExplorerColumnFilters(columns, ProjectPanelColumnNames.STATUS); }; export const getOrder = (dataExplorer: DataExplorer) => { diff --git a/src/views/project-panel/project-panel.tsx b/src/views/project-panel/project-panel.tsx index df8f22e7..1e26bc0d 100644 --- a/src/views/project-panel/project-panel.tsx +++ b/src/views/project-panel/project-panel.tsx @@ -28,7 +28,7 @@ import { PROJECT_PANEL_CURRENT_UUID } from '~/store/project-panel/project-panel- import { DataTableDefaultView } from '~/components/data-table-default-view/data-table-default-view'; import { ArvadosTheme } from "~/common/custom-theme"; import { createTree } from '~/models/tree'; -import { getInitialResourceTypeFilters } from '~/store/resource-type-filters/resource-type-filters'; +import { getInitialResourceTypeFilters, getInitialProcessStatusFilters } from '~/store/resource-type-filters/resource-type-filters'; type CssRules = 'root' | "button"; @@ -69,7 +69,8 @@ export const projectPanelColumns: DataColumns = [ name: "Status", selected: true, configurable: true, - filters: createTree(), + mutuallyExclusiveFilters: true, + filters: getInitialProcessStatusFilters(), render: uuid => , }, { -- 2.30.2