From cb5f37e7238dfc9e216f6e9dc184c00fc8bd07f0 Mon Sep 17 00:00:00 2001 From: Lucas Di Pentima Date: Tue, 16 Nov 2021 11:45:30 -0300 Subject: [PATCH] 18215: Fixes unrelated test. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima --- cypress/integration/favorites.spec.js | 6 +++--- src/views/collection-panel/collection-panel.tsx | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cypress/integration/favorites.spec.js b/cypress/integration/favorites.spec.js index 9f4e2b84..13a2c467 100644 --- a/cypress/integration/favorites.spec.js +++ b/cypress/integration/favorites.spec.js @@ -150,7 +150,7 @@ describe('Favorites tests', function () { cy.getAll('@mySharedWritableProject', '@testTargetCollection') .then(function ([mySharedWritableProject, testTargetCollection]) { cy.loginAs(adminUser); - + cy.get('[data-cy=side-panel-tree]').contains('My Favorites').click(); const newProjectName = `New project name ${mySharedWritableProject.name}`; @@ -160,7 +160,7 @@ describe('Favorites tests', function () { cy.testEditProjectOrCollection('main', mySharedWritableProject.name, newProjectName, newProjectDescription); cy.testEditProjectOrCollection('main', testTargetCollection.name, newCollectionName, newCollectionDescription, false); - + cy.get('[data-cy=side-panel-tree]').contains('Projects').click(); cy.get('main').contains(newProjectName).rightclick(); @@ -171,7 +171,7 @@ describe('Favorites tests', function () { cy.get('[data-cy=side-panel-tree]').contains('Public Favorites').click(); cy.testEditProjectOrCollection('main', newProjectName, mySharedWritableProject.name, 'newProjectDescription'); - cy.testEditProjectOrCollection('main', newCollectionName, testTargetCollection.name, 'newCollectionDescription', false); + cy.testEditProjectOrCollection('main', newCollectionName, testTargetCollection.name, 'newCollectionDescription', false); }); }); diff --git a/src/views/collection-panel/collection-panel.tsx b/src/views/collection-panel/collection-panel.tsx index 4270cbbd..e78b1f3d 100644 --- a/src/views/collection-panel/collection-panel.tsx +++ b/src/views/collection-panel/collection-panel.tsx @@ -120,7 +120,7 @@ export const CollectionPanel = withStyles(styles)( isWritable = true; } else { const itemOwner = getResource(item.ownerUuid)(state.resources); - if (itemOwner) { + if (itemOwner && itemOwner.writableBy) { isWritable = itemOwner.writableBy.indexOf(currentUserUUID || '') >= 0; } } -- 2.30.2