From 87636089f8b7d150a2987cafd48a2ca7dd6c24f9 Mon Sep 17 00:00:00 2001 From: Michal Klobukowski Date: Sun, 25 Nov 2018 22:21:03 +0100 Subject: [PATCH] Restore type filters to trash panel Feature #14258 Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski --- .../trash-panel-middleware-service.ts | 26 +++++++++++++------ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/src/store/trash-panel/trash-panel-middleware-service.ts b/src/store/trash-panel/trash-panel-middleware-service.ts index e6cee25e..f52421a1 100644 --- a/src/store/trash-panel/trash-panel-middleware-service.ts +++ b/src/store/trash-panel/trash-panel-middleware-service.ts @@ -23,6 +23,9 @@ import { snackbarActions, SnackbarKind } from "~/store/snackbar/snackbar-actions import { updateResources } from "~/store/resources/resources-actions"; import { progressIndicatorActions } from "~/store/progress-indicator/progress-indicator-actions"; import { getSortColumn } from "~/store/data-explorer/data-explorer-reducer"; +import { serializeResourceTypeFilters } from '~/store//resource-type-filters/resource-type-filters'; +import { getDataExplorerColumnFilters } from '~/store/data-explorer/data-explorer-middleware-service'; +import { joinFilters } from '../../services/api/filter-builder'; export class TrashPanelMiddlewareService extends DataExplorerMiddlewareService { constructor(private services: ServiceRepository, id: string) { @@ -33,7 +36,20 @@ export class TrashPanelMiddlewareService extends DataExplorerMiddlewareService { const dataExplorer = api.getState().dataExplorer[this.getId()]; const columns = dataExplorer.columns as DataColumns; const sortColumn = getSortColumn(dataExplorer); - const typeFilters = this.getColumnFilters(columns, TrashPanelColumnNames.TYPE); + + const typeFilters = serializeResourceTypeFilters(getDataExplorerColumnFilters(columns, ProjectPanelColumnNames.TYPE)); + + const otherFilters = new FilterBuilder() + .addILike("name", dataExplorer.searchValue, GroupContentsResourcePrefix.COLLECTION) + .addILike("name", dataExplorer.searchValue, GroupContentsResourcePrefix.PROCESS) + .addILike("name", dataExplorer.searchValue, GroupContentsResourcePrefix.PROJECT) + .addEqual("is_trashed", true) + .getFilters(); + + const filters = joinFilters( + typeFilters, + otherFilters, + ); const order = new OrderBuilder(); @@ -55,13 +71,7 @@ export class TrashPanelMiddlewareService extends DataExplorerMiddlewareService { .contents(userUuid, { ...dataExplorerToListParams(dataExplorer), order: order.getOrder(), - filters: new FilterBuilder() - // TODO: update filters - // .addIsA("uuid", typeFilters.map(f => f.type)) - .addILike("name", dataExplorer.searchValue, GroupContentsResourcePrefix.COLLECTION) - .addILike("name", dataExplorer.searchValue, GroupContentsResourcePrefix.PROJECT) - .addEqual("is_trashed", true) - .getFilters(), + filters, recursive: true, includeTrash: true }); -- 2.30.2