From 65128fdb69ac9f7bd2f4653ee1bea95a9ab59559 Mon Sep 17 00:00:00 2001
From: Stephen Smith <stephen@curii.com>
Date: Tue, 20 Sep 2022 13:12:57 -0400
Subject: [PATCH] 16073: Make default view icon optional, hide tabs when panel
 is empty

Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>
---
 src/components/default-view/default-view.tsx |  4 +-
 src/views/process-panel/process-io-card.tsx  | 70 +++++++++++---------
 2 files changed, 40 insertions(+), 34 deletions(-)

diff --git a/src/components/default-view/default-view.tsx b/src/components/default-view/default-view.tsx
index 014b8cc4..5acea619 100644
--- a/src/components/default-view/default-view.tsx
+++ b/src/components/default-view/default-view.tsx
@@ -29,7 +29,7 @@ export interface DefaultViewDataProps {
     messages: string[];
     filtersApplied?: boolean;
     classMessage?: string;
-    icon: IconType;
+    icon?: IconType;
     classIcon?: string;
 }
 
@@ -38,7 +38,7 @@ type DefaultViewProps = DefaultViewDataProps & WithStyles<CssRules>;
 export const DefaultView = withStyles(styles)(
     ({ classes, classRoot, messages, classMessage, icon: Icon, classIcon }: DefaultViewProps) =>
         <Typography className={classnames([classes.root, classRoot])} component="div">
-            <Icon className={classnames([classes.icon, classIcon])} />
+            {Icon && <Icon className={classnames([classes.icon, classIcon])} />}
             {messages.map((msg: string, index: number) => {
                 return <Typography key={index}
                     className={classnames([classes.message, classMessage])}>{msg}</Typography>;
diff --git a/src/views/process-panel/process-io-card.tsx b/src/views/process-panel/process-io-card.tsx
index 282ce936..f54fac85 100644
--- a/src/views/process-panel/process-io-card.tsx
+++ b/src/views/process-panel/process-io-card.tsx
@@ -225,40 +225,46 @@ export const ProcessIOCard = withStyles(styles)(connect(null, mapDispatchToProps
                 <div>
                     {mainProcess ?
                         (<>
-                            <Tabs value={mainProcTabState} onChange={handleMainProcTabChange} variant="fullWidth" className={classes.symmetricTabs}>
-                                <Tab label="Parameters" />
-                                <Tab label="JSON" />
-                            </Tabs>
-                            {mainProcTabState === 0 && <div className={classes.tableWrapper}>
-                                {params.length ?
-                                    <ProcessIOPreview data={params} showImagePreview={showImagePreview} /> :
-                                    <Grid container item alignItems='center' justify='center'>
-                                        <DefaultView messages={["No parameters found"]} icon={InfoIcon} />
-                                    </Grid>}
-                                </div>}
-                            {mainProcTabState === 1 && <div className={classes.tableWrapper}>
-                                {params.length ?
-                                    <ProcessIORaw data={raw || params} /> :
-                                    <Grid container item alignItems='center' justify='center'>
-                                        <DefaultView messages={["No parameters found"]} icon={InfoIcon} />
-                                    </Grid>}
-                                </div>}
+                            {params.length ?
+                                <>
+                                    <Tabs value={mainProcTabState} onChange={handleMainProcTabChange} variant="fullWidth" className={classes.symmetricTabs}>
+                                        <Tab label="Parameters" />
+                                        <Tab label="JSON" />
+                                    </Tabs>
+                                    {mainProcTabState === 0 && <div className={classes.tableWrapper}>
+                                            <ProcessIOPreview data={params} showImagePreview={showImagePreview} />
+                                        </div>}
+                                    {mainProcTabState === 1 && <div className={classes.tableWrapper}>
+                                            <ProcessIORaw data={raw || params} />
+                                        </div>}
+                                </> :
+                                <Grid container item alignItems='center' justify='center'>
+                                    <DefaultView messages={["No parameters found"]} />
+                                </Grid>
+                            }
                         </>) :
                         (<>
-                            <Tabs value={0} variant="fullWidth" className={classes.symmetricTabs}>
-                                {label === ProcessIOCardType.INPUT && <Tab label="Collections" />}
-                                {label === ProcessIOCardType.OUTPUT && <Tab label="Collection" />}
-                            </Tabs>
-                            <div className={classes.tableWrapper}>
-                                {label === ProcessIOCardType.INPUT && <ProcessInputMounts mounts={mounts || []} />}
-                                {label === ProcessIOCardType.OUTPUT && <>
-                                    {outputUuid && <Typography className={classes.collectionLink}>
-                                        Output Collection: <MuiLink className={classes.keepLink} onClick={() => {navigateTo(outputUuid)}}>
-                                        {outputUuid}
-                                    </MuiLink></Typography>}
-                                    <ProcessOutputCollectionFiles isWritable={false} currentItemUuid={outputUuid} />
-                                </>}
-                            </div>
+                            {((mounts && mounts.length) || outputUuid) ?
+                                <>
+                                    <Tabs value={0} variant="fullWidth" className={classes.symmetricTabs}>
+                                        {label === ProcessIOCardType.INPUT && <Tab label="Collections" />}
+                                        {label === ProcessIOCardType.OUTPUT && <Tab label="Collection" />}
+                                    </Tabs>
+                                    <div className={classes.tableWrapper}>
+                                        {label === ProcessIOCardType.INPUT && <ProcessInputMounts mounts={mounts || []} />}
+                                        {label === ProcessIOCardType.OUTPUT && <>
+                                            {outputUuid && <Typography className={classes.collectionLink}>
+                                                Output Collection: <MuiLink className={classes.keepLink} onClick={() => {navigateTo(outputUuid || "")}}>
+                                                {outputUuid}
+                                            </MuiLink></Typography>}
+                                            <ProcessOutputCollectionFiles isWritable={false} currentItemUuid={outputUuid} />
+                                        </>}
+                                    </div>
+                                </> :
+                                <Grid container item alignItems='center' justify='center'>
+                                    <DefaultView messages={["No collection(s) found"]} />
+                                </Grid>
+                            }
                         </>)
                     }
                 </div>
-- 
2.39.5