From: Stephen Smith Date: Thu, 12 May 2022 17:35:52 +0000 (-0400) Subject: 19049: Make participant select read only when editing vm logins X-Git-Tag: 2.4.1~1^2~4^2~6 X-Git-Url: https://git.arvados.org/arvados-workbench2.git/commitdiff_plain/8da1b3425ad850194d473df1436ac61b6312d452 19049: Make participant select read only when editing vm logins Arvados-DCO-1.1-Signed-off-by: Stephen Smith --- diff --git a/src/components/autocomplete/autocomplete.tsx b/src/components/autocomplete/autocomplete.tsx index cc184336..0044807b 100644 --- a/src/components/autocomplete/autocomplete.tsx +++ b/src/components/autocomplete/autocomplete.tsx @@ -175,7 +175,7 @@ export class Autocomplete extends React.Component onDelete ? onDelete(item, index) : undefined} /> + onDelete={onDelete && !this.props.disabled ? (() => onDelete(item, index)) : undefined} /> ); } diff --git a/src/views-components/sharing-dialog/participant-select.tsx b/src/views-components/sharing-dialog/participant-select.tsx index a5d39479..eb7e8d10 100644 --- a/src/views-components/sharing-dialog/participant-select.tsx +++ b/src/views-components/sharing-dialog/participant-select.tsx @@ -28,6 +28,7 @@ interface ParticipantSelectProps { label?: string; autofocus?: boolean; onlyPeople?: boolean; + disabled?: boolean; onBlur?: (event: React.FocusEvent) => void; onFocus?: (event: React.FocusEvent) => void; @@ -72,11 +73,12 @@ export const ParticipantSelect = connect()( onChange={this.handleChange} onCreate={this.handleCreate} onSelect={this.handleSelect} - onDelete={this.handleDelete} + onDelete={this.props.onDelete && !this.props.disabled ? this.handleDelete : undefined} onFocus={this.props.onFocus} onBlur={this.props.onBlur} renderChipValue={this.renderChipValue} - renderSuggestion={this.renderSuggestion} /> + renderSuggestion={this.renderSuggestion} + disabled={this.props.disabled}/> ); } diff --git a/src/views-components/virtual-machines-dialog/add-login-dialog.tsx b/src/views-components/virtual-machines-dialog/add-login-dialog.tsx index d9547d7c..51773418 100644 --- a/src/views-components/virtual-machines-dialog/add-login-dialog.tsx +++ b/src/views-components/virtual-machines-dialog/add-login-dialog.tsx @@ -35,7 +35,7 @@ const AddLoginFormFields = (props) => { return <> { ; } - interface UserFieldProps { excludedParticipants: string[]; } @@ -61,3 +60,10 @@ const UserSelect = (props) => excludedParticipants={props.excludedParticipants} onSelect={props.input.onChange} onDelete={() => (props.input.onChange(''))} />; + +const ReadOnlyUserSelect = (props) => + ;