From: Lucas Di Pentima Date: Fri, 8 Apr 2022 20:28:52 +0000 (-0300) Subject: 18881: Adds timeouts to flaky tests to avoid false negatives. X-Git-Tag: 2.4.1~5^2~2 X-Git-Url: https://git.arvados.org/arvados-workbench2.git/commitdiff_plain/078bedef5794ee91497d4dd12157c86d6e490969 18881: Adds timeouts to flaky tests to avoid false negatives. Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima --- diff --git a/cypress/integration/collection.spec.js b/cypress/integration/collection.spec.js index 74acd056..39a2af42 100644 --- a/cypress/integration/collection.spec.js +++ b/cypress/integration/collection.spec.js @@ -252,8 +252,8 @@ describe('Collection panel tests', function () { .and('not.contain', 'anotherKey: anotherValue'); // Check that the file listing show both read & write operations cy.get('[data-cy=collection-files-panel]').within(() => { - cy.wait(1000); - cy.root().should('contain', fileName); + cy.get('[data-cy=collection-files-right-panel]', { timeout: 5000 }) + .should('contain', fileName); if (isWritable) { cy.get('[data-cy=upload-button]') .should(`${isWritable ? '' : 'not.'}contain`, 'Upload data'); @@ -335,7 +335,7 @@ describe('Collection panel tests', function () { ]; eachPair(names, (from, to) => { cy.get('[data-cy=collection-files-panel]') - .contains(`${from}`).rightclick(); + .contains(`${from}`).rightclick({force: true}); cy.get('[data-cy=context-menu]') .contains('Rename') .click(); @@ -842,7 +842,7 @@ describe('Collection panel tests', function () { cy.get('[data-cy=form-submit-btn]').click(); - cy.get('.layout-pane-primary', { wait: 12000 }).contains('Projects').click(); + cy.get('.layout-pane-primary', { timeout: 12000 }).contains('Projects').click(); cy.get('main').contains(`Files extracted from: ${this.collection.name}`).should('exist'); }); @@ -976,7 +976,6 @@ describe('Collection panel tests', function () { cy.get('[data-cy=form-submit-btn]').should('not.exist'); cy.get('[data-cy=collection-files-right-panel]') .contains('5mb_b.bin').should('exist'); - }); }); });