18029: Fix divide by zero on empty pagination by defaulting to 0
authorStephen Smith <stephen@curii.com>
Fri, 10 Sep 2021 18:03:19 +0000 (14:03 -0400)
committerStephen Smith <stephen@curii.com>
Fri, 10 Sep 2021 18:03:19 +0000 (14:03 -0400)
Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen@curii.com>

src/store/all-processes-panel/all-processes-panel-middleware-service.ts
src/store/collections-content-address-panel/collections-content-address-middleware-service.ts
src/store/favorite-panel/favorite-panel-middleware-service.ts
src/store/public-favorites-panel/public-favorites-middleware-service.ts

index 88b64e6243955f7a9e15d90e51176efc29932bad..05c8882dc8b73e3f7f0073f4049f14d898e24a34 100644 (file)
@@ -45,7 +45,7 @@ export class AllProcessesPanelMiddlewareService extends DataExplorerMiddlewareSe
                 api.dispatch(allProcessesPanelActions.SET_ITEMS({
                     items: processItems.items.map((resource: any) => resource.uuid),
                     itemsAvailable: processItems.itemsAvailable,
-                    page: Math.floor(processItems.offset / processItems.limit),
+                    page: Math.floor(processItems.offset / processItems.limit) || 0,
                     rowsPerPage: processItems.limit
                 }));
             } catch {
index 983b309aa4543f1edf0c8d5a903ffc48b552411b..42bb476b22e458110a56e2ffff8897cf103e5dc7 100644 (file)
@@ -112,7 +112,7 @@ export class CollectionsWithSameContentAddressMiddlewareService extends DataExpl
                     api.dispatch(collectionsContentAddressActions.SET_ITEMS({
                         items: response.items.map((resource: any) => resource.uuid),
                         itemsAvailable: response.itemsAvailable,
-                        page: Math.floor(response.offset / response.limit),
+                        page: Math.floor(response.offset / response.limit) || 0,
                         rowsPerPage: response.limit
                     }));
                 }
index f88f7b914d3ace2a5bd1e7fe75b77ebbe8fd89ba..7177e5a7a717e24460ea552d543edee241b3ab12 100644 (file)
@@ -103,7 +103,7 @@ export class FavoritePanelMiddlewareService extends DataExplorerMiddlewareServic
                 api.dispatch(favoritePanelActions.SET_ITEMS({
                     items: response.items.map((resource: any) => resource.uuid),
                     itemsAvailable: response.itemsAvailable,
-                    page: Math.floor(response.offset / response.limit),
+                    page: Math.floor(response.offset / response.limit) || 0,
                     rowsPerPage: response.limit
                 }));
                 api.dispatch<any>(updateFavorites(response.items.map((item: any) => item.uuid)));
index dd21a38026642c3cf576c957d6b98559d2a9a302..8a8876c150dc5b141f4719ee5d7fd875f2bb1394 100644 (file)
@@ -100,7 +100,7 @@ export class PublicFavoritesMiddlewareService extends DataExplorerMiddlewareServ
                 api.dispatch(publicFavoritePanelActions.SET_ITEMS({
                     items: response.items.map((resource: any) => resource.uuid),
                     itemsAvailable: response.itemsAvailable,
-                    page: Math.floor(response.offset / response.limit),
+                    page: Math.floor(response.offset / response.limit) || 0,
                     rowsPerPage: response.limit
                 }));
                 api.dispatch<any>(updatePublicFavorites(response.items.map((item: any) => item.uuid)));