next conflicts 14504-users-admin-panel
authorPawel Kowalczyk <pawel.kowalczyk@contractors.roche.com>
Fri, 7 Dec 2018 10:05:13 +0000 (11:05 +0100)
committerPawel Kowalczyk <pawel.kowalczyk@contractors.roche.com>
Fri, 7 Dec 2018 10:05:13 +0000 (11:05 +0100)
Feature #14504

Arvados-DCO-1.1-Signed-off-by: Pawel Kowalczyk <pawel.kowalczyk@contractors.roche.com>

14 files changed:
1  2 
src/index.tsx
src/routes/route-change-handlers.ts
src/routes/routes.ts
src/store/advanced-tab/advanced-tab.ts
src/store/navigation/navigation-action.ts
src/store/project-panel/project-panel-middleware-service.ts
src/store/store.ts
src/store/users/user-panel-middleware-service.ts
src/store/workbench/workbench-actions.ts
src/store/workflow-panel/workflow-middleware-service.ts
src/views-components/context-menu/context-menu.tsx
src/views-components/main-app-bar/account-menu.tsx
src/views-components/main-content-bar/main-content-bar.tsx
src/views/workbench/workbench.tsx

diff --cc src/index.tsx
index 87af8f1deb5ecd8b22e2ce270e27f48c8569c582,c33ef7c1e4a18630a04f9c76627e24131fc1f56b..8f702af164bdabc1945ca99d42f9bb7742c0af5c
@@@ -53,8 -53,8 +53,9 @@@ import { sshKeyActionSet } from '~/view
  import { keepServiceActionSet } from '~/views-components/context-menu/action-sets/keep-service-action-set';
  import { loadVocabulary } from '~/store/vocabulary/vocabulary-actions';
  import { virtualMachineActionSet } from '~/views-components/context-menu/action-sets/virtual-machine-action-set';
 +import { userActionSet } from '~/views-components/context-menu/action-sets/user-action-set';
  import { computeNodeActionSet } from '~/views-components/context-menu/action-sets/compute-node-action-set';
+ import { apiClientAuthorizationActionSet } from '~/views-components/context-menu/action-sets/api-client-authorization-action-set';
  
  console.log(`Starting arvados [${getBuildInfo()}]`);
  
@@@ -75,8 -75,8 +76,9 @@@ addMenuActionSet(ContextMenuKind.REPOSI
  addMenuActionSet(ContextMenuKind.SSH_KEY, sshKeyActionSet);
  addMenuActionSet(ContextMenuKind.VIRTUAL_MACHINE, virtualMachineActionSet);
  addMenuActionSet(ContextMenuKind.KEEP_SERVICE, keepServiceActionSet);
 +addMenuActionSet(ContextMenuKind.USER, userActionSet);
  addMenuActionSet(ContextMenuKind.NODE, computeNodeActionSet);
+ addMenuActionSet(ContextMenuKind.API_CLIENT_AUTHORIZATION, apiClientAuthorizationActionSet);
  
  fetchConfig()
      .then(({ config, apiHost }) => {
index 5b281b830dc1f38ac695a3ecf3e75afa7fa8e31e,a733e42f7e902a7aa912ff9482de9e000627b0b3..e2454d63ac1aea6eaa6d1ac0fcba9dc0e384dd4e
@@@ -31,8 -31,8 +31,9 @@@ const handleLocationChange = (store: Ro
      const sshKeysMatch = Routes.matchSshKeysRoute(pathname);
      const keepServicesMatch = Routes.matchKeepServicesRoute(pathname);
      const computeNodesMatch = Routes.matchComputeNodesRoute(pathname);
+     const apiClientAuthorizationsMatch = Routes.matchApiClientAuthorizationsRoute(pathname);
      const myAccountMatch = Routes.matchMyAccountRoute(pathname);
 +    const userMatch = Routes.matchUsersRoute(pathname);
  
      if (projectMatch) {
          store.dispatch(WorkbenchActions.loadProject(projectMatch.params.id));
          store.dispatch(WorkbenchActions.loadKeepServices);
      } else if (computeNodesMatch) {
          store.dispatch(WorkbenchActions.loadComputeNodes);
+     } else if (apiClientAuthorizationsMatch) {
+         store.dispatch(WorkbenchActions.loadApiClientAuthorizations);
      } else if (myAccountMatch) {
          store.dispatch(WorkbenchActions.loadMyAccount);
 +    }else if (userMatch) {
 +        store.dispatch(WorkbenchActions.loadUsers);
      }
  };
index dabb9bf579884824c35150e410a0cbe673cc862a,7f15a8de74bb52c47e67a5f1e608a1e3ab0df9cf..88dfd46951945928336079381035e70e1733ae07
@@@ -26,7 -26,7 +26,8 @@@ export const Routes = 
      MY_ACCOUNT: '/my-account',
      KEEP_SERVICES: `/keep-services`,
      COMPUTE_NODES: `/nodes`,
-     USERS: '/users'
++    USERS: '/users',
+     API_CLIENT_AUTHORIZATIONS: `/api_client_authorizations`
  };
  
  export const getResourceUrl = (uuid: string) => {
@@@ -99,8 -99,8 +100,11 @@@ export const matchMyAccountRoute = (rou
  export const matchKeepServicesRoute = (route: string) =>
      matchPath(route, { path: Routes.KEEP_SERVICES });
  
 +export const matchUsersRoute = (route: string) =>
 +    matchPath(route, { path: Routes.USERS });
 +
  export const matchComputeNodesRoute = (route: string) =>
      matchPath(route, { path: Routes.COMPUTE_NODES });
 -    matchPath(route, { path: Routes.API_CLIENT_AUTHORIZATIONS });
+ export const matchApiClientAuthorizationsRoute = (route: string) =>
++    matchPath(route, { path: Routes.API_CLIENT_AUTHORIZATIONS });
index 4da4d7e14ca233c437d99cc7bbd15e1aa26add08,a77ffcca8ca7c1b325937f0d6f7f5be98edd478c..851eb949a9a7036ce5e5231fd8aa280e7bbab61d
@@@ -74,8 -75,8 +75,9 @@@ enum ResourcePrefix 
      AUTORIZED_KEYS = 'authorized_keys',
      VIRTUAL_MACHINES = 'virtual_machines',
      KEEP_SERVICES = 'keep_services',
-     COMPUTE_NODES = 'nodes'
+     COMPUTE_NODES = 'nodes',
 +    USERS = 'users',
+     API_CLIENT_AUTHORIZATIONS = 'api_client_authorizations'
  }
  
  enum KeepServiceData {
@@@ -93,9 -89,14 +95,14 @@@ enum ComputeNodeData 
      PROPERTIES = 'properties'
  }
  
- type AdvanceResourceKind = CollectionData | ProcessData | ProjectData | RepositoryData | SshKeyData | VirtualMachineData | KeepServiceData | ComputeNodeData | UserData;
+ enum ApiClientAuthorizationsData {
+     API_CLIENT_AUTHORIZATION = 'api_client_authorization',
+     DEFAULT_OWNER_UUID = 'default_owner_uuid'
+ }
 -type AdvanceResourceKind = CollectionData | ProcessData | ProjectData | RepositoryData | SshKeyData | VirtualMachineData | KeepServiceData | ComputeNodeData | ApiClientAuthorizationsData;
++type AdvanceResourceKind = CollectionData | ProcessData | ProjectData | RepositoryData | SshKeyData | VirtualMachineData | KeepServiceData | ComputeNodeData | ApiClientAuthorizationsData | UserData;
  type AdvanceResourcePrefix = GroupContentsResourcePrefix | ResourcePrefix;
- type AdvanceResponseData = ContainerRequestResource | ProjectResource | CollectionResource | RepositoryResource | SshKeyResource | VirtualMachinesResource | KeepServiceResource | NodeResource | UserResource | undefined;
 -type AdvanceResponseData = ContainerRequestResource | ProjectResource | CollectionResource | RepositoryResource | SshKeyResource | VirtualMachinesResource | KeepServiceResource | NodeResource | ApiClientAuthorization | undefined;
++type AdvanceResponseData = ContainerRequestResource | ProjectResource | CollectionResource | RepositoryResource | SshKeyResource | VirtualMachinesResource | KeepServiceResource | NodeResource | ApiClientAuthorization | UserResource | undefined;
  
  export const openAdvancedTabDialog = (uuid: string) =>
      async (dispatch: Dispatch<any>, getState: () => RootState, services: ServiceRepository) => {
@@@ -538,5 -509,27 +560,27 @@@ const computeNodeApiResponse = (apiResp
  "properties": "${JSON.stringify(properties, null, 4)}",
  "info": "${JSON.stringify(info, null, 4)}"`;
  
 -        uuid, ownerUuid, apiToken, apiClientId, userId, createdByIpAddress, lastUsedByIpAddress, 
+     return response;
+ };
+ const apiClientAuthorizationApiResponse = (apiResponse: ApiClientAuthorization) => {
+     const {
++        uuid, ownerUuid, apiToken, apiClientId, userId, createdByIpAddress, lastUsedByIpAddress,
+         lastUsedAt, expiresAt, defaultOwnerUuid, scopes, updatedAt, createdAt
+     } = apiResponse;
+     const response = `"uuid": "${uuid}",
+ "owner_uuid": "${ownerUuid}",
+ "api_token": "${stringify(apiToken)}",
+ "api_client_id": "${stringify(apiClientId)}",
+ "user_id": "${stringify(userId)}",
+ "created_by_ip_address": "${stringify(createdByIpAddress)}",
+ "last_used_by_ip_address": "${stringify(lastUsedByIpAddress)}",
+ "last_used_at": "${stringify(lastUsedAt)}",
+ "expires_at": "${stringify(expiresAt)}",
+ "created_at": "${stringify(createdAt)}",
+ "updated_at": "${stringify(updatedAt)}",
+ "default_owner_uuid": "${stringify(defaultOwnerUuid)}",
+ "scopes": "${JSON.stringify(scopes, null, 4)}"`;
      return response;
  };
index bae16891ffb4ec9016b64479ebd97b94b7dc6538,067a9ac487f0869e038c00b67cd75c8f1f9d2985..8d68a4b6856e4179260a95315eac5158f4c8a95f
@@@ -74,4 -74,4 +74,6 @@@ export const navigateToKeepServices = p
  
  export const navigateToComputeNodes = push(Routes.COMPUTE_NODES);
  
 -export const navigateToApiClientAuthorizations = push(Routes.API_CLIENT_AUTHORIZATIONS);
 +export const navigateToUsers = push(Routes.USERS);
++
++export const navigateToApiClientAuthorizations = push(Routes.API_CLIENT_AUTHORIZATIONS);
index 257fc04477e86ded783a5a164879af4949772c80,f2cc8a9229d8fbe3798a732e32172f76c18fa555..58f158772240019b1b3a9873546cfd7b61e39ed6
@@@ -22,11 -22,11 +22,11 @@@ import { Dispatch, MiddlewareAPI } fro
  import { ProjectResource } from "~/models/project";
  import { updateResources } from "~/store/resources/resources-actions";
  import { getProperty } from "~/store/properties/properties";
 -import { snackbarActions, SnackbarKind } from '../snackbar/snackbar-actions';
 +import { snackbarActions, SnackbarKind } from '~/store/snackbar/snackbar-actions';
  import { progressIndicatorActions } from '~/store/progress-indicator/progress-indicator-actions.ts';
 -import { DataExplorer, getDataExplorer } from '../data-explorer/data-explorer-reducer';
 +import { DataExplorer, getDataExplorer } from '~/store/data-explorer/data-explorer-reducer';
- import { ListResults } from '~/services/common-service/common-resource-service';
+ import { ListResults } from '~/services/common-service/common-service';
 -import { loadContainers } from '../processes/processes-actions';
 +import { loadContainers } from '~/store/processes/processes-actions';
  import { ResourceKind } from '~/models/resource';
  import { getResource } from "~/store/resources/resources";
  import { CollectionResource } from "~/models/collection";
index 1862d6f0e42eb658ea5c564b54cc401ffc4e1586,eef047508274ba2bf6cba1f3be5e6534540b6111..2b0ada81afec1a8869a7629ccf89546a20982172
@@@ -46,9 -46,8 +46,10 @@@ import { resourcesDataReducer } from "~
  import { virtualMachinesReducer } from "~/store/virtual-machines/virtual-machines-reducer";
  import { repositoriesReducer } from '~/store/repositories/repositories-reducer';
  import { keepServicesReducer } from '~/store/keep-services/keep-services-reducer';
 +import { UserMiddlewareService } from '~/store/users/user-panel-middleware-service';
 +import { USERS_PANEL_ID } from '~/store/users/users-actions';
  import { computeNodesReducer } from '~/store/compute-nodes/compute-nodes-reducer';
+ import { apiClientAuthorizationsReducer } from '~/store/api-client-authorizations/api-client-authorizations-reducer';
  
  const composeEnhancers =
      (process.env.NODE_ENV === 'development' &&
index 2f60209368ffc48afd266216e28f97398fc769ff,0000000000000000000000000000000000000000..bc4bb130ae39797160eb3200c53adad51b30e101
mode 100644,000000..100644
--- /dev/null
@@@ -1,78 -1,0 +1,78 @@@
- import { ListResults } from '~/services/common-service/common-resource-service';
 +// Copyright (C) The Arvados Authors. All rights reserved.
 +//
 +// SPDX-License-Identifier: AGPL-3.0
 +
 +import { ServiceRepository } from '~/services/services';
 +import { MiddlewareAPI, Dispatch } from 'redux';
 +import { DataExplorerMiddlewareService, dataExplorerToListParams, listResultsToDataExplorerItemsMeta } from '~/store/data-explorer/data-explorer-middleware-service';
 +import { RootState } from '~/store/store';
 +import { snackbarActions, SnackbarKind } from '~/store/snackbar/snackbar-actions';
 +import { DataExplorer, getDataExplorer } from '~/store/data-explorer/data-explorer-reducer';
 +import { updateResources } from '~/store/resources/resources-actions';
 +import { FilterBuilder } from '~/services/api/filter-builder';
 +import { SortDirection } from '~/components/data-table/data-column';
 +import { OrderDirection, OrderBuilder } from '~/services/api/order-builder';
++import { ListResults } from '~/services/common-service/common-service';
 +import { userBindedActions } from '~/store/users/users-actions';
 +import { getSortColumn } from "~/store/data-explorer/data-explorer-reducer";
 +import { UserResource } from '~/models/user';
 +import { UserPanelColumnNames } from '~/views/user-panel/user-panel';
 +
 +export class UserMiddlewareService extends DataExplorerMiddlewareService {
 +    constructor(private services: ServiceRepository, id: string) {
 +        super(id);
 +    }
 +
 +    async requestItems(api: MiddlewareAPI<Dispatch, RootState>) {
 +        const state = api.getState();
 +        const dataExplorer = getDataExplorer(state.dataExplorer, this.getId());
 +        try {
 +            const response = await this.services.userService.list(getParams(dataExplorer));
 +            api.dispatch(updateResources(response.items));
 +            api.dispatch(setItems(response));
 +        } catch {
 +            api.dispatch(couldNotFetchUsers());
 +        }
 +    }
 +}
 +
 +export const getParams = (dataExplorer: DataExplorer) => ({
 +    ...dataExplorerToListParams(dataExplorer),
 +    order: getOrder(dataExplorer),
 +    filters: getFilters(dataExplorer)
 +});
 +
 +export const getFilters = (dataExplorer: DataExplorer) => {
 +    const filters = new FilterBuilder()
 +        .addILike("username", dataExplorer.searchValue)
 +        .getFilters();
 +    return filters;
 +};
 +
 +export const getOrder = (dataExplorer: DataExplorer) => {
 +    const sortColumn = getSortColumn(dataExplorer);
 +    const order = new OrderBuilder<UserResource>();
 +    if (sortColumn) {
 +        const sortDirection = sortColumn && sortColumn.sortDirection === SortDirection.ASC
 +            ? OrderDirection.ASC
 +            : OrderDirection.DESC;
 +        const columnName = sortColumn && sortColumn.name === UserPanelColumnNames.LAST_NAME ? "lastName" : "firstName";
 +        return order
 +            .addOrder(sortDirection, columnName)
 +            .getOrder();
 +    } else {
 +        return order.getOrder();
 +    }
 +};
 +
 +export const setItems = (listResults: ListResults<UserResource>) =>
 +    userBindedActions.SET_ITEMS({
 +        ...listResultsToDataExplorerItemsMeta(listResults),
 +        items: listResults.items.map(resource => resource.uuid),
 +    });
 +
 +const couldNotFetchUsers = () =>
 +    snackbarActions.OPEN_SNACKBAR({
 +        message: 'Could not fetch users.',
 +        kind: SnackbarKind.ERROR
 +    });
index d33bdafb656e4a49065b8c9d631d0220d840e932,fdc91f43d51fd9bfa8aaea918c258391ed06fe3b..bc5eac6c8bcaa41ea74ea96ab4de5aeb8163837a
@@@ -58,9 -58,8 +58,10 @@@ import { searchResultsPanelColumns } fr
  import { loadVirtualMachinesPanel } from '~/store/virtual-machines/virtual-machines-actions';
  import { loadRepositoriesPanel } from '~/store/repositories/repositories-actions';
  import { loadKeepServicesPanel } from '~/store/keep-services/keep-services-actions';
 +import { loadUsersPanel, userBindedActions } from '~/store/users/users-actions';
 +import { userPanelColumns } from '~/views/user-panel/user-panel';
  import { loadComputeNodesPanel } from '~/store/compute-nodes/compute-nodes-actions';
+ import { loadApiClientAuthorizationsPanel } from '~/store/api-client-authorizations/api-client-authorizations-actions';
  
  export const WORKBENCH_LOADING_SCREEN = 'workbenchLoadingScreen';
  
index 000e9f5cb15a7e01fec16920fd01942259a015bd,2cd910bda106dc11b2976e24088120a0ec9913d3..6dbcf6ac8df1d5f6e28552b16a6c63451f9fc0c4
@@@ -14,8 -14,8 +14,8 @@@ import { SortDirection } from '~/compon
  import { WorkflowPanelColumnNames } from '~/views/workflow-panel/workflow-panel-view';
  import { OrderDirection, OrderBuilder } from '~/services/api/order-builder';
  import { WorkflowResource } from '~/models/workflow';
- import { ListResults } from '~/services/common-service/common-resource-service';
+ import { ListResults } from '~/services/common-service/common-service';
 -import { workflowPanelActions } from './workflow-panel-actions';
 +import { workflowPanelActions } from '~/store/workflow-panel/workflow-panel-actions';
  import { getSortColumn } from "~/store/data-explorer/data-explorer-reducer";
  
  export class WorkflowMiddlewareService extends DataExplorerMiddlewareService {
index 412f849703ff5dc54204b646823211c5f9549c42,415cba37c97b543da6ee41d4cb7dccce6f91a6c6..44b113df39e6b33a347bd661680d4af3312dae04
@@@ -12,9 -12,11 +12,12 @@@ import { logout } from '~/store/auth/au
  import { RootState } from "~/store/store";
  import { openCurrentTokenDialog } from '~/store/current-token-dialog/current-token-dialog-actions';
  import { openRepositoriesPanel } from "~/store/repositories/repositories-actions";
- import { navigateToSshKeys, navigateToKeepServices, navigateToComputeNodes, navigateToMyAccount } from '~/store/navigation/navigation-action';
+ import { 
+     navigateToSshKeys, navigateToKeepServices, navigateToComputeNodes,
+     navigateToApiClientAuthorizations, navigateToMyAccount
+ } from '~/store/navigation/navigation-action';
  import { openVirtualMachines } from "~/store/virtual-machines/virtual-machines-actions";
 +import { navigateToUsers } from '~/store/navigation/navigation-action';
  
  interface AccountMenuProps {
      user?: User;
@@@ -38,7 -40,7 +41,8 @@@ export const AccountMenu = connect(mapS
                  <MenuItem onClick={() => dispatch(openRepositoriesPanel())}>Repositories</MenuItem>
                  <MenuItem onClick={() => dispatch(openCurrentTokenDialog)}>Current token</MenuItem>
                  <MenuItem onClick={() => dispatch(navigateToSshKeys)}>Ssh Keys</MenuItem>
 +                <MenuItem onClick={() => dispatch(navigateToUsers)}>Users</MenuItem>
+                 { user.isAdmin && <MenuItem onClick={() => dispatch(navigateToApiClientAuthorizations)}>Api Tokens</MenuItem> }
                  { user.isAdmin && <MenuItem onClick={() => dispatch(navigateToKeepServices)}>Keep Services</MenuItem> }
                  { user.isAdmin && <MenuItem onClick={() => dispatch(navigateToComputeNodes)}>Compute Nodes</MenuItem> }
                  <MenuItem onClick={() => dispatch(navigateToMyAccount)}>My account</MenuItem>
index 7022fc5e3527b23470c107209ef074f9080c17c5,a3279e37730fcb4d874eb2f8605e8743e803d1e1..8c2e4ceda26a8f029b78492747942f86b92c1a17
@@@ -20,8 -20,8 +20,8 @@@ const isButtonVisible = ({ router }: Ro
      const pathname = router.location ? router.location.pathname : '';
      return !Routes.matchWorkflowRoute(pathname) && !Routes.matchVirtualMachineRoute(pathname) &&
          !Routes.matchRepositoriesRoute(pathname) && !Routes.matchSshKeysRoute(pathname) &&
-         !Routes.matchKeepServicesRoute(pathname) && !Routes.matchComputeNodesRoute(pathname) && 
-         !Routes.matchUsersRoute(pathname);
+         !Routes.matchKeepServicesRoute(pathname) && !Routes.matchComputeNodesRoute(pathname) &&
 -        !Routes.matchApiClientAuthorizationsRoute(pathname);
++        !Routes.matchApiClientAuthorizationsRoute(pathname) && !Routes.matchUsersRoute(pathname);
  };
  
  export const MainContentBar = connect((state: RootState) => ({
index e0ec14f13937bd6313524dff1f47916edd2a16ba,3cd040f78c6aeec4819c92dd5db500a1495ab9e0..70f2a2ddd207a7303851d542e999d589be24b175
@@@ -68,9 -71,7 +71,10 @@@ import { AttributesComputeNodeDialog } 
  import { AttributesKeepServiceDialog } from '~/views-components/keep-services-dialog/attributes-dialog';
  import { AttributesSshKeyDialog } from '~/views-components/ssh-keys-dialog/attributes-dialog';
  import { VirtualMachineAttributesDialog } from '~/views-components/virtual-machines-dialog/attributes-dialog';
 +import { UserPanel } from '~/views/user-panel/user-panel';
 +import { UserAttributesDialog } from '~/views-components/user-dialog/attributes-dialog';
 +import { CreateUserDialog } from '~/views-components/dialog-forms/create-user-dialog';
+ import { HelpApiClientAuthorizationDialog } from '~/views-components/api-client-authorizations-dialog/help-dialog';
  
  type CssRules = 'root' | 'container' | 'splitter' | 'asidePanel' | 'contentWrapper' | 'content';
  
@@@ -144,8 -145,8 +148,9 @@@ export const WorkbenchPanel 
                                  <Route path={Routes.REPOSITORIES} component={RepositoriesPanel} />
                                  <Route path={Routes.SSH_KEYS} component={SshKeyPanel} />
                                  <Route path={Routes.KEEP_SERVICES} component={KeepServicePanel} />
 +                                <Route path={Routes.USERS} component={UserPanel} />
                                  <Route path={Routes.COMPUTE_NODES} component={ComputeNodePanel} />
+                                 <Route path={Routes.API_CLIENT_AUTHORIZATIONS} component={ApiClientAuthorizationPanel} />
                                  <Route path={Routes.MY_ACCOUNT} component={MyAccountPanel} />
                              </Switch>
                          </Grid>