Merge branch 'master' into 14452-my-account
authorPawel Kromplewski <pawel.kromplewski@contractors.roche.com>
Mon, 3 Dec 2018 07:29:41 +0000 (08:29 +0100)
committerPawel Kromplewski <pawel.kromplewski@contractors.roche.com>
Mon, 3 Dec 2018 07:29:41 +0000 (08:29 +0100)
refs #14452

Arvados-DCO-1.1-Signed-off-by: Pawel Kromplewski <pawel.kromplewski@contractors.roche.com>

1  2 
src/models/user.ts
src/routes/route-change-handlers.ts
src/routes/routes.ts
src/services/auth-service/auth-service.ts
src/store/auth/auth-reducer.test.ts
src/store/navigation/navigation-action.ts
src/store/workbench/workbench-actions.ts
src/views-components/main-app-bar/account-menu.tsx
src/views/workbench/workbench.tsx

diff --combined src/models/user.ts
index eed135a21cf816133dc14deb4a656cce21953553,9f9c534763ca86ee40190c2361c89b4e81da2f95..dfb418892ef363192b73c5e8f6983c887910603b
@@@ -4,24 -4,13 +4,25 @@@
  
  import { Resource, ResourceKind } from '~/models/resource';
  
 +export type userPrefs = {
 +    profile?: {
 +        organization?: string,
 +        organization_email?: string,
 +        lab?: string,
 +        website_url?: string,
 +        role?: string
 +    }
 +};
 +
  export interface User {
      email: string;
      firstName: string;
      lastName: string;
      uuid: string;
      ownerUuid: string;
 +    identityUrl: string;
 +    prefs: userPrefs;
+     isAdmin: boolean;
  }
  
  export const getUserFullname = (user?: User) => {
index f2aed2db48f0411b7ba3ebcffeb2ad60483d6169,22d0b7c711364d2a466b8b0af5e2b7d465cb73aa..1f3bd93fbae297f3461a1a7393280b7df80f9baa
@@@ -4,8 -4,8 +4,10 @@@
  
  import { History, Location } from 'history';
  import { RootStore } from '~/store/store';
 +import { matchProcessRoute, matchProcessLogRoute, matchProjectRoute, matchCollectionRoute, matchFavoritesRoute, matchTrashRoute, matchRootRoute, matchSharedWithMeRoute, matchRunProcessRoute, matchWorkflowRoute, matchSearchResultsRoute, matchSshKeysRoute, matchRepositoriesRoute, matchMyAccountRoute } from './routes';
 +import { loadProject, loadCollection, loadFavorites, loadTrash, loadProcess, loadProcessLog, loadSshKeys, loadRepositories, loadMyAccount } from '~/store/workbench/workbench-actions';
+ import { matchProcessRoute, matchProcessLogRoute, matchProjectRoute, matchCollectionRoute, matchFavoritesRoute, matchTrashRoute, matchRootRoute, matchSharedWithMeRoute, matchRunProcessRoute, matchWorkflowRoute, matchSearchResultsRoute, matchSshKeysRoute, matchRepositoriesRoute, matchVirtualMachineRoute } from './routes';
+ import { loadProject, loadCollection, loadFavorites, loadTrash, loadProcess, loadProcessLog, loadSshKeys, loadRepositories, loadVirtualMachines } from '~/store/workbench/workbench-actions';
  import { navigateToRootProject } from '~/store/navigation/navigation-action';
  import { loadSharedWithMe, loadRunProcess, loadWorkflow, loadSearchResults } from '~//store/workbench/workbench-actions';
  
@@@ -27,9 -27,9 +29,10 @@@ const handleLocationChange = (store: Ro
      const searchResultsMatch = matchSearchResultsRoute(pathname);
      const sharedWithMeMatch = matchSharedWithMeRoute(pathname);
      const runProcessMatch = matchRunProcessRoute(pathname);
+     const virtualMachineMatch = matchVirtualMachineRoute(pathname);
      const workflowMatch = matchWorkflowRoute(pathname);
      const sshKeysMatch = matchSshKeysRoute(pathname);
 +    const myAccountMatch = matchMyAccountRoute(pathname);
  
      if (projectMatch) {
          store.dispatch(loadProject(projectMatch.params.id));
          store.dispatch(loadWorkflow);
      } else if (searchResultsMatch) {
          store.dispatch(loadSearchResults);
+     } else if (virtualMachineMatch) {
+         store.dispatch(loadVirtualMachines);
      } else if(repositoryMatch) {
          store.dispatch(loadRepositories);
      } else if (sshKeysMatch) {
          store.dispatch(loadSshKeys);
 +    } else if (myAccountMatch) {
 +        store.dispatch(loadMyAccount);
      }
  };
diff --combined src/routes/routes.ts
index 988b4cb4a8427eba202d287d8a678e42095c1b96,71cdfdacad218da9ea51cf636ffacd2cf95916ad..a27b4274c707002a57b5a358d5aecbb9e03c6385
@@@ -19,10 -19,10 +19,11 @@@ export const Routes = 
      REPOSITORIES: '/repositories',
      SHARED_WITH_ME: '/shared-with-me',
      RUN_PROCESS: '/run-process',
+     VIRTUAL_MACHINES: '/virtual-machines',
      WORKFLOWS: '/workflows',
      SEARCH_RESULTS: '/search-results',
 -    SSH_KEYS: `/ssh-keys`
 +    SSH_KEYS: `/ssh-keys`,
 +    MY_ACCOUNT: '/my-account'
  };
  
  export const getResourceUrl = (uuid: string) => {
@@@ -80,11 -80,11 +81,14 @@@ export const matchWorkflowRoute = (rout
  export const matchSearchResultsRoute = (route: string) =>
      matchPath<ResourceRouteParams>(route, { path: Routes.SEARCH_RESULTS });
  
+ export const matchVirtualMachineRoute = (route: string) =>
+     matchPath<ResourceRouteParams>(route, { path: Routes.VIRTUAL_MACHINES });
+     
  export const matchRepositoriesRoute = (route: string) =>
      matchPath<ResourceRouteParams>(route, { path: Routes.REPOSITORIES });
      
  export const matchSshKeysRoute = (route: string) =>
      matchPath(route, { path: Routes.SSH_KEYS });
 +
 +export const matchMyAccountRoute = (route: string) =>
 +    matchPath(route, { path: Routes.MY_ACCOUNT });
index d4e81e42ee76c88bec04814e70953cd7bcbfa335,edc6e24fce752b628a7573899f21af2e6063073b..6faaf99ee7a37109a93021cd9cafeb31c4fa57a3
@@@ -2,7 -2,7 +2,7 @@@
  //
  // SPDX-License-Identifier: AGPL-3.0
  
 -import { User } from "~/models/user";
 +import { User, userPrefs } from "~/models/user";
  import { AxiosInstance } from "axios";
  import { ApiActions, ProgressFn } from "~/services/api/api-actions";
  import * as uuid from "uuid/v4";
@@@ -13,8 -13,7 +13,9 @@@ export const USER_FIRST_NAME_KEY = 'use
  export const USER_LAST_NAME_KEY = 'userLastName';
  export const USER_UUID_KEY = 'userUuid';
  export const USER_OWNER_UUID_KEY = 'userOwnerUuid';
+ export const USER_IS_ADMIN = 'isAdmin';
 +export const USER_IDENTITY_URL = 'identityUrl';
 +export const USER_PREFS = 'prefs';
  
  export interface UserDetailsResponse {
      email: string;
@@@ -23,8 -22,6 +24,8 @@@
      uuid: string;
      owner_uuid: string;
      is_admin: boolean;
 +    identity_url: string;
 +    prefs: userPrefs;
  }
  
  export class AuthService {
          return localStorage.getItem(USER_OWNER_UUID_KEY) || undefined;
      }
  
+     public getIsAdmin(): boolean {
+         return !!localStorage.getItem(USER_IS_ADMIN);
+     }
      public getUser(): User | undefined {
          const email = localStorage.getItem(USER_EMAIL_KEY);
          const firstName = localStorage.getItem(USER_FIRST_NAME_KEY);
          const lastName = localStorage.getItem(USER_LAST_NAME_KEY);
-         const uuid = localStorage.getItem(USER_UUID_KEY);
-         const ownerUuid = localStorage.getItem(USER_OWNER_UUID_KEY);
+         const uuid = this.getUuid();
+         const ownerUuid = this.getOwnerUuid();
+         const isAdmin = this.getIsAdmin();
 +        const identityUrl = localStorage.getItem(USER_IDENTITY_URL);
 +        const prefs = JSON.parse(localStorage.getItem(USER_PREFS) || '{"profile": {}}');
 -        return email && firstName && lastName && uuid && ownerUuid
 -            ? { email, firstName, lastName, uuid, ownerUuid, isAdmin }
 +        return email && firstName && lastName && uuid && ownerUuid && identityUrl && prefs
-             ? { email, firstName, lastName, uuid, ownerUuid, identityUrl, prefs }
++            ? { email, firstName, lastName, uuid, ownerUuid, isAdmin, identityUrl, prefs }
              : undefined;
      }
  
@@@ -73,8 -74,7 +80,9 @@@
          localStorage.setItem(USER_LAST_NAME_KEY, user.lastName);
          localStorage.setItem(USER_UUID_KEY, user.uuid);
          localStorage.setItem(USER_OWNER_UUID_KEY, user.ownerUuid);
+         localStorage.setItem(USER_IS_ADMIN, JSON.stringify(user.isAdmin));
 +        localStorage.setItem(USER_IDENTITY_URL, user.identityUrl);
 +        localStorage.setItem(USER_PREFS, JSON.stringify(user.prefs));
      }
  
      public removeUser() {
@@@ -83,8 -83,7 +91,9 @@@
          localStorage.removeItem(USER_LAST_NAME_KEY);
          localStorage.removeItem(USER_UUID_KEY);
          localStorage.removeItem(USER_OWNER_UUID_KEY);
+         localStorage.removeItem(USER_IS_ADMIN);
 +        localStorage.removeItem(USER_IDENTITY_URL);
 +        localStorage.removeItem(USER_PREFS);
      }
  
      public login() {
              .get<UserDetailsResponse>('/users/current')
              .then(resp => {
                  this.actions.progressFn(reqId, false);
 +                const prefs = resp.data.prefs.profile ? resp.data.prefs : { profile: {}};
 +                console.log(resp.data);
                  return {
                      email: resp.data.email,
                      firstName: resp.data.first_name,
                      lastName: resp.data.last_name,
                      uuid: resp.data.uuid,
                      ownerUuid: resp.data.owner_uuid,
 -                    isAdmin: resp.data.is_admin
++                    isAdmin: resp.data.is_admin,
 +                    identityUrl: resp.data.identity_url,
 +                    prefs
                  };
              })
              .catch(e => {
index 592191caec493503bcce69174c78f81fdedefee4,a4017db3be7af4b83a69543fdc85d825516ec149..b9f768f1cb0a42a9653d119cc577e516b21407ba
@@@ -30,13 -30,13 +30,15 @@@ describe('auth-reducer', () => 
              lastName: "Doe",
              uuid: "uuid",
              ownerUuid: "ownerUuid",
-             prefs: {}
 +            identityUrl: "identityUrl",
++            prefs: {},
+             isAdmin: false
          };
          const state = reducer(initialState, authActions.INIT({ user, token: "token" }));
          expect(state).toEqual({
              apiToken: "token",
-             user
+             user,
+             sshKeys: []
          });
      });
  
@@@ -60,8 -60,7 +62,9 @@@
              lastName: "Doe",
              uuid: "uuid",
              ownerUuid: "ownerUuid",
-             prefs: {}
 +            identityUrl: "identityUrl",
++            prefs: {},
+             isAdmin: false
          };
  
          const state = reducer(initialState, authActions.USER_DETAILS_SUCCESS(user));
@@@ -74,6 -73,7 +77,7 @@@
                  lastName: "Doe",
                  uuid: "uuid",
                  ownerUuid: "ownerUuid",
+                 isAdmin: false
              }
          });
      });
index 0b6713bf04cb0d685b59e85f0327bb04a2256c56,2bfd8b9944ec75e4911ab2bbd08c19676cab62c5..80a7f2136eee707a5c87e320d9b74722a4e1ff20
@@@ -62,8 -62,8 +62,10 @@@ export const navigateToRunProcess = pus
  
  export const navigateToSearchResults = push(Routes.SEARCH_RESULTS);
  
+ export const navigateToVirtualMachines = push(Routes.VIRTUAL_MACHINES);
  export const navigateToRepositories = push(Routes.REPOSITORIES);
  
  export const navigateToSshKeys= push(Routes.SSH_KEYS);
 +
 +export const navigateToMyAccount = push(Routes.MY_ACCOUNT);
index dc54e4b861c1c235e888e5fea1f2d2ee547e8d21,12dbe7b1a8a2d71ebfcd35eb4c2fb27cd8c6fdec..091a8ccc7c9583c41d97bd4067816eadb491528e
@@@ -40,7 -40,6 +40,7 @@@ import { loadSharedWithMePanel } from '
  import { CopyFormDialogData } from '~/store/copy-dialog/copy-dialog';
  import { loadWorkflowPanel, workflowPanelActions } from '~/store/workflow-panel/workflow-panel-actions';
  import { loadSshKeysPanel } from '~/store/auth/auth-action';
 +import { loadMyAccountPanel } from '~/store/my-account/my-account-panel-actions';
  import { workflowPanelColumns } from '~/views/workflow-panel/workflow-panel-view';
  import { progressIndicatorActions } from '~/store/progress-indicator/progress-indicator-actions';
  import { getProgressIndicator } from '~/store/progress-indicator/progress-indicator-reducer';
@@@ -55,6 -54,7 +55,7 @@@ import { collectionPanelActions } from 
  import { CollectionResource } from "~/models/collection";
  import { searchResultsPanelActions, loadSearchResultsPanel } from '~/store/search-results-panel/search-results-panel-actions';
  import { searchResultsPanelColumns } from '~/views/search-results-panel/search-results-panel-view';
+ import { loadVirtualMachinesPanel } from '~/store/virtual-machines/virtual-machines-actions';
  import { loadRepositoriesPanel } from '~/store/repositories/repositories-actions';
  
  export const WORKBENCH_LOADING_SCREEN = 'workbenchLoadingScreen';
@@@ -393,6 -393,12 +394,12 @@@ export const loadSearchResults = handle
          await dispatch(loadSearchResultsPanel());
      });
  
+ export const loadVirtualMachines = handleFirstTimeLoad(
+     async (dispatch: Dispatch<any>) => {
+         await dispatch(loadVirtualMachinesPanel());
+         dispatch(setBreadcrumbs([{ label: 'Virtual Machines' }]));
+     });
+     
  export const loadRepositories = handleFirstTimeLoad(
      async (dispatch: Dispatch<any>) => {
          await dispatch(loadRepositoriesPanel());
@@@ -404,11 -410,6 +411,11 @@@ export const loadSshKeys = handleFirstT
          await dispatch(loadSshKeysPanel());
      });
  
 +export const loadMyAccount = handleFirstTimeLoad(
 +    async (dispatch: Dispatch<any>) => {
 +        await dispatch(loadMyAccountPanel());
 +    });
 +
  const finishLoadingProject = (project: GroupContentsResource | string) =>
      async (dispatch: Dispatch<any>) => {
          const uuid = typeof project === 'string' ? project : project.uuid;
index b93bfcfbedecf90de608d3acb2eb90ab62d26c7e,ca88021ccdb04c6491ec5389f94dade7ccd35424..0aedee9001c4bde86a49950502e3622feae5b624
@@@ -12,7 -12,8 +12,8 @@@ import { logout } from '~/store/auth/au
  import { RootState } from "~/store/store";
  import { openCurrentTokenDialog } from '~/store/current-token-dialog/current-token-dialog-actions';
  import { openRepositoriesPanel } from "~/store/repositories/repositories-actions";
 -import { navigateToSshKeys } from '~/store/navigation/navigation-action';
 +import { navigateToSshKeys, navigateToMyAccount } from '~/store/navigation/navigation-action';
+ import { openVirtualMachines } from "~/store/virtual-machines/virtual-machines-actions";
  
  interface AccountMenuProps {
      user?: User;
@@@ -32,10 -33,11 +33,11 @@@ export const AccountMenu = connect(mapS
                  <MenuItem>
                      {getUserFullname(user)}
                  </MenuItem>
+                 <MenuItem onClick={() => dispatch(openVirtualMachines())}>Virtual Machines</MenuItem>
                  <MenuItem onClick={() => dispatch(openRepositoriesPanel())}>Repositories</MenuItem>
                  <MenuItem onClick={() => dispatch(openCurrentTokenDialog)}>Current token</MenuItem>
                  <MenuItem onClick={() => dispatch(navigateToSshKeys)}>Ssh Keys</MenuItem>
 -                <MenuItem>My account</MenuItem>
 +                <MenuItem onClick={() => dispatch(navigateToMyAccount)}>My account</MenuItem>
                  <MenuItem onClick={() => dispatch(logout())}>Logout</MenuItem>
              </DropdownMenu>
              : null);
index 8542e6ca36a278a54e59c395ea63c4900e6c9ce0,3914f64632e716bfe0aa4aca8265ae42a6a6bc93..2cff4317e5576470c44e22ff910a043302a4aa3f
@@@ -45,10 -45,10 +45,11 @@@ import SplitterLayout from 'react-split
  import { WorkflowPanel } from '~/views/workflow-panel/workflow-panel';
  import { SearchResultsPanel } from '~/views/search-results-panel/search-results-panel';
  import { SshKeyPanel } from '~/views/ssh-key-panel/ssh-key-panel';
 +import { MyAccountPanel } from '~/views/my-account-panel/my-account-panel';
  import { SharingDialog } from '~/views-components/sharing-dialog/sharing-dialog';
  import { AdvancedTabDialog } from '~/views-components/advanced-tab-dialog/advanced-tab-dialog';
  import { ProcessInputDialog } from '~/views-components/process-input-dialog/process-input-dialog';
+ import { VirtualMachinePanel } from '~/views/virtual-machine-panel/virtual-machine-panel';
  import { ProjectPropertiesDialog } from '~/views-components/project-properties-dialog/project-properties-dialog';
  import { RepositoriesPanel } from '~/views/repositories-panel/repositories-panel';
  import { RepositoriesSampleGitDialog } from '~/views-components/repositories-sample-git-dialog/repositories-sample-git-dialog';
@@@ -128,9 -128,9 +129,10 @@@ export const WorkbenchPanel 
                                  <Route path={Routes.RUN_PROCESS} component={RunProcessPanel} />
                                  <Route path={Routes.WORKFLOWS} component={WorkflowPanel} />
                                  <Route path={Routes.SEARCH_RESULTS} component={SearchResultsPanel} />
+                                 <Route path={Routes.VIRTUAL_MACHINES} component={VirtualMachinePanel} />
                                  <Route path={Routes.REPOSITORIES} component={RepositoriesPanel} />
                                  <Route path={Routes.SSH_KEYS} component={SshKeyPanel} />
 +                                <Route path={Routes.MY_ACCOUNT} component={MyAccountPanel} />
                              </Switch>
                          </Grid>
                      </Grid>