21077: Add explicit START/STOP_WORKING to loading functions 21077-background-refresh
authorPeter Amstutz <peter.amstutz@curii.com>
Thu, 19 Oct 2023 14:31:32 +0000 (10:31 -0400)
committerPeter Amstutz <peter.amstutz@curii.com>
Thu, 19 Oct 2023 14:31:32 +0000 (10:31 -0400)
commit20798b41fd3a5c012141391403d7caf066f46086
tree627916233e969ff7167182f14bc0f51f514e9dc6
parent5729de6b47d3e1bf40f4b2869ffcc6fbf88d0085
21077: Add explicit START/STOP_WORKING to loading functions

Previously, progressFn meant that any time there was an active API
request, it would spin the progress bar.  To allow for background
requests (where we don't want it to spin because it is
distracting/confusing to the user), we need to remove that default
behavior.  As a result, to provide feedback that something is
happening, functions need to explicitly set START_WORKING and
STOP_WORKING.  This was implemented inconsistently, because the
default processFn behavior tended to cover a lot of cases.

This commit adds START/STOP to all the major panel loading functions
in the UI.  This provides better user feedback overall, because the
spinner now more consistently covers the entire loading
process (across multiple API calls and async behavior), instead of
just individual API calls.

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
src/store/breadcrumbs/breadcrumbs-actions.ts
src/store/collection-panel/collection-panel-action.ts
src/store/group-details-panel/group-details-panel-members-middleware-service.ts
src/store/link-panel/link-panel-middleware-service.ts
src/store/process-panel/process-panel-actions.ts
src/store/processes/process.ts
src/store/users/user-panel-middleware-service.ts
src/store/virtual-machines/virtual-machines-actions.ts
src/store/workbench/workbench-actions.ts